[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge updated this revision to Diff 78216. rSerge added a comment. Rebased to the latest version of LLVM sources. https://reviews.llvm.org/D26415 Files: lib/Driver/Tools.cpp test/Driver/XRay/xray-instrument-cpu.c test/Driver/XRay/xray-instrument-os.c Index: test/Driver/XRay/xray-instru

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 +if (Triple.getOS() != llvm::Triple::Linux) + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on non-Linux target OS."); +switch (Triple.getArch()) {

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge updated this revision to Diff 77675. https://reviews.llvm.org/D26415 Files: lib/Driver/Tools.cpp test/Driver/XRay/xray-instrument-cpu.c test/Driver/XRay/xray-instrument-os.c Index: test/Driver/XRay/xray-instrument-os.c ===

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge marked an inline comment as done. rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 +if (Triple.getOS() != llvm::Triple::Linux) + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on non-Linux targe

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge marked 5 inline comments as done. rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 if (Triple.getOS() == llvm::Triple::Linux && (Triple.getArch() == llvm::Triple::arm || - Triple.getArch() == llvm::Triple::x86_64)) { +

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge updated this revision to Diff 77537. https://reviews.llvm.org/D26415 Files: lib/Driver/Tools.cpp test/Driver/XRay/xray-instrument-cpu.c test/Driver/XRay/xray-instrument-os.c Index: test/Driver/XRay/xray-instrument-os.c ===

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 if (Triple.getOS() == llvm::Triple::Linux && (Triple.getArch() == llvm::Triple::arm || - Triple.getArch() == llvm::Triple::x86_64)) { + Triple.getArch() == llvm::Triple::x86_64

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4903-4906 if (Triple.getOS() == llvm::Triple::Linux && (Triple.getArch() == llvm::Triple::arm || - Triple.getArch() == llvm::Triple::x86_64)) { + Triple.getArch() == llvm::Triple::x86_64

[PATCH] D26415: [XRay] Support AArch64 in Clang

rSerge created this revision. rSerge added reviewers: dberris, rengolin. rSerge added subscribers: iid_iunknown, cfe-commits. Herald added a subscriber: aemerson. This patch adds XRay support in Clang for AArch64 target. https://reviews.llvm.org/D26415 Files: lib/Driver/Tools.cpp test/Drive

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , I've checked the .diff file which I was uploading to Phabricator, and it doesn't seem to contain trailing whitespace. Please, see the screenshot: F2536547: Whitespace.jpg So it seems that Phabricator or your downloading tool a

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , thanks! I ran clang-format on Tools.cpp , then just copy-pasted the changed piece. Do you remember, was the whitespace problem in this file? Or was it in the tests? Repository: rL LLVM https://reviews.llvm.org/D24799

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 75452. rSerge added a comment. I had to add the root directories `a` and `b` manually, as I couldn't find an `svn diff` argument for that. The code file `Tools.cpp` was run via `clang-format`, then just my changes were copy-pasted. 2 tests have been added to

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , below is the list of features supported by `REQUIRES` and `REQUIRES-ANY` for me: set(['system-windows', 'nozlib', u'amdgpu-registered-target', 'case-insensitive-filesystem', u'msp430-registered-target', u'sparc-registered-target', 'libgcc', 'staticanalyzer'

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. Ping? (please, see the question about the test) https://reviews.llvm.org/D24799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 74829. https://reviews.llvm.org/D24799 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp === --- lib/Driver/Tools.cpp +++ lib/Driver/Tools.cpp @@ -4804,7 +4804,16 @@ if (Args.hasFla

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. I have extended this feature to check for OS support too (currently Linux only). I can't commit it so far because I don't know how to implement a test. XFAIL cannot check for both CPU and OS: it can only check for one of them. I tried to implement 2 tests instead like th

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 73824. https://reviews.llvm.org/D24799 Files: lib/Driver/Tools.cpp test/Driver/xray-instrument.c Index: test/Driver/xray-instrument.c === --- test/Driver/xray-instrument.c +++ test/Driver/xr

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. In https://reviews.llvm.org/D24799#563058, @dberris wrote: > Are we sure this will not fail on Windows? i.e. have you built/run the tests > on Windws ARM or X86_64? The test itself passes for `arm-pc-win32` and `x86_64-pc-win32` on my machine. So in this sense it doesn

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 73673. https://reviews.llvm.org/D24799 Files: lib/Driver/Tools.cpp test/Driver/xray-instrument.c Index: test/Driver/xray-instrument.c === --- test/Driver/xray-instrument.c +++ test/Driver/xr

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. In https://reviews.llvm.org/D24799#561879, @dberris wrote: > In https://reviews.llvm.org/D24799#561106, @rSerge wrote: > > > My mistake was that initially I only enumerated the unsupported targets > > from llvm\include\llvm\ADT\Triple.h . Now I've added also the cases fro

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge removed rL LLVM as the repository for this revision. rSerge updated this revision to Diff 73509. rSerge added a comment. My mistake was that initially I only enumerated the unsupported targets from llvm\include\llvm\ADT\Triple.h . Now I've added also the cases from llvm\lib\Support\Triple

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , could you deliver this patch to mainline? Or do we need approval from more reviewers? https://reviews.llvm.org/D24799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 72554. rSerge added a comment. Implemented a workaround for XFAIL not differentiating between `x86` and `x86_64` because it searches for a substring in the triple string, thus `x86` matches both `x86-X-Y-Z` and `x86_64-X-Y-Z`. https://reviews.llvm.org/D2479

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4777-4780 @@ +4776,6 @@ +{ + std::string Feature(XRayInstrumentOption); + Feature += " on "; + Feature += Triple.getArchName().data(); + D.Diag(diag::err_drv_clang_unsupported) << Feature; +

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 72312. rSerge added a comment. Herald added a subscriber: rampitec. Added a test. Changed the error message to: > clang++.exe: error: the clang compiler does not support '-fxray-instrument on > armv6kz--linux-gnueabihf' https://reviews.llvm.org/D24799 Fil

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. In https://reviews.llvm.org/D24799#549442, @dberris wrote: > What does the error actually look like? Can you add a test for it? It's > unclear to me how this would read... for example does it say "XRay for arm is > unsupported"? In the attached picture you can see how

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge created this revision. rSerge added reviewers: rsmith, dberris. rSerge added subscribers: cfe-commits, iid_iunknown. Herald added a subscriber: dberris. Added the code which explicitly emits an error in Clang in case `-fxray-instrument` is passed, but XRay is not supported for the selected

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

rSerge updated this revision to Diff 71635. rSerge added a comment. Fixed patch file format. https://reviews.llvm.org/D23932 Files: test/CodeGen/xray-attributes-supported-arm.cpp Index: test/CodeGen/xray-attributes-supported-arm.cpp ===

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

rSerge updated this revision to Diff 71629. https://reviews.llvm.org/D23932 Files: test/CodeGen/xray-attributes-supported-arm.cpp Index: test/CodeGen/xray-attributes-supported-arm.cpp === --- test/CodeGen/xray-attributes-supported

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

rSerge added a comment. I don't have commit access rights. Could someone commit? https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

rSerge created this revision. rSerge added reviewers: dberris, rengolin. rSerge added a subscriber: cfe-commits. Herald added subscribers: dberris, samparker, rengolin, aemerson. Just a test for now, adapted from x86_64 tests of XRay. https://reviews.llvm.org/D23932 Files: test/CodeGen/xray-at