@@ -2,122 +2,123 @@
// RUN: %clang -cl-std=CL2.0 -emit-llvm -g -O0 -S -nogpulib -target
amdgcn-amd-amdhsa -mcpu=fiji -o - %s | FileCheck %s
// RUN: %clang -cl-std=CL2.0 -emit-llvm -g -O0 -S -nogpulib -target
amdgcn-amd-amdhsa-opencl -mcpu=fiji -o - %s | FileCheck %s
-// CHEC
@@ -52,31 +52,31 @@ int *constant FileVar14 = 0;
kernel void kernel1(
// CHECK-DAG: ![[KERNELARG0:[0-9]+]] = !DILocalVariable(name:
"KernelArg0", arg: {{[0-9]+}}, scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line:
{{[0-9]+}}, type: !{{[0-9]+}})
-// CHECK-DAG: #dbg_declare(
@@ -262,8 +285,10 @@ static bool printCompactDWARFExpr(
break;
}
case dwarf::DW_OP_LLVM_user: {
- assert(Op.getSubCode() == dwarf::DW_OP_LLVM_nop);
- break;
+ std::optional SubOpcode = Op.getSubCode();
+ if (SubOpcode == dwarf::DW_OP_LLVM_nop)
@@ -141,3 +141,9 @@ TEST_F(DWARFExpressionCompactPrinterTest,
Test_OP_nop_OP_reg) {
TEST_F(DWARFExpressionCompactPrinterTest, Test_OP_LLVM_nop_OP_reg) {
TestExprPrinter({DW_OP_LLVM_user, DW_OP_LLVM_nop, DW_OP_reg0}, "R0");
}
+
+TEST_F(DWARFExpressionCompactPrinterTest, Test_
https://github.com/slinder1 updated
https://github.com/llvm/llvm-project/pull/153883
>From a1d7eceddb6588f94c173bf43f99c28103f29a38 Mon Sep 17 00:00:00 2001
From: Scott Linder
Date: Fri, 15 Aug 2025 21:35:36 +
Subject: [PATCH] [Dwarf] Support heterogeneous DW_{OP,AT}s needed for AMDGPU
CFI
slinder1 wrote:
Ping
Since this touched some includes I also confirmed it is benign in terms of
compile time impact
http://llvm-compile-time-tracker.com/compare.php?from=21a5729b87a6c2e271334049fa28af10fa12f0c7&to=782cde16ae3d58ff50f8ec3b304771189cf54e10&stat=instructions%3Au
https://github.c
https://github.com/slinder1 updated
https://github.com/llvm/llvm-project/pull/153883
>From 5182ae0c6a37825778c05b5402d86d357d2b2e01 Mon Sep 17 00:00:00 2001
From: Scott Linder
Date: Fri, 15 Aug 2025 21:35:36 +
Subject: [PATCH 1/2] [Dwarf] Support heterogeneous DW_{OP,AT}s needed for
AMDGPU
https://github.com/slinder1 created
https://github.com/llvm/llvm-project/pull/153883
These are defined in the user range until standard versions of them get adopted
into dwarf, which is expected in DWARF6.
Some of these amount to reservations currently as no code to use them is
included. It w
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the
following target specific
=== =
+Function Resource Usage
+---
+
+The function resourc
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the
following target specific
=== =
+Function Resource Usage
+---
+
+The function resourc
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the
following target specific
=== =
+Function Resource Usage
+---
+
+The function resourc
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the
following target specific
=== =
+Function Resource Usage
+---
+
+The function resourc
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the
following target specific
=== =
+Function Resource Usage
+---
+
+The function resourc
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the
following target specific
=== =
+Function Resource Usage
+---
+
+The function resourc
https://github.com/slinder1 edited
https://github.com/llvm/llvm-project/pull/102913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/slinder1 requested changes to this pull request.
Thank you for writing this up! I have some stylistic comments, but otherwise
LGTM
https://github.com/llvm/llvm-project/pull/102913
___
cfe-commits mailing list
cfe-commits@lists.llvm.
@@ -0,0 +1,220 @@
+//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,220 @@
+//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,220 @@
+//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,220 @@
+//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,220 @@
+//===- AMDGPUMCResourceInfo.cpp --- MC Resource Info
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/slinder1 commented:
LGTM, with some nits
The expressions look pretty reasonable to me, although I didn't really go
through validating that they are correct
https://github.com/llvm/llvm-project/pull/102913
___
cfe-commits mailing li
https://github.com/slinder1 edited
https://github.com/llvm/llvm-project/pull/102913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
slinder1 wrote:
Is it best to leave comments on the commit from the PR comment, i.e. currently
https://github.com/llvm/llvm-project/commit/51f72f115b340a092c2c9f8569911b944a4efb6d
?
I can't seem to start a review, so it will be individual comments (I think). Is
there another way to handle thi
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
https://github.com/slinder1 edited
https://github.com/llvm/llvm-project/pull/70898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
@@ -2030,187 +2030,219 @@ bool Node::failed() const {
}
StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const {
- // TODO: Handle newlines properly. We need to remove leading whitespace.
- if (Value[0] == '"') { // Double quoted.
-// Pull off the leading and tra
https://github.com/slinder1 requested changes to this pull request.
I don't mean to make existing debt your problem, but if it isn't too much work
could you post a pre-patch that just adds the `FileCheck`s to the existing
tests where the behavior changes, so the test diff is more self-documenti
Author: Scott Linder
Date: 2023-02-15T17:34:35Z
New Revision: 97ba3c2bec48ca55cc842c6499b19b0b8a271951
URL:
https://github.com/llvm/llvm-project/commit/97ba3c2bec48ca55cc842c6499b19b0b8a271951
DIFF:
https://github.com/llvm/llvm-project/commit/97ba3c2bec48ca55cc842c6499b19b0b8a271951.diff
LOG:
Author: Scott Linder
Date: 2023-01-23T22:50:49Z
New Revision: 25c0ea2a5370813f46686918a84e0de27e107d08
URL:
https://github.com/llvm/llvm-project/commit/25c0ea2a5370813f46686918a84e0de27e107d08
DIFF:
https://github.com/llvm/llvm-project/commit/25c0ea2a5370813f46686918a84e0de27e107d08.diff
LOG:
Author: Scott Linder
Date: 2022-04-05T19:10:23Z
New Revision: 09f33a430b72fffe06fde9e07c0acd5c4cd2e59e
URL:
https://github.com/llvm/llvm-project/commit/09f33a430b72fffe06fde9e07c0acd5c4cd2e59e
DIFF:
https://github.com/llvm/llvm-project/commit/09f33a430b72fffe06fde9e07c0acd5c4cd2e59e.diff
LOG:
Author: Scott Linder
Date: 2021-08-02T18:04:01Z
New Revision: 635c5ba45baee5c6a8841fbac06f6868ddae5a6d
URL:
https://github.com/llvm/llvm-project/commit/635c5ba45baee5c6a8841fbac06f6868ddae5a6d
DIFF:
https://github.com/llvm/llvm-project/commit/635c5ba45baee5c6a8841fbac06f6868ddae5a6d.diff
LOG:
Author: Scott Linder
Date: 2021-05-17T22:25:39Z
New Revision: af5247c9347dcf1e30443786bdddf23ca705867a
URL:
https://github.com/llvm/llvm-project/commit/af5247c9347dcf1e30443786bdddf23ca705867a
DIFF:
https://github.com/llvm/llvm-project/commit/af5247c9347dcf1e30443786bdddf23ca705867a.diff
LOG:
Author: Scott Linder
Date: 2021-04-30T17:11:50Z
New Revision: cab19d84ce85cbceec7fde515cc686d6a83a5f9d
URL:
https://github.com/llvm/llvm-project/commit/cab19d84ce85cbceec7fde515cc686d6a83a5f9d
DIFF:
https://github.com/llvm/llvm-project/commit/cab19d84ce85cbceec7fde515cc686d6a83a5f9d.diff
LOG:
Author: Scott Linder
Date: 2021-01-11T17:23:24Z
New Revision: c15b0e2229ea04d1c36fafaa1f717f433a995e9a
URL:
https://github.com/llvm/llvm-project/commit/c15b0e2229ea04d1c36fafaa1f717f433a995e9a
DIFF:
https://github.com/llvm/llvm-project/commit/c15b0e2229ea04d1c36fafaa1f717f433a995e9a.diff
LOG:
Author: Scott Linder
Date: 2020-12-21T21:43:51Z
New Revision: ffba47df76460905965df4b54cf6ba945d2eb1ce
URL:
https://github.com/llvm/llvm-project/commit/ffba47df76460905965df4b54cf6ba945d2eb1ce
DIFF:
https://github.com/llvm/llvm-project/commit/ffba47df76460905965df4b54cf6ba945d2eb1ce.diff
LOG:
Author: Scott Linder
Date: 2020-10-16T17:53:27Z
New Revision: c4d10e7e9bb47b77fad43d8ddcfa328298f36c88
URL:
https://github.com/llvm/llvm-project/commit/c4d10e7e9bb47b77fad43d8ddcfa328298f36c88
DIFF:
https://github.com/llvm/llvm-project/commit/c4d10e7e9bb47b77fad43d8ddcfa328298f36c88.diff
LOG:
Author: Scott Linder
Date: 2020-10-09T19:03:21Z
New Revision: 40cef5a00eb83f44e946912b74be83e8dc02effb
URL:
https://github.com/llvm/llvm-project/commit/40cef5a00eb83f44e946912b74be83e8dc02effb
DIFF:
https://github.com/llvm/llvm-project/commit/40cef5a00eb83f44e946912b74be83e8dc02effb.diff
LOG:
Author: Scott Linder
Date: 2020-02-21T19:16:59-05:00
New Revision: 340feac6721e840f88c1e77dd79931eea5eaccf3
URL:
https://github.com/llvm/llvm-project/commit/340feac6721e840f88c1e77dd79931eea5eaccf3
DIFF:
https://github.com/llvm/llvm-project/commit/340feac6721e840f88c1e77dd79931eea5eaccf3.diff
Author: Scott Linder
Date: 2020-02-20T17:36:56-05:00
New Revision: 577d9ce35532439203411c999deefc9c80e04c69
URL:
https://github.com/llvm/llvm-project/commit/577d9ce35532439203411c999deefc9c80e04c69
DIFF:
https://github.com/llvm/llvm-project/commit/577d9ce35532439203411c999deefc9c80e04c69.diff
Author: Scott Linder
Date: 2020-02-20T16:31:17-05:00
New Revision: 6123074d0c0de3614f1552f2f2d6b9db7b32cebe
URL:
https://github.com/llvm/llvm-project/commit/6123074d0c0de3614f1552f2f2d6b9db7b32cebe
DIFF:
https://github.com/llvm/llvm-project/commit/6123074d0c0de3614f1552f2f2d6b9db7b32cebe.diff
Author: Scott Linder
Date: 2019-12-05T11:27:12-05:00
New Revision: d96ea47c75fdf4a62358eae49a0026bcf031bde6
URL:
https://github.com/llvm/llvm-project/commit/d96ea47c75fdf4a62358eae49a0026bcf031bde6
DIFF:
https://github.com/llvm/llvm-project/commit/d96ea47c75fdf4a62358eae49a0026bcf031bde6.diff
Author: Scott Linder
Date: 2019-11-14T11:51:11-05:00
New Revision: c9de002a2cf02b1a00abe5caaa05fd722583218a
URL:
https://github.com/llvm/llvm-project/commit/c9de002a2cf02b1a00abe5caaa05fd722583218a
DIFF:
https://github.com/llvm/llvm-project/commit/c9de002a2cf02b1a00abe5caaa05fd722583218a.diff
Author: scott.linder
Date: Mon Oct 21 12:04:56 2019
New Revision: 375442
URL: http://llvm.org/viewvc/llvm-project?rev=375442&view=rev
Log:
[Clang] Add VerboseOutputStream to CompilerInstance
Remove one instance of a hardcoded output stream in
CompilerInstance::ExecuteAction. There are still other
Author: scott.linder
Date: Thu May 2 12:03:57 2019
New Revision: 359814
URL: http://llvm.org/viewvc/llvm-project?rev=359814&view=rev
Log:
[Sema] Emit warning for visibility attribute on internal-linkage declaration
GCC warns on these cases, but we currently just silently ignore the attribute.
D
Author: scott.linder
Date: Wed May 1 09:45:49 2019
New Revision: 359702
URL: http://llvm.org/viewvc/llvm-project?rev=359702&view=rev
Log:
Bump DIAG_SIZE_SEMA, as we've hit it.
$ grep 'DIAG_SIZE_SEMA =' include/clang/Basic/DiagnosticIDs.h
DIAG_SIZE_SEMA = 4000,
$ grep DIAG
Author: scott.linder
Date: Tue Apr 23 14:50:11 2019
New Revision: 359039
URL: http://llvm.org/viewvc/llvm-project?rev=359039&view=rev
Log:
Move setTargetAttributes after setGVProperties in SetFunctionAttributes
AMDGPU currently relies on global properties being set before
setTargetProperties is c
Author: scott.linder
Date: Fri Mar 29 10:45:40 2019
New Revision: 357285
URL: http://llvm.org/viewvc/llvm-project?rev=357285&view=rev
Log:
[AMDGPU] Switch default DWARF version to 5
Effectively reverts r337612. The issues that cropped up with the last
attempt appear to have gone away.
Differenti
Author: scott.linder
Date: Tue Feb 12 10:30:38 2019
New Revision: 353870
URL: http://llvm.org/viewvc/llvm-project?rev=353870&view=rev
Log:
[AMDGPU] Require at least protected visibility for certain symbols
This allows the global visibility controls to be restrictive while still
populating the dyn
Author: scott.linder
Date: Mon Jan 28 09:12:19 2019
New Revision: 352391
URL: http://llvm.org/viewvc/llvm-project?rev=352391&view=rev
Log:
Add -fapply-global-visibility-to-externs for -cc1
Introduce an option to request global visibility settings be applied to
declarations without a definition or
Author: scott.linder
Date: Fri Dec 14 07:38:15 2018
New Revision: 349155
URL: http://llvm.org/viewvc/llvm-project?rev=349155&view=rev
Log:
Implement -frecord-command-line (-frecord-gcc-switches)
Implement options in clang to enable recording the driver command-line
in an ELF section.
Implement a
Author: scott.linder
Date: Wed Nov 14 11:39:59 2018
New Revision: 346884
URL: http://llvm.org/viewvc/llvm-project?rev=346884&view=rev
Log:
[Support] Teach YAMLIO about polymorphic types
Add support for "polymorphic" types to YAMLIO.
PolymorphicTraits can dynamically switch between other traits (
Author: scott.linder
Date: Wed Nov 14 11:39:59 2018
New Revision: 346884
URL: http://llvm.org/viewvc/llvm-project?rev=346884&view=rev
Log:
[Support] Teach YAMLIO about polymorphic types
Add support for "polymorphic" types to YAMLIO.
PolymorphicTraits can dynamically switch between other traits (
Author: scott.linder
Date: Wed Aug 8 08:56:12 2018
New Revision: 339265
URL: http://llvm.org/viewvc/llvm-project?rev=339265&view=rev
Log:
[DebugInfo][OpenCL] Address post-commit review for r338299
NFC refactor of code to generate debug info for OpenCL 2.X blocks.
Differential Revision: https://
Author: scott.linder
Date: Tue Aug 7 08:52:49 2018
New Revision: 339150
URL: http://llvm.org/viewvc/llvm-project?rev=339150&view=rev
Log:
[OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return
Always emit alloca in entry block for enqueue_kernel builtin.
Ensures the stati
Author: scott.linder
Date: Fri Aug 3 08:50:52 2018
New Revision: 338899
URL: http://llvm.org/viewvc/llvm-project?rev=338899&view=rev
Log:
[OpenCL] Always emit alloca in entry block for enqueue_kernel builtin
Ensures the statically sized alloca is not converted to DYNAMIC_STACKALLOC
later because
Author: scott.linder
Date: Mon Jul 30 15:52:07 2018
New Revision: 338321
URL: http://llvm.org/viewvc/llvm-project?rev=338321&view=rev
Log:
Fix use of uninitialized variable in r338299
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
http:/
Author: scott.linder
Date: Mon Jul 30 13:31:11 2018
New Revision: 338299
URL: http://llvm.org/viewvc/llvm-project?rev=338299&view=rev
Log:
[DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL
OpenCL block literal structs have different fields which are now correctly
identified
Author: scott.linder
Date: Mon Feb 26 09:32:31 2018
New Revision: 326102
URL: http://llvm.org/viewvc/llvm-project?rev=326102&view=rev
Log:
[DebugInfo] Support DWARF v5 source code embedding extension
In DWARF v5 the Line Number Program Header is extensible, allowing values with
new content types.
Author: scott.linder
Date: Mon Feb 26 08:31:08 2018
New Revision: 326099
URL: http://llvm.org/viewvc/llvm-project?rev=326099&view=rev
Log:
[CodeGen][DebugInfo] Refactor duplicated code, NFC
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
Author: scott.linder
Date: Mon Feb 12 11:47:05 2018
New Revision: 324929
URL: http://llvm.org/viewvc/llvm-project?rev=324929&view=rev
Log:
[DebugInfo] Update Checksum handling in CGDebugInfo
Update to match new DIFile API.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/Cod
63 matches
Mail list logo
