Re: r276934 - [OpenMP] Add support to map member expressions with references to pointers.

2016-11-03 Thread Samuel F Antao via cfe-commits
Hi Richard,   The tests in each section of the file use slightly different code, so it is not like the same code is generated multiple times. In each section the same code is compiled 4 times with different configurations Regular/Precompiled Header and 64/32.   If I compile the code in a single go,

Re: RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-11-03 Thread Samuel F Antao via cfe-commits
This issue should be fixed in r285925.   Thanks, Samuel   - Original message -From: "Hahnfeld, Jonas" To: "Hahnfeld, Jonas" , Samuel F Antao/Watson/IBM@IBMUSCc: "cfe-commits@lists.llvm.org" Subject: RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.Date: T

Re: RE: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-11-03 Thread Samuel F Antao via cfe-commits
Hi Jonas,   Thanks for the quotes. I'll rename one of the versions of ConstructJob to make the problem disappear. I'll post a patch soon.   Thanks again, Samuel    - Original message -From: "Hahnfeld, Jonas" To: "Hahnfeld, Jonas" , Samuel F Antao/Watson/IBM@IBMUSCc: "cfe-commits@lists.llvm.

Re: RE: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-11-03 Thread Samuel F Antao via cfe-commits
Hi Jonas,   I think that the code is correct. Is probably some bug in the compiler. We are not hiding anything - the compiler is checking against the wrong virtual function (using the wrong signature).   I am in process to compile the same version of gcc the bot is using to see if there is any mass

Re: r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

2016-10-31 Thread Samuel F Antao via cfe-commits
Hi Galina,   Thanks for letting me know. Can you tell me which compiler (kind and version) is used in the buildbot slave? Looks like that compiler is not doing what it should, so I need to be able to test a workaround.   We have     virtual void ConstructJob(Compilation &C, const JobAction &JA,   

Re: r279653 - Fix offload bundler tests so that diagnostic can start with caps.

2016-08-25 Thread Samuel F Antao via cfe-commits
Thanks for letting me know, should be fixed in r279741. Samuel   - Original message -From: Vitaly Buka To: Samuel F Antao/Watson/IBM@IBMUS, cfe-commits@lists.llvm.orgCc:Subject: Re: r279653 - Fix offload bundler tests so that diagnostic can start with caps.Date: Thu, Aug 25, 2016 4:04 AM  I

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-29 Thread Samuel F Antao via cfe-commits
IBMUS> Cc: Mike Aizatsky , cfe-commits> > Subject: Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.> Date: Fri, Jul 29, 2016 3:53 PM>> Yes, it still appears to be broken:>> http://lab.llvm.org:8011/builders/sanitizer-windows/builds/26504/steps/run%20tests/logs/stdio

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-29 Thread Samuel F Antao via cfe-commits
16 3:53 PM  Yes, it still appears to be broken:http://lab.llvm.org:8011/builders/sanitizer-windows/builds/26504/steps/run%20tests/logs/stdioOn Thu, Jul 28, 2016 at 1:30 PM, Samuel F Antao via cfe-commits wrote:> Hi Mike,>> I've already pushed r276981 and r276988 to fix those failures

Re: r276977 - [OpenMP] Codegen for use_device_ptr clause.

2016-07-28 Thread Samuel F Antao via cfe-commits
Hi Mike,   I've already pushed r276981 and r276988 to fix those failures shortly after I pushed the patch. After that I didn't receive any bot message complaining about that code.    Do you still see the issues?   Thanks, Samuel   - Original message -From: Mike Aizatsky To: Samuel F Antao/W

Re: r276979 - [OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.

2016-07-28 Thread Samuel F Antao via cfe-commits
Hi Hans,   I think it should. All the stuff that enables this fix seems to be in 3.9 already.   Thanks! Samuel     - Original message -From: Hans Wennborg Sent by: hwennb...@google.comTo: Samuel F Antao/Watson/IBM@IBMUS, "Bataev, Alexey" Cc: cfe-commits Subject: Re: r276979 - [OpenMP][CUDA]

Re: r275931 - Append clang system include path for offloading tool chains.

2016-07-19 Thread Samuel F Antao via cfe-commits
Hi Richard,   I posted https://reviews.llvm.org/D22518, is this more or less what you intended?   Thanks, Samuel   - Original message -From: Richard Smith Sent by: meta...@gmail.comTo: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r275931 - Append clang system include path for

Re: r275645 - [CUDA][OpenMP] Create generic offload action

2016-07-18 Thread Samuel F Antao via cfe-commits
Fixed in r275931.   Thanks! Samuel   - Original message -From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUSCc: Richard Smith , Justin Lebar , cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create generic offload actionDate: Mon, Jul 18, 2016 7:38 PM      On Mon, Jul 18, 2016 at 4:2

Re: r275645 - [CUDA][OpenMP] Create generic offload action

2016-07-18 Thread Samuel F Antao via cfe-commits
Art, Richard,   I posted https://reviews.llvm.org/D22490. Let me know if that is what you have in mind.   Thanks! Samuel   - Original message -From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUSCc: Richard Smith , Justin Lebar , cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create

Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clause SEMA.

2016-07-18 Thread Samuel F Antao via cfe-commits
Hi Richard,   Thanks for catching that! Fixed in r275930.   Thanks again, Samuel   - Original message -From: Richard Smith Sent by: meta...@gmail.comTo: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clau

Re: r275645 - [CUDA][OpenMP] Create generic offload action

2016-07-15 Thread Samuel F Antao via cfe-commits
I'm looking into it. Thanks for letting me know.   Samuel   - Original message -From: Kostya Serebryany To: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create generic offload actionDate: Fri, Jul 15, 2016 7:37 PM  Our windows bot is unhappy:  http://

Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

2016-02-08 Thread Samuel F Antao via cfe-commits
No worries, sure, I'll do that. Thanks! Samuel From: Renato Golin To: Samuel F Antao/Watson/IBM@IBMUS Cc: Clang Commits Date: 02/08/2016 09:57 AM Subject:Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for differe

Re: r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

2016-02-07 Thread Samuel F Antao via cfe-commits
Hi Renato, This is not related with my patch, I'm afraid your buildbot won't go green with the revert. This looks to be related with r259976. My patch triggered the problem because it touched a CmakeList.txt. The code itself is completely unrelated with the failure. Dmitri Gribenko sent a follow

RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-06 Thread Samuel F Antao via cfe-commits
..@lists.llvm.org] On Behalf Of Samuel F Antao via cfe-commits Sent: Tuesday, January 5, 2016 10:57 AM To: Artem Belevich Cc: cfe-commits Subject: Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata. Hi Art, That only fixed one of the problems. The other one I am having some

RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Samuel F Antao via cfe-commits
fe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Samuel F Antao via cfe-commits Sent: Tuesday, January 5, 2016 10:57 AM To: Artem Belevich Cc: cfe-commits Subject: Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata. Hi Art, That only fixed one of th

Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.

2016-01-05 Thread Samuel F Antao via cfe-commits
Hi Art, That only fixed one of the problems. The other one I am having some trouble to replicate. I am trying a few things and hopefully will get a fix soon. Sorry for the trouble, Samuel From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUS Cc: cfe-commits Date: 01/05/2016 0

Re: r247494 - Always_inline codegen rewrite.

2015-09-14 Thread Samuel F Antao via cfe-commits
Hi Evgeniy, I commit a small change to one of the regression tests to allow a signext to be generated: http://reviews.llvm.org/rL247584. It was causing an error in Power8 targets. In my view is an harmless change but you may want to take a look and see if that is fine by you. Thanks! Samuel 201