[clang] Revert "[clang][dataflow] Expose simple access to child StorageLocation presence." (PR #145710)

2025-06-25 Thread Samira Bakon via cfe-commits
https://github.com/bazuzi created https://github.com/llvm/llvm-project/pull/145710 Reverts llvm/llvm-project#145520 Exposed function is no longer needed and side-stepped the intended contract that the present children are the same set returned by `getModeledFields()` and presence shouldn't ne

[clang] Revert "[clang][dataflow] Expose simple access to child StorageLocation presence." (PR #145710)

2025-06-25 Thread Samira Bakon via cfe-commits
https://github.com/bazuzi closed https://github.com/llvm/llvm-project/pull/145710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][dataflow] Expose simple access to child StorageLocation presence." (PR #145710)

2025-06-25 Thread Samira Bakon via cfe-commits
bazuzi wrote: This reverts a simple change added <24 hours ago and reverting has been discussed directly with original change reviewers. Merging without additional review. https://github.com/llvm/llvm-project/pull/145710 ___ cfe-commits mailing list

[clang] [clang][dataflow] Expose simple access to child StorageLocation presence. (PR #145520)

2025-06-25 Thread Samira Bakon via cfe-commits
bazuzi wrote: No underlying bug, but I was able to simplify my approach out-of-tree and avoid exposing this function that doesn't capture the intended semantics. I'll revert this. https://github.com/llvm/llvm-project/pull/145520 ___ cfe-commits maili

[clang] [clang][dataflow] Expose simple access to child StorageLocation presence. (PR #145520)

2025-06-24 Thread Samira Bakon via cfe-commits
https://github.com/bazuzi closed https://github.com/llvm/llvm-project/pull/145520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Expose simple access to child StorageLocation presence. (PR #145520)

2025-06-24 Thread Samira Bakon via cfe-commits
https://github.com/bazuzi created https://github.com/llvm/llvm-project/pull/145520 `getChild` does not offer this knowledge, and a map lookup is significantly cheaper than iteration over `children()`. >From 9b8f866a5102dbe23b671760bf35549b30a30a74 Mon Sep 17 00:00:00 2001 From: Samira Bakon D