[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me with any extra tests required by David's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ ht

[PATCH] D147197: [llvm-docs] Added documentation for the 'neg' operation

samtebbs added a comment. Since the instruction's don't exist now, would you mind abandoning this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147197/new/ https://reviews.llvm.org/D147197 ___

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. This looks good to me now, nice work. Let's wait a few days for others' input to be safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1479

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5041 case DeclSpec::TST_enum: return 4; default: ipriyanshi1708 wrote: > jrtc27 wrote: > > Why not just always pass the full DeclSpec and handle the class case here, > > maybe wit

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5051 +return 5; + else +return 4; Instead of returning 4 here, I think it's best to just delegate to the other `GetDiagnosticTypeSpecifierID` function. That way, if the

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added a comment. Thanks for the input Aaron and Martin. This is looking good. With the suggested changes (don't forget the test, you could try adding one to clang/test/Sema/attr-declspec-ignored.c and clang/test/SemaCXX/attr-declspec-ignored.cpp) and some formatting

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added reviewers: mboehme, aaron.ballman. samtebbs added a comment. Looping in some people who have worked on and reviewed patches in this area for some experienced eyes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/ https://re

[PATCH] D147989: [clang] Fix Attribute Placement

samtebbs added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:58 using namespace sema; - +bool isEnumClass = false; Sema::DeclGroupPtrTy Sema::ConvertDeclToDeclGroup(Decl *Ptr, Decl *OwnedType) { This being global could lead to issues where one overwr

[PATCH] D146892: [documentation] Fix some typos

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc8237d9d727: [documentation] Fix some typos (authored by ayushi-8102, committed by samtebbs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ htt

[PATCH] D147197: [llvm-docs] Added documentation for the 'neg' operation

samtebbs added a comment. Thank you oyalesalami. It looks like these instructions don't actually exist anymore so shouldn't be documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147197/new/ https://reviews.llvm.org/D147197

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

samtebbs added a comment. Thank you Samuel. Since you don't have commit access, I can commit this for you if you'd like. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146370/new/ https://reviews.llvm.org/D146370 ___ cfe-commits mailing list

[PATCH] D146892: [documentation]Fixed Random Typo

samtebbs added a comment. Thank you Ayushi. Since you don't have commit access yet, I can commit it for you if you'd like. I do wonder if we should change the commit title to be something like "[documentation] Fix some typos". What do you think? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D146644: [documentation]Fixed Random Typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG4071dcf3549f: [documentation] Fix Typos (authored by ipriyanshi1708, committed by samtebbs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https

[PATCH] D146644: [documentation]Fixed Random Typos

samtebbs added a comment. I was about to commit it for you but think that "Random" should be removed from the title, are you OK with that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644

[PATCH] D146644: [documentation]Fixed Random Typos

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. Thank you for this, it looks like it fixes all of the typos reported in the issue. If you don't have commit access yet I can commit this with you as the author. Repository: rG LLVM Git

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

samtebbs added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1669-1672 +if (CodeGenOpts.StackProbeSize != 4096) + B.addAttribute("stack-probe-size", + llvm::utostr(Cod

[PATCH] D127812: [AArch64] Function multiversioning support added.

samtebbs added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11483 +def warn_target_clone_no_impact_options +: Warning<"version list contains no code impact entries">, + InGroup; ilinpv wrote: > erichkeane wrote: > > I'm n