[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

2019-01-23 Thread Roman Zhikharevich via Phabricator via cfe-commits
rzhikharevich added a comment. In D57111#1368256 , @riccibruno wrote: > I guess you will want someone to commit it ? Yes, if the fix is correct. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57111/new/ https://reviews.l

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

2019-01-23 Thread Roman Zhikharevich via Phabricator via cfe-commits
rzhikharevich added a comment. In D57111#1368224 , @riccibruno wrote: > Upload patches with full context please. > Also the diagnostic seems to be wrong ? I don't think so, the valid code would be 'p->~C()'. > And finally is there a bug report for this

[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

2019-01-23 Thread Roman Zhikharevich via Phabricator via cfe-commits
rzhikharevich created this revision. rzhikharevich added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes handling of code like this: c++ struct Foo; void foo(Foo *p) { p.~Foo(); } Repository: rC Clang https://reviews.llvm.org/D57111 Files: clang/l