[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

rafauler added a comment. BOLT modifications LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119351/new/ https://reviews.llvm.org/D119351 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a comment. I definitely understand how the diagnostic can be confusing. However, it's the same diagnostic gcc provides too, so gcc users wouldn't be surprised. But you're right this can be improved by at least mentioning the attribute used in the diagnostic message. There's no bu

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a comment. I'm not an expert in swift either. I'll wait for @davezarzycki input on what's happening, but I suspect the code base is indeed incompatible with gcc due to the nature of the error they experienced. This testcase is creduce-d from what I observed in swift. Repositor

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler added a subscriber: davezarzycki. rafauler added a comment. Both approaches make sense to me. I'll re-land the previous patch in favor of gcc compatibility, since the semantics of attribute used in member functions of class templates were first implemented in gcc. @davezarzycki Heads

[PATCH] D58216: Support attribute used in member funcs of class templates II

rafauler created this revision. rafauler added reviewers: rsmith, ldionne, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: clang. As PR17480 describes, clang does not support the used attribute for member functions of class templates. This means that if the member func

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler added a comment. Hi davezarzycki, thanks for reporting this! This is not expected, I'll revert this diff for now. Sorry for this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 ___

[PATCH] D56928: Support attribute used in member funcs of class templates

This revision was automatically updated to reflect the committed changes. Closed by commit rC352740: Support attribute used in member funcs of class templates (authored by rafauler, committed by ). Changed prior to commit: https://reviews.llvm.org/D56928?vs=184467&id=184470#toc Repository: r

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 184467. rafauler added a comment. Thanks for reviewing! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp test/CodeGenCXX/attr-used-

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 184029. rafauler added a comment. Rebase + Aaron's suggestions. Thanks for the suggestions! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateD

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 183657. rafauler added a comment. No problem, thanks for your suggestions! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp test/Co

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 182581. rafauler added a comment. Removing facebook tags Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp test/CodeGenCXX/attr-used

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler created this revision. rafauler added reviewers: rsmith, ldionne. As PR17480 describes, clang does not support the used attribute for member functions of class templates. This means that if the member function is not used, its definition is never instantiated. This patch changes clang to