This revision was automatically updated to reflect the committed changes.
Closed by commit rL313675: [OpenMP] fix seg-faults printing diagnostics with
invalid ordered(n) values (authored by rcraik).
Changed prior to commit:
https://reviews.llvm.org/D38049?vs=115876&id=115901#toc
Repository:
Author: rcraik
Date: Tue Sep 19 14:04:23 2017
New Revision: 313675
URL: http://llvm.org/viewvc/llvm-project?rev=313675&view=rev
Log:
[OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values
When the value specified for n in ordered(n) is larger than the number of loops
a segme
rcraik created this revision.
When the value specified for //n// in ordered(//n//) is larger than the number
of loops a segmentation fault can occur in one of two ways when attempting to
print out a diagnostic for an associated depend(sink : //vec//):
1. The iteration vector //vec// contains le
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308932: Remove addtional parameters in function std::next()
and std::prev() (authored by rcraik).
Changed prior to commit:
https://reviews.llvm.org/D34649?vs=104030&id=107977#toc
Repository:
rL LLVM
Author: rcraik
Date: Mon Jul 24 15:17:05 2017
New Revision: 308932
URL: http://llvm.org/viewvc/llvm-project?rev=308932&view=rev
Log:
Remove addtional parameters in function std::next() and std::prev()
Creating a function pointer with proper parameters pointing to std::next() or
std::prev() shoul
field (ignoring the special case of MS in C mode) would be
to use getIntWidth in C mode, and getTypeSize in C++ mode.
I would be happy create a patch to make this change tomorrow if people are
in agreement.
Rachel
From: Nico Weber
To: Richard Smith
Cc: Rachel Craik/Toronto/IBM@IBMCA
Author: rcraik
Date: Mon Sep 14 16:27:36 2015
New Revision: 247618
URL: http://llvm.org/viewvc/llvm-project?rev=247618&view=rev
Log:
C11 _Bool bitfield diagnostic
Summary: Implement DR262 (for C). This patch will mainly affect bitfields of
type _Bool
Reviewers: fraggamuffin, rsmith
Subscribers
Author: rcraik
Date: Mon Sep 14 09:08:18 2015
New Revision: 247560
URL: http://llvm.org/viewvc/llvm-project?rev=247560&view=rev
Log:
Test commit
Remove some trailing whitespace
Modified:
cfe/trunk/lib/Basic/Builtins.cpp
Modified: cfe/trunk/lib/Basic/Builtins.cpp
URL:
http://llvm.org/viewvc
rcraik marked 3 inline comments as done.
rcraik added a comment.
http://reviews.llvm.org/D10018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rcraik updated the summary for this revision.
rcraik updated this revision to Diff 34571.
rcraik added a comment.
switched to using getIntWidth instead of getTypeSize and updated the error and
warning messages accordingly, as have the necessary test cases. The separate
check for _Bool bitfields
rcraik added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12586
@@ -12585,3 +12585,3 @@
if (!FieldTy->isDependentType()) {
uint64_t TypeSize = Context.getTypeSize(FieldTy);
if (Value.getZExtValue() > TypeSize) {
hubert.reinterpretcast wrote:
> r
rcraik updated this revision to Diff 34339.
rcraik added a comment.
I've updated the message to make it a bit clearer that this is a portability
concern. Are there any further concerns with this patch?
http://reviews.llvm.org/D10018
Files:
include/clang/Basic/DiagnosticGroups.td
include/cl
rcraik added a comment.
Ping 3!
http://reviews.llvm.org/D11582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rcraik added a comment.
ping 2!
http://reviews.llvm.org/D11582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rcraik marked 2 inline comments as done.
rcraik added a comment.
http://reviews.llvm.org/D10018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rcraik added a comment.
ping!
http://reviews.llvm.org/D11582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
16 matches
Mail list logo
