[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

2021-03-01 Thread PremAnand Rao via Phabricator via cfe-commits
pmrao marked an inline comment as not done. pmrao added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: erichkeane wrote: > pmr

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

2021-03-01 Thread PremAnand Rao via Phabricator via cfe-commits
pmrao added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: erichkeane wrote: > Tabs here instead of spaces. > > I think this

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

2021-02-26 Thread PremAnand Rao via Phabricator via cfe-commits
pmrao created this revision. pmrao added reviewers: ABataev, bader, erichkeane, jdoerfert. Herald added subscribers: guansong, yaxunl. pmrao requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Ensure that we are in a function declaration context b