[PATCH] D33531: Clang-tidy readability: avoid const value return

PiotrZSL abandoned this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. Obsolete, this check is already added. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33531/new/ https://reviews.llvm.org/D33531

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D158657: [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158657/new/ https://reviews.llvm.org/D158657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e55fef0e98f: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression (authored by njames93, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGd867f668672d: [clang-tidy] modernize-avoid-bind: Fix handling of operators (authored by jspam, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

PiotrZSL updated this revision to Diff 558075. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101617 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp c

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101617 __

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D126780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119165/new/ https://reviews.llvm.org/D119165

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D157326 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115106/new/ https://reviews.llvm.org/D115106

[PATCH] D130639: [clang-tidy] Fix readability-redundant-string-c-str fix for overloaded operator->

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D145730 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130639/new/ https://reviews.llvm.org/D130639

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

PiotrZSL added a comment. This change is dangerous, it depends that elements/iterators won't be re-allocated/invalidated during insertion process. Part with removing double lookup in IncludeSorter::addInclude looks fine, but part that involve IncludeBucket is problematic. I will try to push part

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

PiotrZSL updated this revision to Diff 558074. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125949/new/ https://reviews.llvm.org/D125949 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-t

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a reviewer: njames93. Crash no longer happens on main, but this change introduce nice fix for operators handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a73da4c85a1: [clang-tidy] Add support for optional parameters in config. (authored by felix642, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D159436?vs=557546&id=557652#toc

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL closed this revision. PiotrZSL added a comment. Obsolete. No longer needed after D159436 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159045/new/ https://reviews.llvm.org/D159045 ___

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6780d53f41fb: [clang-tidy] Warn about arrays in bugprone-undefined-memory-manipulation (authored by fwolff, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D127036?vs=434283&i

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, I will rebase, push it and add release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127036/new/ https://reviews.llvm.org/D127036 ___

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Except few nits in documentation looks fine. Probably one day in future we can add same for bools. Make sure that documentation of impacted checks is correct, so it says that argument is p

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

PiotrZSL closed this revision. PiotrZSL added a comment. Commited in f2e5000937235aa35a9ee4423045b265c2c79e85 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158371/new/ https://reviews.llvm.org/D158371 __

[PATCH] D158928: [clang-tidy] Add IgnoreTypes option to modernize-use-nullptr

PiotrZSL closed this revision. PiotrZSL added a comment. Commited in 01c11569fc67b2a00403f64695fff6d2b4e78fe5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158928/new/ https://reviews.llvm.org/D158928 __

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

PiotrZSL added a comment. In D158371#4640664 , @loskutov wrote: > However, I don't have push access to the repo, so could you commit the change? Name / Email (to be used as author) ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D159436: [clang-tidy] Add support for optional parameters in config.

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:196-198 +if (Value == "" || Value == "none" || Value == "null" || + Value == "false" || (std::is_unsigned_v && Value == "-1")) + return std::nullopt; --

[PATCH] D158486: [clang-tidy] Ignore used special-members in modernize-use-equals-delete

This revision was automatically updated to reflect the committed changes. Closed by commit rG208fa9acc0ff: [clang-tidy] Ignore used special-members in modernize-use-equals-delete (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158486?vs=552217&id=555635#toc Repositor

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG4294bca5e4f6: [clang-tidy] Add exit code support to clang-tidy-diff.py (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ htt

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGefebb4e0fabe: [clang-tidy] readability-container-size-empty handle std::string length() (authored by PiotrZSL). Changed p

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL added a comment. In D159045#4631820 , @felix642 wrote: > In that case, I agree with you, it would be helpful to add this feature. I > think supporting an empty value rather than a boolean is preferable. We > should maybe do that in another Diff

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL added a comment. In D159045#4631650 , @felix642 wrote: > We can already disable those options if we don't define them in the config. > Adding the possibility to provide optional values seems redundant to me. Do > you see any reason why we would

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

PiotrZSL added a comment. From a mine perspective when it comes to clang-tidy: - I personally do not care about Objective-C specific matchers - I do not plan to use them. - I personally avoid using "Type" based matchers if I can (due to mess with elaborated/wrapped types), it's easier to create

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Change is ok. Interesting thing is that we got more of such issues in many checks. I'm thinking, maybe support for optional fields is needed, fields that can accept integer or false/no val

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

PiotrZSL updated this revision to Diff 554028. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Fix some Pylint issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929 Files: clang-t

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e2a5e260c2: [clang-tidy][readability] add Leading_upper_snake_case (authored by MasterCopy8GB, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158787?vs=553593&id=554022#toc

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6207f6e0d04: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

PiotrZSL added a comment. In D156616#4621975 , @mikecrowe wrote: > The removal of `c_str()` happens even without StrictMode set to True. I still think we will be fine. There are not many situations when arguments need to be reorder. And most probably no

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. In D156616#4621914 , @mikecrowe wrote: > @PiotrZSL, I think that this is quite an important fix since without it the > check completely mangles th

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added a comment. In D158787#4621587 , @MasterCopy8GB wrote: > Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could > you please commit these changes for me? Thank you for all of your time and > effort! Under which use

[PATCH] D158959: [clang-tidy] Disambiguate calls to log

PiotrZSL added a comment. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158959/new/ https://reviews.llvm.org/D158959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Modify script to fail

[PATCH] D158928: [clang-tidy] Add IgnoreTypes option to modernize-use-nullptr

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang-tools-extra. New option add

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks to be fine, but I didn't get too deep into AST matchers. I assume that tests cover them. Please wait like 2 weeks before pushing this, so someone else could be able to verify

[PATCH] D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator

This revision was automatically updated to reflect the committed changes. Closed by commit rGffad4f8fcac5: [clang-tidy] Container-size-empty fixed c++ version in tests to support… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM. Nothing fancy, looks straight forward. You may want to wait for an Aaron Ballman opinion. Comment at: clang/docs/LibASTMatchersReference.html:2454 +Matcher

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. After you update release notes entry, it could land... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:240-245 ` check to emit proper warnings when a type forward declaration precedes its definition. +- Improved :doc:`readability-identifier-naming + ` allow for + ``Leading_upper_snake_cas

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

This revision was automatically updated to reflect the committed changes. Closed by commit rG41818ce150fd: [clang-tidy] Access checks not done classes derived of std::array (authored by sousajo, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

PiotrZSL added a comment. Upload full path to avoid "Context not available." Comment at: clang-tools-extra/docs/ReleaseNotes.rst:256 +- Improved :doc:`readability-identifier-naming + ` Leading_upper_snake_case -> put this entry in alphabetical order =

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added a comment. And add reference to issue in commit description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:116-118 +- Improved :doc:`readability-identifier-naming + ` check to allow for + Leading_upper_snake_case naming convention. Wrong section, add it under "Changes in existing che

[PATCH] D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158691/new/ https://reviews.llvm.org/D158691 ___

[PATCH] D158787: llvm-project/issues/42451

PiotrZSL added a comment. - Missing documentation entry about this style. - Missing release notes entry - Commit title / description should be more in line with style used in project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https:/

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2c5cda3cc7: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I'm pushing this in current state, if you want to change something after that, fell free to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158665/new/ https://reviews.llvm.

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:20 + Finder->addMatcher( + functionDecl(unless(parameterCountIs(0)), hasBody(coroutineBodyStmt())) + .bind("fnt"), ---

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: ChuanqiXu, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

PiotrZSL added a comment. I don't know how, but somehow this change breaks clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 __

[PATCH] D158657: [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables

PiotrZSL created this revision. PiotrZSL added reviewers: alexfh, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Ignore false-

[PATCH] D158534: [clang-tidy] Disable trivially-destructible check for darwin

PiotrZSL added a comment. 626849c71e85d546a004cc91866beab610222194 didn't fix this issue already ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158534/new/ https://reviews.llv

[PATCH] D158480: [clang-tidy][readability-braces-around-statements] ignore false-positive for constexpr if statement in lambda expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158480/new/ https://reviews.llvm.org/D158480 ___

[PATCH] D158486: [clang-tidy] Ignore used special-members in modernize-use-equals-delete

PiotrZSL created this revision. PiotrZSL added reviewers: malcolm.parsons, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Spec

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.cpp:29 + +bool isPotentialSymmetricBinaryOperator(OverloadedOperatorKind Kind) { + return llvm::is_contained( again, I would probably try to

[PATCH] D158346: [clang-tidy] readability-container-size-empty - detect missing usage of .empty() on string_literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG4001ae175cbe: [clang-tidy] readability-container-size-empty - detect missing usage of .empty… (authored by felix642, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158346?vs=

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7bdaff7cad9: [clang-tidy] Implement bugprone-incorrect-enable-if (authored by ccotter, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157239?vs=549777&id=552077#toc Reposit

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

PiotrZSL added a comment. I'm pushing this, if you want to change anything else, just please open new review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 _

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

PiotrZSL added a comment. For me check is fine and bring some value. But for me auto-fixes in this check aren't needed, this simply complicate a check that could be very simple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://rev

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, but note that type aliases may not work properly, but that more a legacy issue that got source in line 104, simply because we should use canonical type there. Com

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, run clang-format on this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158346/new/ https://reviews.llvm.org/D158346

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

PiotrZSL added a comment. Yes doing some basic calculations would be probably the best, but for that we would need to implement some "calculator" or find some exist implementation some're in clang. Even if it would support only basic operations like * Repository: rG LLVM Github Monorepo CHA

[PATCH] D158346: [clang-tidy] [readability-container-size-empty] improved check to detect missing usage of .empty() on string_literals Fixes #64547

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. - Release notes entry is missing. - Commit/Change description should be updated Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cp

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL abandoned this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. I do not plan to work on this check anymore, sorry for a wasted time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/ https://reviews.l

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL abandoned this revision. PiotrZSL added a comment. I do not plan to work on this check anymore, sorry for a wasted time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 __

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

PiotrZSL added a comment. In short I'm against simply ignoring literal calculations because this check is only thing that currently detect this issue: https://github.com/llvm/llvm-project/issues/64828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL planned changes to this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. TODO: Resolve rest of review comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:14 void ExceptionAnalyzer::ExceptionInfo::registerExcepti

[PATCH] D158338: [clang-tidy] [bugprone-implicit-widening-of-multiplication-result] Improved check to ignore false positives with integer literals.

PiotrZSL added a comment. I'm not sure if this is right fix, example: const std::size_t k1Tb = 1024 * 1024 * 1024 * 1024; This is detected by -Winteger-overflow, but this: const std::size_t k1Pb = 1024U * 1024U * 1024U * 1024U * 1024U; is not detect by anything except this check, even th

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 551776. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Add throw_basefn_catch_const_basefn test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL marked 2 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:306 + + if (From->isMemberPointerType() || To->isMemberPointerType()) return false; isuckatcs wrote: > is

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:230 +- Improved :doc:`readability-non-const-parameter.cpp + ` check to ignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL updated this revision to Diff 551761. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153298/new/ https://reviews.llvm.org/D153298 Files: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.c

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 551760. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp c

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL updated this revision to Diff 551758. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

PiotrZSL updated this revision to Diff 551757. PiotrZSL added a comment. Rebase + Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56644/new/ https://reviews.llvm.org/D56644 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyChe

[PATCH] D158244: [clang-tidy]`pro-bounds-array-to-pointer-decay` ignore predefined expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158244/new/ https://reviews.llvm.org/D158244 ___

[PATCH] D158157: [clang-tidy] Disable implicit search for a compilation db in some tests

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158157/new/ https://reviews.llvm.org/D158157 ___

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rGa94c44cc0a56: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D157326: [clang-tidy] Fix handling of out-of-line functions in readability-static-accessed-through-instance

This revision was automatically updated to reflect the committed changes. Closed by commit rG766dd7b80b57: [clang-tidy] Fix handling of out-of-line functions in readability-static… (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157326?vs=548066&id=550200#toc Reposit

[PATCH] D157374: [clang-tidy] Ignore decltype in misc-redundant-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7d28f72e19: [clang-tidy] Ignore decltype in misc-redundant-expression (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D157374?vs=548104&id=550201#toc Repository: rG LLVM G

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/bugprone/LambdaFunctionNameCheck.cpp:91-93 +if (IgnoreMacros) { + return; +} Repository:

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

PiotrZSL added a comment. I agree that this change is an improvement that is welcome, but that's not a fix for a #60217. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157869/new/ https://reviews.llvm.org/D157869 __

[PATCH] D157869: [clang-tidy] Avoid overflow when dumping unsigned integer values

PiotrZSL added a comment. This wont fix issue, simply because problem happen during reading -1, not during dumping, and per documentation -1 was a valid value. Same issue happen in other checks that use -1. Most probably best way would be to change those variables into std::int64_t, in C++ crea

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM (+-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 __

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Missing storeOptions metod, everyting else looks +- fine. Comment at: clang-tools-extra/clang-tidy/bugprone/LambdaFunctionNameCheck.cpp:81 Result.Sourc

[PATCH] D157773: [clang-tidy] fix None tmpdir when exporting fixes in run-clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3da99275a52: [clang-tidy] fix None tmpdir when exporting fixes in run-clang-tidy (authored by 5chmidti, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D157773: [clang-tidy] fix None tmpdir when exporting fixes in run-clang-tidy

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157773/new/ https://reviews.llvm.org/D157773 ___

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a66de37fc0: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd44f80a5a8: [clang-tidy] Fix crash when diagnostic is emit with invalid location (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1576

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL added a comment. In D157702#4580310 , @steakhal wrote: > Do we have other typos like this? I don't think so, only mess in overall documentation: https://github.com/llvm/llvm-project/issues/64614 I updated gen-static-analyzer-docs.py, and it sho

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL updated this revision to Diff 549336. PiotrZSL added a comment. Micro fix ("" characters). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157702/new/ https://reviews.llvm.org/D157702 Files: clang/docs/analyzer/checkers.rst Index: clang

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang. Herald

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

This revision was automatically updated to reflect the committed changes. Closed by commit rGa563ced78bb4: [clang-tidy] Implement cppcoreguidelines CP.52 (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1570

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

PiotrZSL updated this revision to Diff 549263. PiotrZSL added a comment. Add call to DiagnosticEngine::hasSourceManager() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157649/new/ https://reviews.llvm.org/D157649 Files: clang-tools-extra/clang-t

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fix cr

  1   2   3   4   5   6   7   8   9   >