[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

philipp.tomsich added a comment. Should we move this to a GitHub PR instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159480/new/ https://reviews.llvm.org/D159480 ___ cfe-commits mailing list cfe-co

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich abandoned this revision. philipp.tomsich added a comment. I just saw that the last response was "unsubmitted". Submitting and abandoning this revision (based on the discussion and the previously unsubmitted comment from my end). Comment at: llvm/include/llvm/T

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich marked 4 inline comments as done. philipp.tomsich added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315 + if (Subtarget.hasVendorXTHeadBb()) { +setOperationAction({ISD::CTLZ}, XLenVT, Legal); + inclyc wrote: > It

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich reopened this revision. philipp.tomsich added a comment. Reopening as this was accidentially pushed and reverted when doing 'arc patch on D143534 '. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } craig.topper wrote: > without these two lines to

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich added a comment. Thanks for spotting this. Fixed in our local git-tree as well, so it doesn't sneak back in during the merge. I am blind to the difference between Ba, Bb, and Bs by now -- with Ba and Bs being too close to each other on the keyboard for comfort!. Repository:

[PATCH] D142396: [AArch64] Add the Ampere1A core

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0af89193a9: [AArch64] Add the Ampere1A core (authored by philipp.tomsich). Changed prior to commit: https://reviews.llvm.org/D142396?vs=491840&i

[PATCH] D142439: Fix C++11 warnings in RangeSetTest.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25b03ae78ff3: Fix C++11 warnings in RangeSetTest.cpp (authored by philipp.tomsich). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich updated this revision to Diff 491840. philipp.tomsich added a comment. - untabify on some tabs that slipped in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142396/new/ https://reviews.llvm.org/D142396 Files: clang/test/Misc/targ

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich added inline comments. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:492 +{"ampere1a", ARMV8_6A, + (AArch64::AEK_FP16 | AArch64::AEK_RAND | AArch64::AEK_SM4 | + AArch64::AEK_SHA3 | AArch64::AEK_SHA2 | AArch64::AEK_AES |

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich updated this revision to Diff 491738. philipp.tomsich added a comment. - Split off new (Ampere1A-specific) fusion case - Updated the Ampere1A SubtargetFeature list to include (hopefully) all features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich added a comment. When looking at "ARM DDI 0487G.a", on page A2-68 under the heading "Additional functionality added to Armv8.0 in later releases" in the definition-list item "FEAT_SSBS, Speculative Store Bypass Safe": > This feature is OPTIONAL in Armv8.0 implementations and man

[PATCH] D142439: Fix C++11 warnings in RangeSetTest.cpp

philipp.tomsich created this revision. Herald added a subscriber: steakhal. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes the following warnings: llvm/clang/unittests/St

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

philipp.tomsich created this revision. philipp.tomsich added a reviewer: dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich updated this revision to Diff 491499. philipp.tomsich added a comment. v2 changes: - fixes a whitespace issue - fixes a rebase artifact on Ampere1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142396/new/ https://reviews.llvm.org/D

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich created this revision. philipp.tomsich added a reviewer: dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 426622. philipp.tomsich marked 4 inline comments as done. philipp.tomsich added a comment. Rebased to main. The earlier base-regression was a precommitted test-case that caused SimpleLoopUnswitch tests (not related to these changes) to fail. Reposit

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 426541. philipp.tomsich added a comment. Adds two fixes for issues uncovered by the CI: - The update of NumAArch64CPUArchs had been lost in a "rebase gone wrong" (i.e., another target was added and the previously increased-by-1 value now was the alr

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 425726. philipp.tomsich added a comment. - additional tab -> space conversion (hopefully, I have emacs configured correctly now) - added SBSS and MTE to the SubtargetFeatures - inserted AMpere1 in the subtarget enum in alphabetical order Repository:

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 425609. philipp.tomsich added a comment. Herald added a project: All. Update to reflect review results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117112/new/ https://reviews.llvm.org/D117112 Files:

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich created this revision. philipp.tomsich added reviewers: kristof.beyls, jgreenhalgh. Herald added a subscriber: hiraditya. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add support for the