[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

Prabhuk updated this revision to Diff 558152. Prabhuk added a comment. Rebased the patchset and addressed the compilation and test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105909/new/ https://reviews.llvm.org/D105909 Files: llvm/in

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

Prabhuk updated this revision to Diff 558151. Prabhuk added a comment. Rebased the patchset and addressed the compilation failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105907/new/ https://reviews.llvm.org/D105907 Files: llvm/include/llv

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

Prabhuk commandeered this revision. Prabhuk added a reviewer: necipfazil. Prabhuk added a comment. Herald added a project: All. https://discourse.llvm.org/t/rfc-computing-storing-and-restoring-conservative-call-graphs-with-llvm/58446/3?u=prabhuk Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

Prabhuk commandeered this revision. Prabhuk added a reviewer: necipfazil. Prabhuk added a comment. Herald added a project: All. https://discourse.llvm.org/t/rfc-computing-storing-and-restoring-conservative-call-graphs-with-llvm/58446/3?u=prabhuk Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. There is a check already, but it's not enough: https://github.com/llvm/llvm-project/issues/52683 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

MaskRay added a comment. In D138846#4657246 , @hans wrote: >> I just saw @glandium's earlier comment: >> >>> Code built with older versions of LLVM (e.g. rust) and running with the >>> updated runtime crash at startup with this change. >> >> This is the

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) koops wrote: > ABataev wrote: > > What requires this new dependency? > When cmake uses -DBUILD_SHARED_LIBS=1 shared libraries are built instead of >

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops requested review of this revision. koops added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) ABataev wrote: > What requires this new dependency? When cmake uses -DBUILD_SHARED_LIBS=1 shared libraries ar

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) What requires this new dependency? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 __

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558146. koops added a comment. Adding libFrontendOpenMP.so as a dependent library when building libclangBasic.so. Shared libraries were not built and tested by default, hence build and failed when checking on ppc64le. CHANGES SINCE LAST ACTION https://revi

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. > I just saw @glandium's earlier comment: > >> Code built with older versions of LLVM (e.g. rust) and running with the >> updated runtime crash at startup with this change. > > This is the exact same issue we encountered. Because there is a profile > format change, it's exp

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM except the final nits. Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:48 +const FormatToken *BeginTok, const FormatToken *EndTok) const { + // I

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

dmgreen added a comment. I hadn't realized this came from someone at Arm. The performance results I had were overall roughly flat, with some improvements and regressions. I think there were still some people working through some fixes for some of the knock-on effects but with those nothing larg

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

craig.topper added a comment. After this patch, I'm seeing a lot of `invariant.gep` created by LICM. For example, in `LBM_performStreamCollide` in 470.lbm there are 65 of them. On RISC-V, these all get created in registers outside the loop and get spilled. Is ARM seeing anything like this or do

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. FWIW, it's the first time for as long as I remember that mixing LLVM versions causes a runtime crash (that looks like a null deref). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D1388

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657195 , @zequanwu wrote: > In D138846#4657194 , @alanphipps > wrote: > >> In D138846#4657193 , @zequanwu >> wrote: >> >>> In D1388

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657194 , @alanphipps wrote: > In D138846#4657193 , @zequanwu > wrote: > >> In D138846#4657175 , @hans wrote: >> >>> We're seeing cr

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4657193 , @zequanwu wrote: > In D138846#4657175 , @hans wrote: > >> We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to >> this commit. I think Zequan

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

zequanwu added a comment. In D138846#4657175 , @hans wrote: > We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to > this commit. I think Zequan is investigating: > https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 It

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4657152 , @glandium wrote: > In D138846#4656607 , @glandium > wrote: > >> Code built with older versions of LLVM (e.g. rust) and running with the >> updated runtime crash a

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. We're seeing crashes in `initializeValueProfRuntimeRecord` that bisects to this commit. I think Zequan is investigating: https://bugs.chromium.org/p/chromium/issues/detail?id=1503919 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. In D138846#4656607 , @glandium wrote: > Code built with older versions of LLVM (e.g. rust) and running with the > updated runtime crash at startup with this change. FWIW, neither followups fixed this issue. The crash happens in

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

jcranmer-intel added a comment. So while trying to review this patch, I've discovered there's an annoying incompatibility between C and C++ here, in that C and C++ specify different rules on how to choose between `_Float64`, `double`, and `long double` if all are `binary64` (C says `_Float64` >

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

zahiraam added a comment. Just starting to look at this. Don't we need a RN for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 ___ cfe-commits mailing li

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. FWIW, this appears to have broken some build bots: https://lab.llvm.org/buildbot/#/builders/121/builds/36635 -- can you revert and investigate (or fix-forward quickly)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D1

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 558134. BeMg added a comment. 1. reuse the find result 2. replace for loop with llvm::copy_if 3. use explicit std::vector declaration instead of auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

wangpc added a comment. In D70401#4657101 , @jrtc27 wrote: > In D70401#4657098 , @jrtc27 wrote: > >> GCC only ever defines __riscv_32e > > Hm, seems the comments about __riscv_32e were from months ago, ignore them i

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

jrtc27 added a comment. In D70401#4657098 , @jrtc27 wrote: > GCC only ever defines __riscv_32e Hm, seems the comments about __riscv_32e were from months ago, ignore them if they aren't correct or have become outdated... Repository: rG LLVM Github Mon

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

jrtc27 added a comment. GCC only ever defines __riscv_32e Comment at: clang/lib/Basic/Targets/RISCV.cpp:210 +if (Is64Bit) + Builder.defineMacro("__riscv_64e"); +else Ugh, these don't align with the normal pattern. __riscv_e already exists in the s

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

wangpc added a comment. @craig.topper Thanks! @asb Hi Alex, I'd like to get another approval from you. Are there any more concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 _

[PATCH] D151730: [RISCV] Support target attribute for function

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:229 +collectNonISAExtFeature(const std::vector &FeaturesVec, int XLen) { + auto I = llvm::find(FeaturesVec, "__RISCV_TargetAttrNeedOverride"); + auto FeatureNeedOveride = std::vector(FeaturesVec.

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

arichardson added a comment. In D135171#4657080 , @brad wrote: > You can close this. The submitted patch https://github.com/llvm/llvm-project/commit/23c47eba879769a29772c999be2991201c2fe399 was not the same since it omitted ppc64. So I guess this shoul

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. In D153701#4656920 , @Endill wrote: > @yronglin We are sorry it takes so much time to get feedback. Richard and > Hubert have little bandwidth for reviews. Others, including me, don't feel > qualified to provide good feedback.

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

pengfei added a comment. Reverse ping. Any progress or plan for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86855/new/ https://reviews.llvm.org/D86855 ___ cfe-commits mailing list cfe-commi

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

brad added a comment. You can close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb updated this revision to Diff 558132. jaredgrubb marked 3 inline comments as done. jaredgrubb added a comment. Update to address all the review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 Files: clang/docs/ClangForma

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb marked 7 inline comments as done. jaredgrubb added inline comments. Comment at: clang/lib/Format/ObjCPropertyAttributeOrderFixer.cpp:113 + + // Deduplicate the attributes. + Indices.erase(std::unique(Indices.begin(), Indices.end(), owenpan wrote: > j

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. In D150083#4656832 , @owenpan wrote: > Thank you for your patience! I appreciate the help :) I'm excited to get this in! > In D150083#4655528 , @owenpan wrote: > >> See also D153228 <

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

koute added a comment. Sorry for the comment spam, but could we please get this merged in finally? (: To people who hold the decision making power as to whether this is merged: are there still any blockers left, considering the consensus was to merge it? What's the hold up? Is there anything I

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

tahonermann added a comment. Apologies once again for the delayed response. I reviewed some today and will resume reviewing on Monday. In addition to the inline suggestions: `clang/docs/ReleaseNotes.rst` will need to be updated to reflect that the core language changes for P1467R9 have been im

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558120. koops added a comment. Moving the declaration and definition of checkFailClauseParameter to include/clang/Basic/OpenMPKinds.h & lib/Basic/OpenMPKinds.cpp respectively. 2 other minor changes suggested by Alexey. CHANGES SINCE LAST ACTION https://revi

[PATCH] D154396: [clang] Add support for SerenityOS

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:25 + +static bool getPIE(const ArgList &Args, const ToolChain &TC) { + if (Args.hasArg(options::OPT_static, options::OPT_shared, I've simplified `Gnu.cpp` a bit for handling diff

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2516 +extern bool checkFailParameter(OpenMPClauseKind FailParameter); +/// This represents 'fail' clause in the '#pragma omp atomic' No way for extern functions. Declare in includ

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

MaskRay added a comment. In D150930#4656909 , @brunodf wrote: > Hi, > > I found this review request and I just want to comment that I find it strange > that it was rejected. > > @MaskRay I understand that using a compile_commands.json configured for gcc

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558112. koops added a comment. 1. Added a check for the fail parameter before the instance of OMPFailClause is created in ActOnOpenMPFailClause. An error in fail parameter like `#pragma omp atomic compare fail(capture)` was creating a wrong instance of OMPFail

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

Endill added a comment. @yronglin We are sorry it takes so much time to get feedback. Richard and Hubert have little bandwidth for reviews. Others, including me, don't feel qualified to provide good feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

brunodf added a comment. Hi, I found this review request and I just want to comment that I find it strange that it was rejected. @MaskRay I understand that using a compile_commands.json configured for gcc with clang-based tools is not a supported use case, but still the clang driver was expli

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG71a7108ee91a: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions (authored by liaolucy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158824/new/

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158824/new/ https://reviews.llvm.org/D158824 ___

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656399 , @aeubanks wrote: > In D144006#4656383 , @dzhidzhoev > wrote: > >> In D144006#4656371 , @aeubanks >> wrote: >> >>> Is the

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

liaolucy updated this revision to Diff 558107. liaolucy added a comment. 1. use a custom parser to parse Register-Register load/store 2. Rebase Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158824/new/ https://reviews.llvm.org/D158824 File

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656728 , @jmorse wrote: > Hi, > > Just to note that we've been seeing LTO crashes as a result of > rG3b449bd46a11a > (now > reverted on trunk)

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

owenpan added a comment. BTW, it may be simpler and more efficient to use a set (e.g. `llvm::SmallSet`) for `Indices`, especially if we don't need/want to handle duplicate attributes that have a value. (See D150083#inline-1551778 .) CHANGES SIN

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

owenpan added a comment. Thank you for your patience! There are still a few comments not done from the previous round. In D150083#4655528 , @owenpan wrote: > See also D153228 . Would this patch have a similar performan

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 558099. codemzs added a comment. Hi @tahonermann, I've just pushed a new diff with tests for `va_arg` and `...`, ensuring promotion rules are intact. Also, I've made sure `getFloatingTypeOrder` returns `FRCR_Unordered` only when we're dealing with both ope

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

aaron.ballman accepted this revision. aaron.ballman added a comment. The changes look reasonable to me (@rsmith had a lot of comments, but I think you addressed them; it would be nice if he could confirm), but should definitely come with a release note. So LGTM modulo those nits and any last-mi

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. Yes, please. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-comm

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm updated this revision to Diff 558095. arsenm added a comment. Drop bitcode auto upgrade handling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141700/new/ https://reviews.llvm.org/D141700 Files: clang/lib/CodeGen/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/amdgpu-enqueue-ker

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm added inline comments. Comment at: llvm/lib/IR/CMakeLists.txt:84 Demangle + TransformUtils + This introduces a circular dependency between LLVMCore and TransformUtils. Options are: 1. Move appendToUsed into Module 2. Don't bother with bitcode compati

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa852869398af: [clang-format] Fix a bug in parsing function/variable names (authored by gedare, committed by owenpan). Changed prior to commit: https://reviews.llvm.org/D156370?vs=558061&id=558088#toc R

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. ping @dim @rsmith @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4656478 , @dblaikie wrote: > Fair enough - all seems a bit unfortunate to be pushing these attributes > through to places they don't technically apply to (both complicates the > implementation, and might be confusing

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 updated this revision to Diff 558086. eddyz87 marked 2 inline comments as done. eddyz87 added a comment. Rebase, fixes for review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143967/new/ https://reviews.llvm.org/D143967 Files:

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 558083. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Synced to the main and resolved merge conflicts, updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. From my perspective, this patch is ready to go! Please let me know if there's anything more I can do to improve the patch! (@owenpan thanks so much for your help so far!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D15

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

jmorse added subscribers: StephenTozer, jmorse. jmorse added a comment. Hi, Just to note that we've been seeing LTO crashes as a result of rG3b449bd46a11a (now reverted on trunk), which @StephenTozer has kindly reduced down t

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2554 + break; +case llvm::omp::OMPC_adjust_args: +case llvm::omp::OMPC_affinity: I think all these cases are unexpected and must be terminated with llvm_unreachable

[PATCH] D154774: [Sema] Respect instantiated-from template's VisibilityAttr for two implicit/explicit instantiation cases

MaskRay added inline comments. Comment at: clang/lib/AST/Decl.cpp:380 +->getTemplatedDecl() +->hasAttr(); } rjmccall wrote: > Okay, this change seems wrong. A visibi

[PATCH] D33531: Clang-tidy readability: avoid const value return

PiotrZSL abandoned this revision. PiotrZSL marked 4 inline comments as done. PiotrZSL added a comment. Obsolete, this check is already added. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33531/new/ https://reviews.llvm.org/D33531

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D158657: [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables

PiotrZSL added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158657/new/ https://reviews.llvm.org/D158657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e55fef0e98f: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression (authored by njames93, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGd867f668672d: [clang-tidy] modernize-avoid-bind: Fix handling of operators (authored by jspam, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558076. koops added a comment. Removing default from switch statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTV

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. In D138846#4656594 , @hans wrote: > Just a heads up that we're seeing crashes in the Rust compiler which bisects > to this change. Investigating in > https://bugs.chromium.org/p/chromium/issues/detail?id=1500558 Thank you fo

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:607 +// compiler has broken. +assert((!StartLoc || StartLoc->isValid()) && "Start location is not valid"); +assert((!EndLoc || EndLoc->isValid()) && "End location is not valid"); ---

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

PiotrZSL updated this revision to Diff 558075. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101617 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp c

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101617 __

[PATCH] D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D126780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119165/new/ https://reviews.llvm.org/D119165

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D157326 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115106/new/ https://reviews.llvm.org/D115106

[PATCH] D130639: [clang-tidy] Fix readability-redundant-string-c-str fix for overloaded operator->

PiotrZSL abandoned this revision. PiotrZSL added a comment. Already fixed by D145730 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130639/new/ https://reviews.llvm.org/D130639

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

PiotrZSL added a comment. This change is dangerous, it depends that elements/iterators won't be re-allocated/invalidated during insertion process. Part with removing double lookup in IncludeSorter::addInclude looks fine, but part that involve IncludeBucket is problematic. I will try to push part

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

PiotrZSL updated this revision to Diff 558074. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125949/new/ https://reviews.llvm.org/D125949 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-t

[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Herald added a reviewer: njames93. Crash no longer happens on main, but this change introduce nice fix for operators handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. In D138846#4656594 , @hans wrote: > Just a heads up that we're seeing crashes in the Rust compiler which bisects > to this change. Investigating in > https://bugs.chromium.org/p/chromium/issues/detail?id=1500558 Here's a small rep

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

glandium added a comment. Code built with older versions of LLVM (e.g. rust) and running with the updated runtime crash at startup with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846 __

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

hans added a comment. Just a heads up that we're seeing crashes in the Rust compiler which bisects to this change. Investigating in https://bugs.chromium.org/p/chromium/issues/detail?id=1500558 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:607 +// compiler has broken. +assert((!StartLoc || StartLoc->isValid()) && "Start location is not valid"); +assert((!EndLoc || EndLoc->isValid()) && "End location is not valid");

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. In D155529#4509686 , @MyDeveloperDay wrote: > We should never make assumptions about what people do/don't use > If you have this you ha

[PATCH] D156360: [clang-format] Support function and overloaded operator SpacesInParensOption

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3970-4009 if (Left.is(tok::l_paren) || Right.is(tok::r_paren)) { if (Right.is(TT_CastRParen) || (Left.MatchingParen && Left.MatchingParen->is(TT_CastRParen))) { return Style.Spa

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare marked an inline comment as done. gedare added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:773-792 if ((Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak || Style.AlignAfterOpenBracket == FormatStyle::BAS_BlockIndent) &&

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare updated this revision to Diff 558069. gedare added a comment. Use cameLCAse in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154755/new/ https://reviews.llvm.org/D154755 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unitte

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25814-25824 + " if (quitelongname < alsolongname ||\n" + " anotherevenlongername <=\n" + " thisreallyreallyreallyreallyreallyreallylongername

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:773-792 if ((Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak || Style.AlignAfterOpenBracket == FormatStyle::BAS_BlockIndent) && (Previous.isOneOf(tok::l_paren, TT_Te

  1   2   3   4   5   6   7   8   9   10   >