https://github.com/petr-polezhaev edited
https://github.com/llvm/llvm-project/pull/122606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petr-polezhaev edited
https://github.com/llvm/llvm-project/pull/122606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -830,6 +830,16 @@ bool OverlayCDB::setCompileCommand(PathRef File,
return true;
}
+std::unique_ptr
+OverlayCDB::getProjectModules(PathRef File) const {
+ auto MDB = DelegatingCDB::getProjectModules(File);
+ MDB->setCommandMangler([&Mangler = Mangler](tooling::CompileCom
petr-polezhaev wrote:
Didn't knew that's a thing now. Removed the checkbox over the private email,
should be ok now. Somehow missed the clang-format issue again (I thought I
fixed it) - updated to calm it down
https://github.com/llvm/llvm-project/pull/122606
___
https://github.com/petr-polezhaev updated
https://github.com/llvm/llvm-project/pull/122606
>From 994d7bfaf416b5015c5004365e199769e26dffc4 Mon Sep 17 00:00:00 2001
From: Petr Polezhaev
Date: Sat, 11 Jan 2025 21:21:16 +0300
Subject: [PATCH] [clangd] Support .clangd command line modifications in
petr-polezhaev wrote:
rebased on the latest main squashing all fixes
https://github.com/llvm/llvm-project/pull/122606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petr-polezhaev updated
https://github.com/llvm/llvm-project/pull/122606
>From 4db81c715375422f31fd036e7ac308c3c2a579fd Mon Sep 17 00:00:00 2001
From: Petr Polezhaev
Date: Sat, 11 Jan 2025 21:21:16 +0300
Subject: [PATCH] [clangd] Support .clangd command line modifications in
https://github.com/petr-polezhaev updated
https://github.com/llvm/llvm-project/pull/122606
>From 0813476d626e21828f73e9f9a3a3561becd37277 Mon Sep 17 00:00:00 2001
From: Petr Polezhaev
Date: Sat, 11 Jan 2025 21:21:16 +0300
Subject: [PATCH 1/4] [clangd] Support .clangd command line modifications
@@ -38,10 +39,6 @@ class MockDirectoryCompilationDatabase : public
MockCompilationDatabase {
void addFile(llvm::StringRef Path, llvm::StringRef Contents);
- std::unique_ptr getProjectModules(PathRef) const override {
-return scanningProjectModules(MockedCDBPtr, TFS);
@@ -833,8 +833,8 @@ bool OverlayCDB::setCompileCommand(PathRef File,
std::unique_ptr
OverlayCDB::getProjectModules(PathRef File) const {
auto MDB = DelegatingCDB::getProjectModules(File);
- MDB->setCommandProvider([&Mangler = Mangler](tooling::CompileCommand
&Command,
-
@@ -32,9 +32,6 @@ namespace {
/// interfere with each other.
class ModuleDependencyScanner {
public:
- using CommandProvider =
- llvm::unique_function;
-
petr-polezhaev wrote:
Or `using CommandMangler = ProjectModules::CommandMangler`?
https://github.co
https://github.com/petr-polezhaev updated
https://github.com/llvm/llvm-project/pull/122606
>From 0813476d626e21828f73e9f9a3a3561becd37277 Mon Sep 17 00:00:00 2001
From: Petr Polezhaev
Date: Sat, 11 Jan 2025 21:21:16 +0300
Subject: [PATCH 1/3] [clangd] Support .clangd command line modifications
https://github.com/petr-polezhaev edited
https://github.com/llvm/llvm-project/pull/122606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petr-polezhaev edited
https://github.com/llvm/llvm-project/pull/122606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,6 +32,9 @@ namespace {
/// interfere with each other.
class ModuleDependencyScanner {
public:
+ using CommandProvider =
petr-polezhaev wrote:
In my original approach I just made the original CommandMangler (a struct)
shared_ptr and passed it here. It
petr-polezhaev wrote:
Ok. I'll wait for review confirmation and then fix the clang-format thing and
merge new main
https://github.com/llvm/llvm-project/pull/122606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
petr-polezhaev wrote:
> Do we need to update `buildModuleFile` in
> `clang-tools-extra/clangd/ModulesBuilder.cpp` to update the commands to build
> the module interfaces?
It uses `GlobalCompilationDatabase::getCompileCommand` (if I correctly
understand what you mean) which is overridden by
`
https://github.com/petr-polezhaev updated
https://github.com/llvm/llvm-project/pull/122606
>From 0813476d626e21828f73e9f9a3a3561becd37277 Mon Sep 17 00:00:00 2001
From: Petr Polezhaev
Date: Sat, 11 Jan 2025 21:21:16 +0300
Subject: [PATCH 1/2] [clangd] Support .clangd command line modifications
https://github.com/petr-polezhaev created
https://github.com/llvm/llvm-project/pull/122606
Tunnels `Manger` object into the `ScanningAllProjectModules` so it can be used
to perform necessary command-line modifications (which also adds `--resources`
path previously added there explicitly). This
19 matches
Mail list logo
