[PATCH] D40489: [clangd] Changed tracing interfaces

2017-11-27 Thread Pavel Sychev via Phabricator via cfe-commits
luckygeck added inline comments. Comment at: clangd/Trace.h:41 + /// Context. static PtrKey CtxKey; ilya-biryukov wrote: > luckygeck wrote: > > This is a (1)static non-pod member in an (2) interface. Is it really a good > > idea? If we plan to have only on

[PATCH] D40489: [clangd] Changed tracing interfaces

2017-11-27 Thread Pavel Sychev via Phabricator via cfe-commits
luckygeck added inline comments. Comment at: clangd/Trace.h:41 + /// Context. static PtrKey CtxKey; This is a (1)static non-pod member in an (2) interface. Is it really a good idea? If we plan to have only one ctxkey, then maybe let's make it not bound to