ilovepi wrote:
I ran into a similar problem, and Nikita had to cancel the whole thing (IIRC by
closing the PR and then reopening). It was not great, so I normally just merge
them one at a time now.
https://github.com/llvm/llvm-project/pull/150647
___
https://github.com/ilovepi approved this pull request.
Is the plan just to handle this for JSON and Mustache for now, and when we have
templates for Markdown (and whatever else) they'll just use this pattern? And I
guess migrate any tests we want to keep for HTML once we switch to the mustache
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/150570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/150448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/150414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/145967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
LGTM w/ the improved/reduced tests.
https://github.com/llvm/llvm-project/pull/87574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -777,7 +778,10 @@ static void populateSymbolInfo(SymbolInfo &I, const T *D,
const FullComment *C,
Mangler->mangleCXXVTable(CXXD, MangledStream);
else
MangledStream << D->getNameAsString();
- I.MangledName = MangledName;
+ if (MangledName.size() > 255)
+I.Man
@@ -234,10 +267,12 @@ static void serializeArray(const Container &Records,
Object &Obj,
json::Value RecordsArray = Array();
auto &RecordsArrayRef = *RecordsArray.getAsArray();
RecordsArrayRef.reserve(Records.size());
- for (const auto &Item : Records) {
+ for (size_t I
ilovepi wrote:
We haven't enabled it yet. Other priorities have taken precedence, but we're in
the middle of enabling it now.
https://github.com/llvm/llvm-project/pull/128680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
ilovepi wrote:
Is it possible to do all the JSON refactoring as the first PR, and then do the
mustache integration after? I believe those can be split w/o too much trouble.
https://github.com/llvm/llvm-project/pull/149006
___
cfe-commits mailing list
@@ -34,7 +34,7 @@ class Foo;
// CHECK-NEXT:
// CHECK-NEXT:
// CHECK-NEXT:
-// CHECK-NEXT: enum Color
ilovepi wrote:
Is there a reason we'd want to drop this? Writing out that its an
@@ -59,7 +59,7 @@ class Foo;
// CHECK-NEXT:
// CHECK-NEXT:
// CHECK-NEXT:
-// CHECK-NEXT: Defined at line 5 of file
{{.*}}mustache-index.cpp
+// CHECK: Defined at line 5 of file {{.*}}mustache-inde
ilovepi wrote:
Looking at the patch, I'm wondering if we can decouple the changes to output
and add things like missing features in separate patches? There seems to be
more changing than I expected in the template and tests. So if we can have a
transition thats basically a NOP (or as close as
https://github.com/ilovepi approved this pull request.
LGTM, assuming the complaint is from the optional and not the StringRef.
https://github.com/llvm/llvm-project/pull/148923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
ilovepi wrote:
> @Prabhuk I might need some help here. Looking at the output for the `Clang ::
> Driver/DTLTO/dtlto.c test` on your buildbot LLD is being invoked with the
> argument `"--thinlto-remote-compiler=/b/s/w/ir/x/w/llvm_build/bin/llvm"`.
> That is clearly not the location of a Clang c
ilovepi wrote:
I see this patch also failing its own tests in our ci
```
TEST 'Clang :: Driver/DTLTO/dtlto.c' FAILED
Exit Code: 1
Command Output (stderr):
--
/b/s/w/ir/x/w/llvm_build/bin/clang -flto=thin
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Drive
@@ -0,0 +1,10 @@
+// RUN: %clang_cc1 -triple arm64-apple-macosx14.0.0 -O0
-debug-info-kind=standalone -dwarf-version=5 \
+// RUN: -fsanitize=float-cast-overflow -fsanitize-trap=float-cast-overflow
-emit-llvm %s -o - | FileCheck %s
+
+int f(float x) {
+ return (int)x;
+}
+
+//
@@ -0,0 +1,43 @@
+// REQUIRES: lld
+
+/// Check DTLTO options are forwarded to the linker.
+
+// RUN: echo "--target=x86_64-linux-gnu \
+// RUN: -Xthinlto-distributor=distarg1 \
+// RUN: -Xthinlto-distributor=distarg2,distarg3 \
+// RUN: -fuse-ld=lld" > %t.rsp
--
@@ -378,6 +378,7 @@ struct SymbolInfo : public Info {
std::optional DefLoc; // Location where this decl is defined.
llvm::SmallVector Loc; // Locations where this decl is declared.
bool IsStatic = false;
+ SmallString<16> MangledName;
ilovepi wrote:
https://github.com/ilovepi approved this pull request.
LGTM, with some minor comments.
https://github.com/llvm/llvm-project/pull/148021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -501,15 +502,26 @@ Error JSONGenerator::generateDocs(
SmallString<128> Path;
sys::path::native(RootDir, Path);
-sys::path::append(Path, Info->getRelativeFilePath(""));
if (!CreatedDirs.contains(Path)) {
if (std::error_code Err = sys::fs::create_direc
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/148021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
> I wouldn't say it's orthogonal. It's a very interesting implementation idea
> but there are several reasons why we don't want to pursue it right now.
>
> 1. What you are proposing is significantly more complicated than what is
> implemented in this PR. This work being part of
ilovepi wrote:
> @ilovepi
>
> > There's a large number of tests. Many of these look like they're close to
> > an existing test ... in these cases is it possible to just use the existing
> > test file and add checks under a prefix?
>
> I originally recommended that @anthonyhatran write new tes
https://github.com/ilovepi approved this pull request.
LGTM. Maybe use `[clang-doc] Serialize IsBuiltIn and IsTemplate for types` as
the title?
https://github.com/llvm/llvm-project/pull/146149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
@@ -800,11 +800,37 @@ llvm::Error ClangDocBitcodeReader::readBlock(unsigned ID,
T I) {
}
}
-// TODO: Create a helper that can receive a function to reduce repetition for
-// most blocks.
+template
+llvm::Error ClangDocBitcodeReader::handleSubBlock(unsigned ID, T Parent,
+
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/145835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -800,11 +800,37 @@ llvm::Error ClangDocBitcodeReader::readBlock(unsigned ID,
T I) {
}
}
-// TODO: Create a helper that can receive a function to reduce repetition for
-// most blocks.
+template
+llvm::Error ClangDocBitcodeReader::handleSubBlock(unsigned ID, T Parent,
+
https://github.com/ilovepi approved this pull request.
LGTM, modulo the one Q.
https://github.com/llvm/llvm-project/pull/145835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -454,27 +417,19 @@ static void serializeInfo(const RecordInfo &I,
json::Object &Obj,
Obj["ProtectedMembers"] = ProtectedMembersArray;
}
- if (!I.Bases.empty()) {
-json::Value BasesArray = Array();
-json::Array &BasesArrayRef = *BasesArray.getAsArray();
-
@@ -278,6 +247,16 @@ static void serializeInfo(const ConstraintInfo &I, Object
&Obj) {
Obj["Expression"] = I.ConstraintExpr;
}
+static void serializeInfo(const std::vector &Params,
ilovepi wrote:
```suggestion
static void serializeInfo(ArrayRef Params,
```
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/145595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM. Glad to see so much code getting deleted! Overall great cleanups. Left a
couple small comments inline.
https://github.com/llvm/llvm-project/pull/145595
___
cfe-commits mailing list
cfe-commi
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/144617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,15 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/_ZTT7MyClassIiE.json
ilovepi wrote:
I guess this serves the same purpose, but it'd be nice to have
@@ -909,6 +910,13 @@ emitInfo(const RecordDecl *D, const FullComment *FC,
Location Loc,
RI->Template.emplace();
RI->Template->Specialization.emplace();
auto &Specialization = *RI->Template->Specialization;
+auto *Mangler = ItaniumMangleContext::create(
+
@@ -209,6 +209,9 @@ struct TemplateSpecializationInfo {
// Template parameters applying to the specialized record/function.
std::vector Params;
+
+ // Used to distinguish class specialization file names.
+ std::optional> MangledName;
ilovepi wrote:
can
https://github.com/ilovepi approved this pull request.
LGTM. I left a couple of comments, but overall this looks like its in a good
state.
https://github.com/llvm/llvm-project/pull/144617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/144160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,29 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --extra-arg -std=c++20 --output=%t --format=json
--executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+template
+concept Addable = requires(T a, T b) {
+ { a + b };
+};
+
+templat
@@ -0,0 +1,37 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --extra-arg -std=c++20 --output=%t --format=json
--executor=standalone %s
ilovepi wrote:
Let’s try to mark it fail with filecheck. If that’s doesn’t work, I’m ok with
this.
https://github.c
https://github.com/ilovepi approved this pull request.
Let, module some minor comments.
https://github.com/llvm/llvm-project/pull/144160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/144160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/143919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
https://github.com/llvm/llvm-project/pull/143919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
This was completed in https://github.com/llvm/llvm-project/pull/142813
https://github.com/llvm/llvm-project/pull/111487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/111487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,193 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+struct Foo;
+
+// This is a nice class.
+// It has some nice methods and fields.
+// @brief This is
https://github.com/ilovepi deleted
https://github.com/llvm/llvm-project/pull/142483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,193 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+struct Foo;
+
+// This is a nice class.
+// It has some nice methods and fields.
+// @brief This is
@@ -0,0 +1,175 @@
+#include "ClangDocTest.h"
+#include "Generators.h"
+#include "Representation.h"
+#include "gtest/gtest.h"
+
+namespace clang {
+namespace doc {
+
+static std::unique_ptr getJSONGenerator() {
+ auto G = doc::findGeneratorByName("json");
+ if (!G)
+return nu
@@ -0,0 +1,194 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+struct Foo;
+
+// This is a nice class.
+// It has some nice methods and fields.
+// @brief This is
ilovepi wrote:
@snarang181 I cannot see how this patch would affect a test in the JIT.
Sometimes main is not clean, and sometime there is flake in some tests or under
a sanitizer. We should be good IMO.
https://github.com/llvm/llvm-project/pull/142273
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
LGTM. Thanks for the patch
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/142483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,194 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+struct Foo;
+
+// This is a nice class.
+// It has some nice methods and fields.
+// @brief This is
@@ -0,0 +1,40 @@
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --output=%t --format=json --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json
+
+struct MyClass {
+ template T methodTemplate(T param) {
+ }
+};
+
+// CHECK: "PublicFunct
@@ -670,12 +671,17 @@ static std::unique_ptr genHTML(const
CommentInfo &I) {
return nullptr;
return std::move(BlockComment);
}
- if (I.Kind == "TextComment") {
-if (I.Text == "")
+
+ case CommentKind::CK_TextComment: {
+if (I.Text.empty())
return n
@@ -316,8 +316,13 @@ static llvm::Error parseRecord(const Record &R, unsigned
ID,
static llvm::Error parseRecord(const Record &R, unsigned ID,
llvm::StringRef Blob, CommentInfo *I) {
switch (ID) {
- case COMMENT_KIND:
-return decodeRecord(
https://github.com/ilovepi approved this pull request.
LGTM once the last few nits are addressed.
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -0,0 +1,430 @@
+#include "Generators.h"
+#include "clang/Basic/Specifiers.h"
+#include "llvm/Support/JSON.h"
+
+using namespace llvm;
+using namespace llvm::json;
+
+namespace clang {
+namespace doc {
+
+class JSONGenerator : public Generator {
+public:
+ static const char *Fo
https://github.com/ilovepi approved this pull request.
I think this is a good start, modulo a couple fixes on reserving space in
json::Arrays. I'm fine if we keep incrementally adding testing rather than
doing it all up front. When we're done I imagine most of the YAML tests can be
converted,
@@ -0,0 +1,430 @@
+#include "Generators.h"
+#include "clang/Basic/Specifiers.h"
+#include "llvm/Support/JSON.h"
+
+using namespace llvm;
+using namespace llvm::json;
+
+namespace clang {
+namespace doc {
+
+class JSONGenerator : public Generator {
+public:
+ static const char *Fo
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Oh, lets updated the PR description with a more complete description of the
change. It can also be marked as `Fixes #NNN` since this basically implements
everything outlined in the issues, unless I'm forgetting something.
https://github.com/llvm/llvm-project/pull/142273
@@ -208,37 +208,107 @@ static json::Value extractValue(const TypedefInfo &I) {
}
static json::Value extractValue(const CommentInfo &I) {
- assert((I.Kind == "BlockCommandComment" || I.Kind == "FullComment" ||
- I.Kind == "ParagraphComment" || I.Kind == "TextComment")
https://github.com/ilovepi commented:
Getting pretty close. I think once the remaining comments are addressed it will
probably be ready to land.
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
ilovepi wrote:
> > This sounds promising. I'm fine w/ adding a field to track this. BTW, what
> > does clang do? I'm wondering if we should track more than 1-bit of info
> > here.
>
> As far as I can tell, inside the AST Clang makes use of the `isa<>`
> mechanisms (which we could also leverag
@@ -316,8 +316,13 @@ static llvm::Error parseRecord(const Record &R, unsigned
ID,
static llvm::Error parseRecord(const Record &R, unsigned ID,
llvm::StringRef Blob, CommentInfo *I) {
switch (ID) {
- case COMMENT_KIND:
-return decodeRecord(
@@ -208,37 +208,105 @@ static json::Value extractValue(const TypedefInfo &I) {
}
static json::Value extractValue(const CommentInfo &I) {
- assert((I.Kind == "BlockCommandComment" || I.Kind == "FullComment" ||
- I.Kind == "ParagraphComment" || I.Kind == "TextComment")
ilovepi wrote:
> If we're open to adding a flag in the base `Info` like
> `IsClassSpecialization`, then we can probably easily deal with these by
> trying to reconstruct the specialization's arguments (will be something like
> "Foo.json"). Functions don't produce their own files so function
>
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/142665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
> Right now, since I just ripped the Mustache generator code, it creates
> folders for each namespace and emits the nested entities there. This actually
> represents a problem for template specializations because the code tries to
> write another JSON object (the specialization
ilovepi wrote:
> I'll investigate this. Although right off the bat, the names in the Infos
> aren't mangled. `Name` and `FullName` are the same for both records, which is
> unfortunate.
OK, well, let's give it a try, and if its too hard lets ... IDK go w/ the YAML
thing, so its correct? Test
@@ -198,37 +198,107 @@ static json::Value extractValue(const TypedefInfo &I) {
}
static json::Value extractValue(const CommentInfo &I) {
- assert((I.Kind == "BlockCommandComment" || I.Kind == "FullComment" ||
- I.Kind == "ParagraphComment" || I.Kind == "TextComment")
@@ -12711,6 +12711,11 @@ def warn_noderef_on_non_pointer_or_array : Warning<
def warn_noderef_to_dereferenceable_pointer : Warning<
"casting to dereferenceable pointer removes 'noderef' attribute">,
InGroup;
+def warn_cast_discards_cfi_unchecked_callee
+: Warning<"impli
@@ -198,37 +198,107 @@ static json::Value extractValue(const TypedefInfo &I) {
}
static json::Value extractValue(const CommentInfo &I) {
- assert((I.Kind == "BlockCommandComment" || I.Kind == "FullComment" ||
- I.Kind == "ParagraphComment" || I.Kind == "TextComment")
@@ -670,12 +671,17 @@ static std::unique_ptr genHTML(const
CommentInfo &I) {
return nullptr;
return std::move(BlockComment);
}
- if (I.Kind == "TextComment") {
-if (I.Text == "")
+
+ case CommentKind::CK_TextComment: {
+if (I.Text.empty())
return n
@@ -45,6 +45,25 @@ enum class InfoType {
IT_typedef
};
+enum class CommentKind {
+ CK_FullComment,
+ CK_ParagraphComment,
+ CK_TextComment,
+ CK_InlineCommandComment,
+ CK_HTMLStartTagComment,
+ CK_HTMLEndTagComment,
+ CK_BlockCommandComment,
+ CK_ParamCommandComment
@@ -0,0 +1,352 @@
+#include "Generators.h"
+#include "llvm/Support/JSON.h"
+
+using namespace llvm;
+using namespace llvm::json;
+
+static llvm::ExitOnError ExitOnErr;
+
+namespace clang {
+namespace doc {
+
+class JSONGenerator : public Generator {
+public:
+ static const char *
@@ -0,0 +1,352 @@
+#include "Generators.h"
+#include "llvm/Support/JSON.h"
+
+using namespace llvm;
+using namespace llvm::json;
+
+static llvm::ExitOnError ExitOnErr;
+
+namespace clang {
+namespace doc {
+
+class JSONGenerator : public Generator {
+public:
+ static const char *
ilovepi wrote:
### Merge activity
* **Jun 3, 4:36 PM UTC**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/142209).
https://github.com/llvm/llvm-project/pull/142209
_
@@ -0,0 +1,352 @@
+#include "Generators.h"
+#include "llvm/Support/JSON.h"
+
+using namespace llvm;
+using namespace llvm::json;
+
+static llvm::ExitOnError ExitOnErr;
+
+namespace clang {
+namespace doc {
+
+class JSONGenerator : public Generator {
+public:
+ static const char *
@@ -0,0 +1,352 @@
+#include "Generators.h"
+#include "llvm/Support/JSON.h"
+
+using namespace llvm;
+using namespace llvm::json;
+
+static llvm::ExitOnError ExitOnErr;
+
+namespace clang {
+namespace doc {
+
+class JSONGenerator : public Generator {
+public:
+ static const char *
https://github.com/ilovepi commented:
This is a good start, but I thin we'll want some more tests, and probably some
unit test coverage. Unittesting is especially nice, since I believe this
backend doesn't need any of the asset files, right?
As for whether this should follow the pattern of YAM
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/142483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
> Hi, sorry for the lack response. Unfortunately my father passed away recently
> so I was dealing with the logistics. I'm more than happy to deal with any
> issues that arises from my previous code
@PeterChou1 I'm sorry to hear about your circumstances. That's truly a hard
th
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/142665
Instead of having a platform specific error diagnostic, use a fixed one
with more direct context for the error.
>From 26277ead2a7f476daaae7c7c972549b6f949d850 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue
ilovepi wrote:
* **#142665** https://app.graphite.dev/github/pr/llvm/llvm-project/142665?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1426
ilovepi wrote:
### Merge activity
* **Jun 3, 4:54 PM UTC**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/141139).
https://github.com/llvm/llvm-project/pull/141139
_
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/141139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/142209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/142373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi approved this pull request.
Thanks for pointing this out. I'll try to follow up later today w/ a less
brittle check.
https://github.com/llvm/llvm-project/pull/142373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/ilovepi commented:
I'll take another pass later in the week, but here are some initial comments.
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -26,6 +26,66 @@
namespace clang {
namespace doc {
+CommentKind stringToCommentKind(llvm::StringRef KindStr) {
+ if (KindStr == "FullComment")
+return CommentKind::CK_FullComment;
ilovepi wrote:
IDK if the huge set of conditionals is great. There are a
https://github.com/ilovepi edited
https://github.com/llvm/llvm-project/pull/142273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1327 matches
Mail list logo
