[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,4 @@ +// RUN: not clang-doc %S/Inputs/basic-project/src/Circle.cpp -output=/root/docs 2>&1 | FileCheck %s ilovepi wrote: Well, I had forgotten that `create_directories()` works differently than `create_directory()`, in that its basically `mkdir -p`.

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
@@ -373,20 +370,16 @@ Example usage for a project using a compile commands database: // Ensure the root output directory exists. if (std::error_code Err = llvm::sys::fs::create_directories(OutDirectory); Err != std::error_code()) { -llvm::errs() << "Failed to cre

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
ilovepi wrote: Other than some nits the patch is mostly ready to go. It does need a test though, which sadly we don't already have. Please add a lit test under clang-tools-extra/tests/clang-doc. https://github.com/llvm/llvm-project/pull/141699 ___ cf

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
@@ -371,22 +367,14 @@ Example usage for a project using a compile commands database: sortUsrToInfo(USRToInfo); // Ensure the root output directory exists. - if (std::error_code Err = llvm::sys::fs::create_directories(OutDirectory); - Err != std::error_code()) { -

[clang-tools-extra] [clang-doc] Refactor error handling to use ExitOnError (PR #141699)

2025-05-28 Thread Paul Kirth via cfe-commits
@@ -49,6 +49,7 @@ using namespace clang::ast_matchers; using namespace clang::tooling; using namespace clang; +static llvm::ExitOnError ExitOnErr; ilovepi wrote: ```suggestion static llvm::ExitOnError ExitOnErr; ``` Nit: newline between using and the declarat

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-27 Thread Paul Kirth via cfe-commits
ilovepi wrote: @boomanaiden154 any idea why the buildkite job for linux is queued for about 3.5 hours? Also is there a way to see why the github action linux job failed? I don't see anything in the logs, just an exit 1. https://github.com/llvm/llvm-project/pull/138065 _

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138065 >From f242226c7199e5a3ab1e6b98cd53c19c4cd2e6d4 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:31:54 -0700 Subject: [PATCH] [clang-doc] Update serializer for improved template handling This

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-27 Thread Paul Kirth via cfe-commits
@@ -35,6 +35,169 @@ static void populateMemberTypeInfo(RecordInfo &I, AccessSpecifier &Access, const DeclaratorDecl *D, bool IsStatic = false); +static void getTemplateParameters(const TemplateParameterList

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138065 >From 2f04040cfbd38df7ac57d374c2931055dd712a81 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:31:54 -0700 Subject: [PATCH] [clang-doc] Update serializer for improved template handling This

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Implement setupTemplateValue for HTMLMustacheGenerator (PR #138064)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Update serializer for improved template handling (PR #138065)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138065 >From 515b014f4a3b39ff6fa742de095cddbc375f5a3e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:31:54 -0700 Subject: [PATCH] [clang-doc] Update serializer for improved template handling This

[clang-tools-extra] [clang-doc] Implement setupTemplateValue for HTMLMustacheGenerator (PR #138064)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Implement setupTemplateValue for HTMLMustacheGenerator (PR #138064)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138064 >From 72da18f86f4ce50cbd804ae47feb6baeb275e159 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:13:46 -0700 Subject: [PATCH] [clang-doc] Implement setupTemplateValue for HTMLMustacheGenerator

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From 0c7122c91b45548a6401be465d1c94452a96cf53 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 23, 10:52 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138063). https://github.com/llvm/llvm-project/pull/138063 ___

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From 03f3e44aa97edb5cceda728d7318251ccca19cd0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: #141269 should fix the issue for now. I'll clean up the rest of the stack to avoid reintroducing this problem. https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 23, 6:45 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/141269). https://github.com/llvm/llvm-project/pull/141269

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#141269** https://app.graphite.dev/github/pr/llvm/llvm-project/141269?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1412

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi ready_for_review https://github.com/llvm/llvm-project/pull/141269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Avoid reading files in unit tests (PR #141269)

2025-05-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141269 In #138062 it was brought up that this was an anti-pattern. We'll need to Migrate all of the mustache unittests to lit tests, and disable them until tool support lands. >From a675e0827d8bee1cfff9e095bc7eb394f520

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-23 Thread Paul Kirth via cfe-commits
ilovepi wrote: > Reading files from unit tests is a bit of an anti-pattern: It requires > putting the absolute path to the tests somewhere (you're doing this with a > config file here), and it means you easily run tests on a different machine > than the one you're building on. Could you restru

[clang-tools-extra] [clang-doc] Precommit test for correct conversion function names (PR #141168)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. Perfect. LGTM. https://github.com/llvm/llvm-project/pull/141168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: stacked PRs are still not as nice as phabricator or gerrit, but Graphite is a lot more firendly than I found spr, or winging it w/ github PRs. For a precommit test, it isn't too hard to upload a patch for before and then rebase the "after" patch after it lands. https://github.c

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: You can find a stack where I did that here: https://app.graphite.dev/github/pr/llvm/llvm-project/135705/%5Bllvm%5D%5Blto%5D-Precommit-test-for-libcall-internalization Those aren't landed, since we're hashing out the proper way to fix things, but I added a test w/ the behavior to

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: Sorry, I mean committing a test w/ the current in-tree behavior, and then this patch would have your fix and a small delta to the test showing the new behavior. Some information on that can be found here: https://llvm.org/docs/TestingGuide.html#precommit-workflow-for-tests http

[clang-tools-extra] [clang-doc] fix names of conversions for template parameters (PR #140856)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM, but would you mind pre-committing the test so its easy to see what's changing in the output with this patch? I've been trying to get more of that done when we're changing clang-doc output. Otherwise it's hard to know exactly what we'

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138063 >From afa7c63c997dcfee4b50a0b5a4aa0f17b74a0ac1 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:11:39 -0700 Subject: [PATCH] [clang-doc] Extract Info into JSON values Split from #133161. This

[clang-tools-extra] [clang-doc] Extract Info into JSON values (PR #138063)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 22, 9:19 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138062). https://github.com/llvm/llvm-project/pull/138062

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 86dc2be43374138ecea82f0266f8b8ae7ac17f4e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/141139 >From 7f51d821b16e71a8834f7560c25268bd02c264df Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 21 May 2025 09:50:32 -0700 Subject: [PATCH] [clang-doc] Reenable time trace support This patch re-enables -fti

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/141139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I'm not sure I want to land this before I land the main support for Mustache templates. I think its easier to rebase this patch, than that whole stack. https://github.com/llvm/llvm-project/pull/141139 ___ cfe-comm

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#141139** https://app.graphite.dev/github/pr/llvm/llvm-project/141139?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1411

[clang-tools-extra] [clang-doc] Reenable time trace support (PR #141139)

2025-05-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/141139 This patch re-enables -ftime-trace support in clang-doc. Initial support in #97644 was reverted, and never relanded. This patch adds back the command line option, and leverages the RAII tracing infrastructure mor

[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

2025-05-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: I've updated https://github.com/llvm/llvm-project/issues/140773 with a reproducer. https://github.com/llvm/llvm-project/pull/140930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

2025-05-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: Well, its not the easiest case to reduce, since there's lots of ways the two errors in question could happen. That code has been accepted by both GCC and clang for some time though, so at the very least we need guidance on what is wrong with it. >From what I've been able to tel

[clang] [Clang] Fix missed initializer instantiation bug for variable templates (PR #138122)

2025-05-21 Thread Paul Kirth via cfe-commits
ilovepi wrote: I have a revert up for this in #140930, due to the regressions reported in #140773, which breaks Fuchsia builds with new toolchains. We're fairly certain that changing the instantiation order as done in the patch is the root cause of the regression. https://github.com/llvm/llv

[clang] Revert "[Clang] Fix missed initializer instantiation bug for variable templates" (PR #140930)

2025-05-21 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/140930 Reverts llvm/llvm-project#138122 The patch causes a regression and prevents compiling valid C++ code. The code was accepted by earlier versions of clang and GCC. See https://github.com/llvm/llvm-project/issues

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -6,4 +6,6 @@ set(LLVM_LINK_COMPONENTS add_clang_library(clangDocSupport STATIC File.cpp - ) \ No newline at end of file + Utils.cpp + ) + ilovepi wrote: oh, CMake file ... ๐Ÿคฆ https://github.com/llvm/llvm-project/pull/138062 __

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,61 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -6,4 +6,6 @@ set(LLVM_LINK_COMPONENTS add_clang_library(clangDocSupport STATIC File.cpp - ) \ No newline at end of file + Utils.cpp + ) + ilovepi wrote: one would hope `git calng-format would catch this...`. Will fix. https://github.com/llvm/llvm-pro

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -74,7 +75,51 @@ static std::unique_ptr NamespaceTemplate = nullptr; static std::unique_ptr RecordTemplate = nullptr; +static Error +setupTemplate(std::unique_ptr &Template, + StringRef TemplatePath, + std::vector> Partials) { + auto T = Mustache

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 3d870717fdc1a35f3fc28e7fa74b763362f98c19 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 442fe2fd1353c540bc0ec39ec913e7e414def6bc Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From 187b130d43c4470768b3885cb9c333b9edfb3897 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 16, 8:28 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138061). https://github.com/llvm/llvm-project/pull/138061

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From de0222f0459bb6c5832ccdbe70b19f5ea8b0cd98 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
@@ -70,18 +70,116 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
@@ -70,18 +70,116 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc][NFC] Fix missing documentation for EndLineNumber (PR #138051)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -262,8 +262,8 @@ struct Location { std::tie(Other.StartLineNumber, Other.EndLineNumber, Other.Filename); } - int StartLineNumber = 0; // Line number of this Location. - int EndLineNumber = 0; + int StartLineNumber = 0; // Line number of this Location.

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -693,6 +693,18 @@ CGCallee ItaniumCXXABI::EmitLoadOfMemberFunctionPointer( llvm::Constant *CheckTypeDesc; bool ShouldEmitCFICheck = CGF.SanOpts.has(SanitizerKind::CFIMFCall) && CGM.HasHiddenLTOVisibility(RD); + + if (ShouldEmitCFICheck) { +

[clang] [clang] Function type attribute to prevent CFI instrumentation (PR #135836)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -3006,6 +3006,10 @@ static LValue EmitFunctionDeclLValue(CodeGenFunction &CGF, const Expr *E, GlobalDecl GD) { const FunctionDecl *FD = cast(GD.getDecl()); llvm::Constant *V = CGF.CGM.getFunctionPointer(GD); + if (E->getType()->isCF

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -57,18 +57,118 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From 1925647e9577d827a87d1c7ac4326836928f90e0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-12 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-12 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 12, 9:52 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138060). https://github.com/llvm/llvm-project/pull/138060

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138060 >From 88e705710a6c25eee3468dc51ade3b1e274eb7be Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 07:59:01 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator.cpp Split from #133161. This

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -535,6 +535,8 @@ struct ClangDocContext { // JavaScript files that will be imported in all HTML files. std::vector JsScripts; StringRef Base; + // Mustache Template files ilovepi wrote: done. LMK if something is unclear. https://github.com/llvm/llvm

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138060 >From ba7721e9a60a466966a0e10a59491ba4e59b86a3 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 07:59:01 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator.cpp Split from #133161. This

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -535,6 +535,8 @@ struct ClangDocContext { // JavaScript files that will be imported in all HTML files. std::vector JsScripts; StringRef Base; + // Mustache Template files ilovepi wrote: My understanding is that it provides a mapping to of a template

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,87 @@ +//===-- clang-doc/HTMLMustacheGeneratorTest.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// ilovepi wrote: Ah, good catch. https://github.com/llvm/llvm-project/pull/138060 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] [clang-doc] Add missing comment for Base (PR #138053)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add missing comment for Base (PR #138053)

2025-05-07 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 7, 7:22 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138053). https://github.com/llvm/llvm-project/pull/138053 _

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-05-07 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 7, 7:22 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138052). https://github.com/llvm/llvm-project/pull/138052 _

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138052 >From 3e612b30626cfe3963fdbed341c028a8a8f0917e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:11:55 -0700 Subject: [PATCH 1/2] [clang-doc][NFC] Add TODO for future work --- clang-tools-ext

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138060 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Add Mustache template assets (PR #138059)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add Mustache template assets (PR #138059)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138059 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138058 Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-05-06 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 6, 11:12 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138058). https://github.com/llvm/llvm-project/pull/138058

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-05-06 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/132510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add regression test for test comments in macros (PR #132510)

2025-05-03 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,35 @@ +// Regression test for https://github.com/llvm/llvm-project/issues/59819 + +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md --check-prefix=MD-MYC

[clang-tools-extra] [llvm] [clang-doc] Adds a mustache backend (PR #133161)

2025-05-01 Thread Paul Kirth via cfe-commits
ilovepi wrote: @PeterChou1 I've uploaded a patch set w/ the relevant changes from this patch. Some of the details were split into standalone patches, but I'd appreciate if you could help both review and test those patches. It would also be nice if you could share any testing corpus or lit test

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

2025-05-01 Thread Paul Kirth via cfe-commits
ilovepi wrote: closing, since we landed https://github.com/llvm/llvm-project/pull/137732 https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang-tools-extra] [clang-doc] Add Start and End Line Numbers (PR #135081)

2025-05-01 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/135081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-04-30 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#138063** https://app.graphite.dev/github/pr/llvm/llvm-project/138063?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> * **#138062** https://app.graphite.dev/github/pr/llvm/llvm-

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-04-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi ready_for_review https://github.com/llvm/llvm-project/pull/138058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Track Descriptions and TypeDeclaration for types (PR #138058)

2025-04-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/138058 Split from #133161. This patch allows Typedefs to now track both their declarations and full descriptions. Subsequent patches will leverage the additional fields in the representation. Co-authored-by: Peter Chou

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-04-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/138052 None >From 3e612b30626cfe3963fdbed341c028a8a8f0917e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:11:55 -0700 Subject: [PATCH] [clang-doc][NFC] Add TODO for future work --- clang-tools-e

[clang-tools-extra] [clang-doc] Add missing comment for Base (PR #138053)

2025-04-30 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#138053** https://app.graphite.dev/github/pr/llvm/llvm-project/138053?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1380

[clang-tools-extra] [clang-doc] Add missing comment for Base (PR #138053)

2025-04-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/138053 None >From 056ab13fceab69a11a9bb1c4c40b5ea901bad7bd Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 29 Apr 2025 18:22:05 -0700 Subject: [PATCH] [clang-doc] Add missing comment for Base --- clang-tools-ex

[clang-tools-extra] [clang-doc][NFC] Add TODO for future work (PR #138052)

2025-04-30 Thread Paul Kirth via cfe-commits
ilovepi wrote: * **#138052** https://app.graphite.dev/github/pr/llvm/llvm-project/138052?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> ๐Ÿ‘ˆ https://app.graphite.dev/github/pr/llvm/llvm-project/1380

  1   2   3   4   5   6   7   8   9   10   >