Re: [PATCH] D14919: Fix IssueHash generation

2015-11-25 Thread Orbán György via cfe-commits
I did not create a test checker for the NormalizeLine error in the patch. Should I add a test checker for this? Do you have any suggestions where to put it if required? GetEnclosingDeclContextSignature already checks for nullptr, this should have been done in the NormalizeLine function also, but i

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

2015-11-10 Thread Orbán György via cfe-commits
Hi, Sorry for my late answer. We fixed the plist parser for the CodeChecker it shoud process the plist generated by the current trunk clang with the issue hash tags. Right now CodeChecker does not support forwarding additional options directly to clang (uses only the compiler options from the ori

Re: [PATCH] D12906: [RFC] Bug identification("issue_hash") change for CmpRuns.py

2015-10-26 Thread Orbán György via cfe-commits
Hi, You are right the diff is is based on the hash. We already tried to use an earlier hash generator (before the patch was introduced), which generates a slightly different plist, that is why the current version does not work with the patch. We will fix CodeChecker to use new hash tag introduced