sarnex wrote:
It took me all day but I managed to reproduce the issue with Chromium,
investigating more.
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/141855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/141855
None
>From 18e18ca675a38ef6bf34a4450291ed9ebc85eb66 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 28 May 2025 14:00:46 -0700
Subject: [PATCH] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRT
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 7 May 2025 12:17:30 -0700
Subject: [PATCH 1/6] [clang] Simplify device kernel attributes
Signed-off-by: Sar
sarnex wrote:
Whoops, thanks!
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex converted_to_draft
https://github.com/llvm/llvm-project/pull/140910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
Looks like the fix commit broke something again :(
https://github.com/llvm/llvm-project/pull/140910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
Investigating, thanks.
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
Ah ok thank you! I'm surprised this work effects anything as I was mostly doing
it for upstream OMP SPV which doesnt' work yet :)
https://github.com/llvm/llvm-project/pull/137187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 7 May 2025 12:17:30 -0700
Subject: [PATCH 1/5] [clang] Simplify device kernel attributes
Signed-off-by: Sar
sarnex wrote:
@yingcong-wu Hi, I'm not totally sure what you mean, did this change break
something for you or did it fix something? Feel free to email me internally as
well. Thanks
https://github.com/llvm/llvm-project/pull/137187
___
cfe-commits mail
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/140910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/140910
The original change caused issues on MSVC due to a new warning thrown inside
MSVC headers. That was fixed
[here](https://github.com/llvm/llvm-project/commit/95bd9eef42679f3d13e3279204c75372e2c062f0),
so reapply
@@ -396,9 +396,12 @@ any option of a multiversioned function is undefined.
}];
}
-def SYCLKernelDocs : Documentation {
+def DeviceKernelDocs : Documentation {
let Category = DocCatFunction;
+ let Heading = "device_kernel";
sarnex wrote:
done in latest c
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 7 May 2025 12:17:30 -0700
Subject: [PATCH 1/5] [clang] Simplify device kernel attributes
Signed-off-by: Sar
sarnex wrote:
Thanks for the guidance and reviews!
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase {
/// Set of no-builtin functions listed by \#pragma function.
llvm::SmallSetVector MSFunctionNoBuiltins;
+ /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls
+ /// that refer to them.
+
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/138205
>From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Thu, 1 May 2025 14:47:45 -0700
Subject: [PATCH 1/3] [clang][Sema] Don't warn for implicit uses of builtins in
sy
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1825,6 +1825,11 @@ class Sema final : public SemaBase {
/// Set of no-builtin functions listed by \#pragma function.
llvm::SmallSetVector MSFunctionNoBuiltins;
+ /// Map of BuiltinIDs to source locations that have #pragma intrinsic calls
+ /// that refer to them.
+
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/138205
>From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Thu, 1 May 2025 14:47:45 -0700
Subject: [PATCH 1/2] [clang][Sema] Don't warn for implicit uses of builtins in
sy
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 7 May 2025 12:17:30 -0700
Subject: [PATCH 1/4] [clang] Simplify device kernel attributes
Signed-off-by: Sar
@@ -1538,11 +1533,32 @@ def CUDAShared : InheritableAttr {
}
def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>;
-def SYCLKernel : InheritableAttr {
- let Spellings = [Clang<"sycl_kernel">];
- let Subjects = SubjectList<[FunctionTmpl]>;
- let LangOpts = [SYCLDev
@@ -292,7 +292,7 @@ void NVPTXTargetCodeGenInfo::setTargetAttributes(
}
// Attach kernel metadata directly if compiling for NVPTX.
- if (FD->hasAttr()) {
+ if (FD->hasAttr()) {
F->setCallingConv(llvm::CallingConv::PTX_Kernel);
sarnex wrote:
Should
sarnex wrote:
@rnk Any feedback on my above comment? Hopefully I can merge a solution to the
issue soon. Thanks!
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -227,7 +227,7 @@ void SPIRVTargetCodeGenInfo::setCUDAKernelCallingConvention(
// Convert HIP kernels to SPIR-V kernels.
if (getABIInfo().getContext().getLangOpts().HIP) {
FT = getABIInfo().getContext().adjustFunctionType(
-FT, FT->getExtInfo().withCallingConv
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1538,11 +1533,32 @@ def CUDAShared : InheritableAttr {
}
def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>;
-def SYCLKernel : InheritableAttr {
- let Spellings = [Clang<"sycl_kernel">];
- let Subjects = SubjectList<[FunctionTmpl]>;
- let LangOpts = [SYCLDev
@@ -1538,11 +1533,32 @@ def CUDAShared : InheritableAttr {
}
def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>;
-def SYCLKernel : InheritableAttr {
- let Spellings = [Clang<"sycl_kernel">];
- let Subjects = SubjectList<[FunctionTmpl]>;
- let LangOpts = [SYCLDev
@@ -1538,11 +1533,44 @@ def CUDAShared : InheritableAttr {
}
def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>;
-def SYCLKernel : InheritableAttr {
- let Spellings = [Clang<"sycl_kernel">];
- let Subjects = SubjectList<[FunctionTmpl]>;
- let LangOpts = [SYCLDev
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1538,11 +1533,44 @@ def CUDAShared : InheritableAttr {
}
def : MutualExclusions<[CUDAConstant, CUDAShared, HIPManaged]>;
-def SYCLKernel : InheritableAttr {
- let Spellings = [Clang<"sycl_kernel">];
- let Subjects = SubjectList<[FunctionTmpl]>;
- let LangOpts = [SYCLDev
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 7 May 2025 12:17:30 -0700
Subject: [PATCH 1/2] [clang] Simplify device kernel attributes
Signed-off-by: Sar
sarnex wrote:
@AaronBallman I just pushed a first attempt to combine the attrs, however I'm
not sure if it's much cleaner given the attrs have different subjects/allowed
cases/expected warnings/etc. Do you mind taking a first look and seeing if you
think the general direction is a good idea? T
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
@@ -4911,8 +4911,8 @@ std::optional Type::getNullability()
const {
bool Type::canHaveNullability(bool ResultIfUnknown) const {
QualType type = getCanonicalTypeInternal();
+ // We'll only see canonical types here.
sarnex wrote:
done in latest commit, thank
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/138342
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
sarnex wrote:
> That change was reverted for different reasons. I shouldn't have changed the
> prototype of _mm_prefetch there, so I'm relanding it here:
> https://github.com/llvm/llvm-project/pull/138360
Thanks, my bad, I should have looked at the problem in more detail.
> So, winnt.h is sup
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/138342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/138342
More fixes based on https://github.com/llvm/llvm-project/pull/138036
>From 5540b8d5bc0130b2089c219d49e856ab6817420b Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Fri, 2 May 2025 13:39:59 -0700
Subject: [PA
sarnex wrote:
I think it's because we are explciitly marking these builtins as requiring a
header. If they aren't declared that way then you won't see this warning and
won't need this change.
I made the builtins require a header based on feedback from @rnk in the earlier
PR, and his suggestio
@@ -3997,7 +3996,7 @@ void CodeGenFunction::EmitFunctionEpilog(const
CGFunctionInfo &FI,
RV = SI->getValueOperand();
SI->eraseFromParent();
-// Otherwise, we have to do a simple load.
+ // Otherwise, we have to do a simple load.
s
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/138205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/138036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/138205
Running CI
>From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Thu, 1 May 2025 14:47:45 -0700
Subject: [PATCH] [clang][Sema] Don't warn for implicit uses of builtin
sarnex wrote:
> I was thinking that orthogonal calling conventions could be combined so that
> we need fewer of them. e.g., if spir_kernel cannot be mixed with nvptx_kernel
> in the same TU, then there's no need for two distinct internal
> representations for the attributes, just two distinct
https://github.com/sarnex converted_to_draft
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
> Do we need yet another calling convention or is there a way we can start to
> combine some of these for all the offloading languages? It seems we keep
> re-implementing the same concepts multiple times for each language and it
> would be nice to share as much of the frontend lo
@@ -1504,6 +1506,12 @@ def NVPTXKernel : InheritableAttr,
TargetSpecificAttr {
let Documentation = [Undocumented];
}
+def SPIRKernel : InheritableAttr, TargetSpecificAttr {
+ let Spellings = [Clang<"spir_kernel">];
+ let Subjects = SubjectList<[Function]>;
+ let Document
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/138036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
Ignoring clang-format CI result
https://github.com/llvm/llvm-project/pull/138036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From be91732b261f7a4874a9b1789fbf9bff6359cd58 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 30 Apr 2025 13:59:46 -0700
Subject: [PATCH] [clang] Add spir_kernel attribute
Signed-off-by: Sarnie, Nick
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/138000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/138000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 20498a3ab88fc60dfd425958c350e0d80f21951f Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Tue, 29 Apr 2025 14:40:43 -0700
Subject: [PATCH] [clang] Add spir_kernel attribute
Signed-off-by: Sarnie, Nick
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/138000
I'm planning on modifying this code so format it so we can pass the formatting
check.
>From 3ae86aef81e0ae19e49a4c6db9869e327d4ad4fc Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Wed, 30 Apr 2025 10:33:58
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-se
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex updated
https://github.com/llvm/llvm-project/pull/137882
>From 563660698c09d0e8b0d3e4d240d9a0ceae092493 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Tue, 29 Apr 2025 14:40:43 -0700
Subject: [PATCH] [clang] Add spir_kernel attribute
Signed-off-by: Sarnie, Nick
https://github.com/sarnex reopened
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/137882
None
>From 48a7768a33434e16c795ab8d575beb91480146f1 Mon Sep 17 00:00:00 2001
From: "Sarnie, Nick"
Date: Tue, 29 Apr 2025 14:40:43 -0700
Subject: [PATCH] [clang] Add spir_kernel attribute
Signed-off-by: Sarnie,
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/137187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
Probably yes, but I'd prefer to leave that to future work, I have enough on my
plate :)
https://github.com/llvm/llvm-project/pull/137187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
sarnex wrote:
Ping @AlexVlx @MrSidims thanks :)
https://github.com/llvm/llvm-project/pull/137187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex converted_to_draft
https://github.com/llvm/llvm-project/pull/136742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
FYI @mstorsjo I reverted the breaking change
[here](https://github.com/llvm/llvm-project/commit/b60ee399787cb2a5f50d21932db3492cc4ff0d34),
and I'll reapply it fixing the regression when I have a fix for it, sorry for
the trouble.
https://github.com/llvm/llvm-project/pull/136742
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/137374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/137374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/137374
This reverts commit
https://github.com/llvm/llvm-project/commit/de0153da325b21340747d8a064906a8c1c2f95ea.
It breaks MSVC.
>From 62328ab7fcaeea023b454b4e78fc6c7756439bf4 Mon Sep 17 00:00:00 2001
From: Nick Sarni
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/137373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
Thanks, let me know what you find!
I'll probably revert the original patch tomorrow to fix the regression and then
rework it with the fix.
https://github.com/llvm/llvm-project/pull/136742
___
cfe-commits mailing list
cfe-commits@lists.l
https://github.com/sarnex created
https://github.com/llvm/llvm-project/pull/137187
Based on feedback from https://github.com/llvm/llvm-project/pull/136753, remove
the dummy values for OpenCL and make them match the zero default AS map.
>From ebfc2c8dcdc819723ac2196d8362ffea5f91ec2f Mon Sep 17
https://github.com/sarnex approved this pull request.
https://github.com/llvm/llvm-project/pull/137070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/135251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex ready_for_review
https://github.com/llvm/llvm-project/pull/137187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1217,11 +1217,13 @@ void
CGOpenMPRuntimeGPU::emitParallelCall(CodeGenFunction &CGF,
CGBuilderTy &Bld = CGF.Builder;
llvm::Value *NumThreadsVal = NumThreads;
llvm::Function *WFn = WrapperFunctionsMap[OutlinedFn];
+llvm::FunctionCallee RuntimeFn = OMPBuilder.
@@ -1217,11 +1217,13 @@ void
CGOpenMPRuntimeGPU::emitParallelCall(CodeGenFunction &CGF,
CGBuilderTy &Bld = CGF.Builder;
llvm::Value *NumThreadsVal = NumThreads;
llvm::Function *WFn = WrapperFunctionsMap[OutlinedFn];
+llvm::FunctionCallee RuntimeFn = OMPBuilder.
sarnex wrote:
Thanks for the feedback, I'll work to address it.
https://github.com/llvm/llvm-project/pull/135251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sarnex wrote:
@alexfh The regression is fixed in
https://github.com/llvm/llvm-project/commit/52a96491e1e4e0d033e39fad87f49ccd871df41d
https://github.com/llvm/llvm-project/pull/135251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
sarnex wrote:
Thanks for the review, and will do @AlexVlx!
https://github.com/llvm/llvm-project/pull/136753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex closed
https://github.com/llvm/llvm-project/pull/136753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 453 matches
Mail list logo
