[clang] [Clang] Fix new driver device only compilation for `amdgcnspirv` target (PR #150110)

2025-07-22 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/150110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-07-11 Thread Nick Sarnie via cfe-commits
@@ -50,11 +50,11 @@ BUILTIN(__builtin_arm_wfi, "v", "") BUILTIN(__builtin_arm_sev, "v", "") BUILTIN(__builtin_arm_sevl, "v", "") BUILTIN(__builtin_arm_chkfeat, "WUiWUi", "") -TARGET_HEADER_BUILTIN(__yield, "v", "h", ARMACLE_H, ALL_LANGUAGES, "") -TARGET_HEADER_BUILTIN(__wfe,

[clang] [NFC][Clang][OpenMP] Refactor mapinfo generation for captured vars (PR #146891)

2025-07-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/146891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][OpenMP] Refactor mapinfo generation for captured vars (PR #146891)

2025-07-07 Thread Nick Sarnie via cfe-commits
sarnex wrote: 🚀 https://github.com/llvm/llvm-project/pull/146891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Clang] Introduce `--offload-targets` for `-fopenmp-targets` (PR #146594)

2025-07-03 Thread Nick Sarnie via cfe-commits
@@ -1138,6 +1138,10 @@ def fno_convergent_functions : Flag<["-"], "fno-convergent-functions">, // Common offloading options let Group = offload_Group in { +def offload_targets_EQ : CommaJoined<["--"], "offload-targets=">, sarnex wrote: I'm not sure if this i

[clang] [NFC][clang] Fix CodeGenSYCL::unique_stable_name_windows_diff test (PR #146854)

2025-07-03 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. Thanks Mariya! https://github.com/llvm/llvm-project/pull/146854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-07-02 Thread Nick Sarnie via cfe-commits
@@ -50,11 +50,11 @@ BUILTIN(__builtin_arm_wfi, "v", "") BUILTIN(__builtin_arm_sev, "v", "") BUILTIN(__builtin_arm_sevl, "v", "") BUILTIN(__builtin_arm_chkfeat, "WUiWUi", "") -TARGET_HEADER_BUILTIN(__yield, "v", "h", ARMACLE_H, ALL_LANGUAGES, "") -TARGET_HEADER_BUILTIN(__wfe,

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-20 Thread Nick Sarnie via cfe-commits
@@ -50,11 +50,11 @@ BUILTIN(__builtin_arm_wfi, "v", "") BUILTIN(__builtin_arm_sev, "v", "") BUILTIN(__builtin_arm_sevl, "v", "") BUILTIN(__builtin_arm_chkfeat, "WUiWUi", "") -TARGET_HEADER_BUILTIN(__yield, "v", "h", ARMACLE_H, ALL_LANGUAGES, "") -TARGET_HEADER_BUILTIN(__wfe,

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
@@ -103,11 +103,11 @@ TargetCodeGenInfo::getDependentLibraryOption(llvm::StringRef Lib, Opt += Lib; } -unsigned TargetCodeGenInfo::getOpenCLKernelCallingConv() const { - // OpenCL kernels are called via an explicit runtime API with arguments - // set with clSetKernelArg()

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/144728 >From da1523ec3b68d3d2a23f502df779c7e3f54320d0 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 18 Jun 2025 08:33:25 -0700 Subject: [PATCH 1/2] [clang][NFCI] Use TargetInfo to determine device kernel cal

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
@@ -103,11 +103,11 @@ TargetCodeGenInfo::getDependentLibraryOption(llvm::StringRef Lib, Opt += Lib; } -unsigned TargetCodeGenInfo::getOpenCLKernelCallingConv() const { - // OpenCL kernels are called via an explicit runtime API with arguments - // set with clSetKernelArg()

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-18 Thread Nick Sarnie via cfe-commits
@@ -80,12 +80,19 @@ unsigned CodeGenTypes::ClangCallConvToLLVMCallConv(CallingConv CC) { return llvm::CallingConv::AArch64_VectorCall; case CC_AArch64SVEPCS: return llvm::CallingConv::AArch64_SVE_VectorCall; - case CC_AMDGPUKernelCall: -return llvm::CallingConv:

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFCI] Use TargetInfo to determine device kernel calling convention (PR #144728)

2025-06-18 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/144728 None >From da1523ec3b68d3d2a23f502df779c7e3f54320d0 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 18 Jun 2025 08:33:25 -0700 Subject: [PATCH] [clang][NFCI] Use TargetInfo to determine device kernel c

[clang] [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V (PR #144605)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/144605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/144576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Nick Sarnie via cfe-commits
@@ -417,3 +417,17 @@ void HIPAMDToolChain::checkTargetID( getDriver().Diag(clang::diag::err_drv_bad_target_id) << *PTID.OptionalTargetID; } + +SPIRVAMDToolChain::SPIRVAMDToolChain(const Driver &D, + const llvm::Triple &Triple, +

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-17 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-13 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/144172 >From f2800e445bc739aa23523bc92ea317b12755cbd1 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 13 Jun 2025 16:21:24 -0700 Subject: [PATCH] [clang][ARM] Include arm_acle.h in intrin.h on supported platfo

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-13 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-13 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks, made https://github.com/llvm/llvm-project/pull/144172, will publish it early next week. https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-13 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/144172 None >From 7c5edb1f1140dc0d51a4b26be2e300a1eb6c5f43 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 13 Jun 2025 16:21:24 -0700 Subject: [PATCH] [clang][ARM] Include arm_acle.h in intrin.h on supported

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-13 Thread Nick Sarnie via cfe-commits
sarnex wrote: @rnk To be clear you mean modify Clang's `intrin.h` to include `arm_acle.h` when on supported targets, not the application code including `arm_acle.h` directly right? If so I can make that change. Thanks. https://github.com/llvm/llvm-project/pull/140910 __

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-12 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks for the explanation. To me it seems like the root issue here is that we have `__yield` (and probably a ton of other stuff) in `arm_acle.h` in Clang and it is not included from `intrin.h`, while MSVC's `intrin.h` does include `intrin0.inl.h` which has the declaration. Th

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-12 Thread Nick Sarnie via cfe-commits
sarnex wrote: Sorry, I'm not sure I understand the bug. For me, adding `#include ` fixed the warning. It seems true that MSVC doesn't provide `arm_acle.h` and `__yield()` is declared in `intrin0.inl.h`, but `clang` headers does have `arm_acle.h` and we are compiling with Clang which should h

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-12 Thread Nick Sarnie via cfe-commits
sarnex wrote: I think this repros it: ``` #include #define YIELD_PROCESSOR __yield() int main() { YIELD_PROCESSOR; return 0; }``` ``` clang-cl repro.c -target aarch64-windows-msvc ``` https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-12 Thread Nick Sarnie via cfe-commits
sarnex wrote: It looks like [this](https://chromium.googlesource.com/v8/v8/+/e082589a23e832f3f890ffb5594f8f47dba41bee%5E%21/#F0) commit landed, so is it safe to say I don't have to do anything? https://github.com/llvm/llvm-project/pull/140910 ___ cfe

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-12 Thread Nick Sarnie via cfe-commits
sarnex wrote: Man, I thought I finally had a version that didn't break anything. Investigating... https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] [Clang][OpenMP] Fix mapping of arrays of structs with members with mappers (PR #142511)

2025-06-11 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/142511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OpenMP] Fix mapping of arrays of structs with members with mappers (PR #142511)

2025-06-11 Thread Nick Sarnie via cfe-commits
sarnex wrote: I'll take your word the failures aren't related, but please watch CI to make sure any failures aren't related, thanks! https://github.com/llvm/llvm-project/pull/142511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks! https://github.com/llvm/llvm-project/pull/143546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/143546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
sarnex wrote: @Fznamznon Are you okay with merging this change? Thanks https://github.com/llvm/llvm-project/pull/143546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
sarnex wrote: > Do we observe the issue there because intel's fork used to add > OpenCLKernelAttr implicitly in SemaSYCL? Yes, since the attribute is created implicitly, there's no spelling to check so there's no `AttrName`. I understand we can only reproduce the problem out-of-tree, but since

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/143546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
sarnex wrote: CI fails not related https://github.com/llvm/llvm-project/pull/143546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Attr] Fix possible crash when trying to check for DeviceKernel spelling (PR #143546)

2025-06-10 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/143546 I didn't add a test because this can't be reproduced yet in this repo, I reproduced this only in intel's fork with more SYCL support. I also fixed some formatting. >From b5c115df82873ecd092d86be3e7e8339e076981f

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks for the quick reviews! https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
sarnex wrote: For this specific `requirements.txt` file, there are the only two vulnerabilities I saw. https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/143433 We need to make sure we aren't vulnerable to [PYSEC-2020-73](https://osv.dev/vulnerability/PYSEC-2020-73) and [PYSEC-2019-41](https://osv.dev/vulnerability/PYSEC-2019-41). >From 4cfcb16f7680a31ff040de37dbd9de45

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-07 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/143160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
@@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -triple aarch64 -ast-dump -ast-dump-filter foo %s \ +// RUN: | FileCheck --strict-whitespace %s + +// CHECK: {{foo1 'void \(\) __attribute__\(\(device_kernel\)\)'$}} sarnex wrote: applied this change and added a release note,

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/143160 >From 56f19d4f839d1c65a3f1145fcdcac5207ff61c11 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 6 Jun 2025 08:21:56 -0700 Subject: [PATCH 1/5] [clang][AST] Fix spaces TypePrinter for some calling convs

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/143160 >From 56f19d4f839d1c65a3f1145fcdcac5207ff61c11 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 6 Jun 2025 08:21:56 -0700 Subject: [PATCH 1/3] [clang][AST] Fix spaces TypePrinter for some calling convs

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
@@ -0,0 +1,24 @@ +// Verify there is a space after the parens when priting callingconv attributes. +// RUN: %clang_cc1 -DDEVICE -triple spirv64 -ast-dump -ast-dump-filter foo %s \ +// RUN: | FileCheck -check-prefix=CHECK-DEVICE --strict-whitespace %s + +// RUN: %clang_cc1 -DVECTO

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
sarnex wrote: Just pushed a commit with a test, thanks! https://github.com/llvm/llvm-project/pull/143160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/143160 >From 56f19d4f839d1c65a3f1145fcdcac5207ff61c11 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 6 Jun 2025 08:21:56 -0700 Subject: [PATCH 1/2] [clang][AST] Fix spaces TypePrinter for some calling convs

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks, will do. https://github.com/llvm/llvm-project/pull/143160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/143160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix spaces in TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/143160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix spaces TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/143160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix spaces TypePrinter for some calling convs (PR #143160)

2025-06-06 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/143160 There needs to be a space as the first character, otherwise the printed function prototype will have the CC attribute attached to the final `)`. >From 56f19d4f839d1c65a3f1145fcdcac5207ff61c11 Mon Sep 17 00:00:

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-05 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks for the reviews/feedback, going to merge this. Hopefully there isn't any fallout :) https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-05 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-04 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks Erich! @AaronBallman Do you mind giving the final version another quick pass to make sure all concerns are addressed? Thanks! https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-04 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/8] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-04 Thread Nick Sarnie via cfe-commits
@@ -3541,7 +3541,7 @@ bool FunctionDecl::isExternC() const { } bool FunctionDecl::isInExternCContext() const { - if (hasAttr()) + if (hasAttr() && getASTContext().getLangOpts().OpenCL) sarnex wrote: Sorry for the delay, I just pushed a commit updating all t

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-04 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/137882 >From 080a9d43ba6544d46c2b36c5dc6a5af421264580 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 7 May 2025 12:17:30 -0700 Subject: [PATCH 1/7] [clang] Simplify device kernel attributes Signed-off-by: Sar

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-04 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

2025-06-03 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang][ARM][AArch64] Define intrinsics guarded by __has_builtin on all platforms" (#128222)" (PR #140910)

2025-06-03 Thread Nick Sarnie via cfe-commits
sarnex wrote: Dependent commit reapplied. https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-06-03 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-06-02 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-06-02 Thread Nick Sarnie via cfe-commits
sarnex wrote: Sure, this was an interesting one. I thought I was losing my mind until I actually got into the debugger and saw the problem. https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-02 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-02 Thread Nick Sarnie via cfe-commits
@@ -3541,7 +3541,7 @@ bool FunctionDecl::isExternC() const { } bool FunctionDecl::isInExternCContext() const { - if (hasAttr()) + if (hasAttr() && getASTContext().getLangOpts().OpenCL) sarnex wrote: Thanks for the review. In an ideal world we would just be

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-06-02 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-06-02 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-06-02 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/142019 >From 87004192b6c3bd7b0a4614525ec3f6a1fe4e925e Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 30 May 2025 08:09:45 -0700 Subject: [PATCH] Reapply "[clang][Sema] Declare builtins used in #pragma intrins

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/142019 >From 168d68391da043f136ed9ea2115d1cda50af7e3b Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 30 May 2025 08:09:45 -0700 Subject: [PATCH] Reapply "[clang][Sema] Declare builtins used in #pragma intrins

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix and reapply 'Declare builtins used in #pragma intrinsic #138205' (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

2025-05-30 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/142019 >From 3cf1fcb8cc722bd60a91034d9ef47240bea6a751 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 30 May 2025 08:09:45 -0700 Subject: [PATCH] Reapply "[clang][Sema] Declare builtins used in #pragma intrins

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

2025-05-30 Thread Nick Sarnie via cfe-commits
sarnex wrote: Sure, I was hoping I could find an easy fix really quickly but just reproing took me a while, I'll revert immediately in the future, thanks. https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.

[clang] Revert "[clang][Sema] Declare builtins used in #pragma intrinsic" (PR #141994)

2025-05-29 Thread Nick Sarnie via cfe-commits
sarnex wrote: Sorry for the trouble https://github.com/llvm/llvm-project/pull/141994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

2025-05-29 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

2025-05-29 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/142019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Simplify device kernel attributes (PR #137882)

2025-05-29 Thread Nick Sarnie via cfe-commits
sarnex wrote: Any final comments on this @AaronBallman @erichkeane @arsenm @AlexVlx @yxsamliu, would appreciate a review, thanks! https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [clang][Parser] Fix lookup of builtins with pragma intrinsic (PR #142019)

2025-05-29 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/142019 None >From 5b0e367fcdb33763e3f4f94f8604db741801261d Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 29 May 2025 12:29:45 -0700 Subject: [PATCH] [clang][Parser] Fix lookup of builtins with pragma intrins

[clang] Revert "[clang][Sema] Declare builtins used in #pragma intrinsic" (PR #141994)

2025-05-29 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/141994 Reverts llvm/llvm-project#138205 Breaks Chrome. >From fb79103e3dca8a2a0f5732aefbc9cf71b967d357 Mon Sep 17 00:00:00 2001 From: Nick Sarnie Date: Thu, 29 May 2025 17:33:04 + Subject: [PATCH] Revert "[clang][S

[clang] [clang][Sema] Declare builtins used in #pragma intrinsic (PR #138205)

2025-05-29 Thread Nick Sarnie via cfe-commits
sarnex wrote: Chrome requested I revert https://github.com/llvm/llvm-project/pull/138205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][OpenMP][SPIR-V] Fix SPIR-V OpenMP DeviceRTL expected file name (PR #141855)

2025-05-29 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/141855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >