[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem added a comment. Thanks @kcc @vitalybuka, I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 ___ cfe-commits mailing list cfe-

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem marked 3 inline comments as done. Navidem added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + c

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 460251. Navidem added a comment. Use CHECK-DAG and separate function for checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCovera

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem marked an inline comment as done. Navidem added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + c

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 460232. Navidem added a comment. Enhance rt test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basi

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 460215. Navidem added a comment. Update the rt test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Ba

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:814 (CoverageTracePC | CoverageTracePCGuard | CoverageInline8bitCounters | - CoverageInlineBoolFlag)) + CoverageInlineBoolFlag | CoverageControlFlow)) CoverageFeatures |=

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 459201. Navidem added a comment. Bring back the runtime test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/includ

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem marked an inline comment as done and an inline comment as not done. Navidem added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:807 << "-fsanitize-coverage=[func|bb|edge]" -<< "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc]

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 459157. Navidem added a comment. Update doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basic/Code

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 458958. Navidem added a comment. Add __sanitizer_cov_cfs_init Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/includ

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 458321. Navidem added a comment. Apply comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basic

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem updated this revision to Diff 457754. Navidem added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Added an initial run-time test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://revie

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem added inline comments. Comment at: llvm/test/Instrumentation/SanitizerCoverage/control-flow.ll:2 +; Test -sanitizer-coverage-control-flow +; RUN: opt < %s -passes='module(sancov-module)' -sanitizer-coverage-level=3 -sanitizer-coverage-control-flow -S | FileCheck %s + ---

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1055 + for (auto &BB: F) { +// blockaddress may not be used on function's entry block. +if (&BB == &F.getEntryBlock()) Navidem wrote: > kcc wrote: > > vi

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem updated this revision to Diff 457734. Navidem added a comment. Herald added subscribers: cfe-commits, ormris, MaskRay. Herald added a project: clang. Updated docs, lit test, and added clang option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or