[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

chapuni added a comment. Would this cause many warnings in Clang/LLVM tree? https://lab.llvm.org/buildbot/#/builders/36/builds/36560 I hope you to fix possible warnings at first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://re

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this due to circular deps. `clangAnalysis` should not depend on `clangSema`. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.

[PATCH] D151183: [clang][dataflow] Add a `ControlFlowContext::build()` overload taking a `FunctionDecl`.

chapuni added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:71 - auto CFCtx = llvm::cantFail( - ControlFlowContext::build(*Func, *Body, AST->getASTContext())); This was the only user of Body in -As

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni added a comment. Please come in; https://discourse.llvm.org/t/rfc-let-mvt-generated-and-restore-mvt-into-llvm-codegen/69547/3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767 _

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni added a comment. In D148767#4312692 , @barannikov88 wrote: > Sorry, I don't follow. They may theoretically depend on anything. Why > CodeGen/CodeGenTypes, specifically? > If they don't require it, why add it? I added deps pessimistically, "This

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d71ec6e448f: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfeba5b12b6: Restore CodeGen/LowLevelType from `Support` (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni updated this revision to Diff 518722. chapuni edited the summary of this revision. chapuni added a comment. - Updat the desc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files: clang/lib/Code

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni updated this revision to Diff 518713. chapuni retitled this revision from "Restore CodeGen/LowLevelType" to "Restore CodeGen/LowLevelType from `Support`". chapuni edited the summary of this revision. chapuni added a comment. - Rebase and update the desc Repository: rG LLVM Github Mono

[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni added a comment. In D148767#4311529 , @MaskRay wrote: > Add some information why this is restored? Assume that people may not read > the depended patches (`Depends on D145937, D146352, and D148768.`). Yes sure. This was just an isolated diff wit

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

chapuni added a comment. I am afraid this would be incompatible to bazel due to deep symlinks for sandbox. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149187/new/ https://reviews.llvm.org/D149187 ___

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni updated this revision to Diff 518146. chapuni added a comment. - Add comment lines to LLVMCodeGenTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files: clang/lib/CodeGen/CMakeLists.txt l

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni added a reviewer: dblaikie. chapuni added a subscriber: dblaikie. chapuni added a comment. I am certain this works, though, I would like to ask the 2nd opinion to @dblaikie . In D148769#4297552 , @arsenm wrote: > I feel like this should have doc

[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni updated this revision to Diff 517193. chapuni added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767 Files: clang/lib/CodeGen/CMakeLists.txt llvm/include/llvm/CodeGen/Global

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

chapuni added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:360 endif() if(RISCV IN_LIST LLVM_TARGETS_TO_BUILD) # Generate riscv_vector.h Here Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:5 +#inc

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT/VT

chapuni updated this revision to Diff 516182. chapuni added a comment. Herald added a subscriber: ThomasRaoux. Herald added a reviewer: zuban32. Herald added a reviewer: mpaszkowski. - Rebase and fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni updated this revision to Diff 516177. chapuni retitled this revision from "Restore MVT and LLT into llvm/CodeGen" to "Restore CodeGen/LowLevelType". chapuni edited the summary of this revision. chapuni added a comment. - Split out Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D148767: Restore MVT and LLT into llvm/CodeGen

chapuni updated this revision to Diff 516158. chapuni edited the summary of this revision. chapuni added a comment. Herald added a subscriber: ThomasRaoux. Herald added a reviewer: zuban32. Herald added a reviewer: mpaszkowski. - Update CMake deps - s/LowLevelType/LowLevelTypeUtils/ - modmap: Prun

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

chapuni added a comment. It comes from handling of objlib. 1. Use add_clang_library's DEPENDS It adds deps on both libs. 2. Don't create a custom target. Just add to sources. add_library(HTMLLogger.inc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Diffusion] rG46f5aaa82ca6: [Bazel] Introduce "//clang:bundle_resources" for D146591

chapuni added a comment. I missed the failure since I am using newer version of bazel. BRANCHES main /utils/bazel/llvm-project-overlay/clang/BUILD.bazel:861 It should be moved into "dats" Users: chapuni (Author) https://reviews.llvm.org/rG46f5aaa82ca6 ___

[Diffusion] rG46f5aaa82ca6: [Bazel] Introduce "//clang:bundle_resources" for D146591

chapuni added a subscriber: cfe-commits. chapuni added a comment. Seems this doesn't satisfy buildkite. Could anyone rework? BRANCHES main Users: chapuni (Author) https://reviews.llvm.org/rG46f5aaa82ca6 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT/VT

chapuni created this revision. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, ormris, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, atanasyan, e

[PATCH] D148767: Restore MVT and LLT into llvm/CodeGen

chapuni updated this revision to Diff 515152. chapuni edited the summary of this revision. chapuni added a comment. - Isolate rename changes to D148768 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ htt

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

chapuni added inline comments. Comment at: clang/test/Modules/gmodules-preferred-name-alias.cpp:6 +// RUN: -fmodules -mllvm -debug-only=pchcontainer -x c++ \ +// RUN: -I %S/Inputs %s &> %t.ll +// RUN: cat %t.ll | FileCheck %s I guess it made difficult to

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. This is an obvious fix and builds are still broken. Go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing l

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. FYI it's netter to mention diff id like D145803 rather than commit hash, as far as is is based on the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni accepted this revision. chapuni added a comment. This revision is now accepted and ready to land. It's obvious. I think it was bad just to swallow stderr there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

chapuni added a comment. Excuse me, I have reverted 79a3803bb2cc , D137534 and this. See also https://lab.llvm.org/buildbot/#/builders/239/builds/922 I guess `P1689Deps` would not be thread-s

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

chapuni added a comment. The test `sanitize-metadata-ignorelist.c` fails in -Asserts. Comment at: clang/test/CodeGen/sanitize-metadata-ignorelist.c:11 +// ALLOW-SAME: () local_unnamed_addr #[[ATTR0:[0-9]+]] !pcsections !5 { +// ALLOW-NEXT: entry: +// ALLOW-NEXT:[[TMP0:%.*]

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

chapuni added a comment. @RKSimon Could you cherry-pick it? https://github.com/chapuni/llvm-project/commit/2c09237d8759bb6b1e99940e78901bde5b2bb98f As a position to reduce overhead in tblgen, I don't agree to move this to LLVMDemangle. LLVMSupport depends on LLVMDemangle. llvm-tblgen depends on

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

chapuni added a comment. This discovers a warning in https://reviews.llvm.org/rGa68d4b11465f5b3326be1dd820f59fac275b7581 I think its checking is valid if size_t is uint32_t (eg. -m32) Could you guys teach me what the right fix for it? I don't know canonical fixes for it. Repository: rG LLVM

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added a comment. Thanks. I have noticed I suggested re-typo. (I didn't amend it since I thought it was obvious) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 ___

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this. Before landing this, could you please fix new warnings in the current codebase, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added inline comments. Comment at: clang/test/Frontend/stack-layout-remark.c:24 +// YAML: Name:StackLayout +// YAML: DebugLoc:{ File: '{{.*}}stack-layout-remark.c', Line: [[# @LINE + 24]], +// YAML: Function:foo chapuni wrote:

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

chapuni added a comment. This failed on some environments. See https://lab.llvm.org/buildbot/#/builders/109/builds/55534 Comment at: clang/test/Frontend/stack-layout-remark.c:24 +// YAML: Name:StackLayout +// YAML: DebugLoc:{ File: '{{.*}}stack-layout-remar

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

chapuni added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s --check-prefixes=CHECK,CXX

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

chapuni added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1310 +const auto *FD2 = dyn_cast(D2); +assert(IsExpectedEntity(FD1) && FD2 && IsExpectedEntity(FD2) && + "use non-instantiated function declaration for constraints partial " --

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

chapuni added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1789 + auto inserted = ConstructedObjects.insert({Exp, Placeholder.first}); + assert(inserted.second && "Are we visiting the same expression again?"); + if (isa(Exp)) 'i

[PATCH] D134296: [SIE] Always enable the .debug_aranges section when using LTO

chapuni added a comment. A warning can be seen in -Asserts. Comment at: clang/lib/Driver/ToolChains/PS4CPU.cpp:160 const bool IsPS5 = TC.getTriple().isPS5(); assert(IsPS4 || IsPS5); IsPS5 is used only here. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

chapuni added a comment. The fix looks good. Thanks. > Is -DLLVM_ENABLE_ASSERTIONS=ON what you mean by -Asserts? Oh excuse me, "-Asserts" was an ancient term, "w/o assertsions" in the autoconf age. An antonym was "+Asserts". it means `LLVM_ENABLE_ASSERTIONS=ON` Repository: rG LLVM Github Mo

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

chapuni added a comment. The test fails for -Asserts. Comment at: clang/test/CodeGenHLSL/float3.hlsl:4 +// Make sure float3 is not changed into float4. +// CHECK:<3 x float> @"?foo@@YAT?$__vector@M$02@__clang@@T12@@Z"(<3 x float> noundef %a) +// CHECK:%[[A_ADDR:.+]] = alloca <

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

chapuni added a comment. A few variables cause warinings in -Asserts. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:216 + assert(FuncDecl != nullptr); + const auto *Body = FuncDecl->getBody(); + assert(Body != nullptr); It is used only

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

chapuni added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index == FDSz && It causes a warning

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

chapuni added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:170 + ppc_wrappers/immintrin.h + ppc_wrappers/tmmintrin.h + ppc_wrappers/x86intrin.h It doesn't contain , forgot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

chapuni added inline comments. Herald added subscribers: kosarev, mattd, asavonic, sstefan1, MaskRay. Herald added a project: All. Comment at: clang/lib/Headers/CMakeLists.txt:145 set(openmp_wrapper_files openmp_wrappers/math.h It doesn't contain , intentio

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

chapuni added inline comments. Comment at: clang/test/Modules/gmodules-deduction-guide.cpp:3 +// RUN: -o %t.pch %S/Inputs/gmodules-deduction-guide.h \ +// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll +// RUN: cat %t-pch.ll | FileCheck %s FYI, it is unavai

[PATCH] D109977: LLVM Driver Multicall tool

chapuni added a comment. An interesting improvement. Thanks. Comment at: llvm/cmake/modules/AddLLVM.cmake:890 +configure_file( + ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in + ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp) Do you have a plan

[PATCH] D16761: clang-cl: Support loading plugins on Windows

chapuni added a comment. @v.g.vassilev, I couldn't explain what it caused. Fell free to recommit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16761/new/ https://reviews.llvm.org/D16761 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER)

chapuni added a comment. @krasimir, I concluded it is trivial and committed it with the URL to close this. Feel free to revert if you had any matters. Repository: rL LLVM https://reviews.llvm.org/D35541 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER)

This revision was automatically updated to reflect the committed changes. Closed by commit rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_… (authored by chapuni). Repository: rL LLVM https://reviews.llvm.org/D35541 Files: cfe/trunk/include/clang/Config/config.h.cmake cfe/trunk/lib/

[PATCH] D39037: check-libcxx: Introduce config.test_retry_attempts for std/thread.

chapuni created this revision. I thought we could mark entire tests in std/thread as flaky. Repository: rL LLVM https://reviews.llvm.org/D39037 Files: libcxx/trunk/test/std/thread/lit.local.cfg libcxx/trunk/utils/libcxx/test/format.py Index: libcxx/trunk/utils/libcxx/test/format.py ===

[PATCH] D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer.

chapuni added subscribers: EricWF, chapuni. chapuni added a comment. Excuse me, I have reverted it in https://reviews.llvm.org/rL315806. check-libcxx dislikes it. See also; http://bb9.pgr.jp/#/builders/20/builds/111 Repository: rL LLVM https://reviews.llvm.org/D38678

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

chapuni added inline comments. Comment at: cfe/trunk/lib/Basic/TargetInfo.cpp:351 +LangAS::ID TargetInfo::getOpenCLTypeAddrSpace(const Type *T) const { + auto BT = dyn_cast(T); Excuse me for old commit, I think it might be layering violation. Could we avoid us

[PATCH] D38627: [clangd] Added move-only function helpers.

chapuni added a comment. Excuse me, Ubuntu 14.04's g++-4.8.4 doesn't compile it. :( Any idea? In file included from clang-tools-extra/clangd/ClangdServer.h:23:0, from clang-tools-extra/clangd/ClangdServer.cpp:10: clang-tools-extra/clangd/Function.h: In instantiation of ‘Ret

[PATCH] D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header.

chapuni added a comment. Appeased in https://reviews.llvm.org/rL314586. I don't think my tweak would be right, though. See; http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/6726 http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5135

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

chapuni added a comment. Fixed in https://reviews.llvm.org/rL313456. Comment at: include/llvm/IR/DiagnosticHandler.h:12 +//===--===// + +#include "llvm/ADT/StringRef.h" Did you forget include g

[PATCH] D35038: [libunwind] Add a test harness

chapuni added inline comments. Comment at: test/CMakeLists.txt:34 + ${CMAKE_CURRENT_BINARY_DIR} + DEPENDS ${LIBUNWIND_TEST_DEPS} + ) Could you fill this, please? set(LIBUNWIND_TEST_DEPS unwind ) It makes "check-unwind" pass from clean. https://re

[PATCH] D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES

chapuni added a comment. @jroelofs Please do. libunwind emits unique module caches. module.cache/1JROMJZVPMD3F/std-WU7UZNPX10U5.pcm module.cache/1JROMJZVPMD3F/std_config-WU7UZNPX10U5.pcm module.cache/1JROMJZVPMD3F/_Builtin_stddef_max_align_t-1P37D07AX0QU6.pcm They are not used outside the

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this in https://reviews.llvm.org/rL310030 to unbreak -fmodules. See GlobalModuleIndex.cpp. It seeks the suffix ".pcm". https://reviews.llvm.org/D36238 ___

[PATCH] D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES

This revision was automatically updated to reflect the committed changes. Closed by commit rL309551: libcxxabi: Suppress LLVM_ENABLE_MODULES (authored by chapuni). Repository: rL LLVM https://reviews.llvm.org/D35542 Files: libcxxabi/trunk/CMakeLists.txt Index: libcxxabi/trunk/CMakeLists.t

[PATCH] D35776: clang/Basic/TargetInfo.h: Sink llvm/IR/DataLayout.h into implementations.

chapuni created this revision. Herald added a subscriber: nhaehnle. It loosens dependencies of Clang_Basic from LLVM_intrinsic. Repository: rL LLVM https://reviews.llvm.org/D35776 Files: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/AST/Mangle.cpp cfe/trunk/lib/Basic/TargetI

[PATCH] D35559: [CMake][Modules] Tweak Modules-unfriendly builds

chapuni created this revision. Herald added a subscriber: mgorny. I can commit changes partially. - Add -fmodules-ignore-macro (llvm-config, libclang) Their -DMACROs don't change headers' behavior. Just let them ignored. - Unittests They use -frtti. I thought they may be built w/o modules. Any

[PATCH] D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES

chapuni created this revision. Herald added a subscriber: mgorny. It's copypasto from libcxx. There's no serious issue. I'd like just to keep module.cache clean for in-tree libcxx builds. Repository: rL LLVM https://reviews.llvm.org/D35542 Files: libcxxabi/trunk/CMakeLists.txt Index: li

[PATCH] D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER)

chapuni created this revision. Herald added a subscriber: mgorny. It'd be better that they are #cmakedefine01 rather than #cmakedefine. (#if FOO rather than #if defined(FOO)) Then we can find missing #include "clang/Config/config.h" in the future. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D35527: [CMake] Move CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) into clang/Config/config.h.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308277: [CMake] Move CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) into… (authored by chapuni). Repository: rL LLVM https://reviews.llvm.org/D35527 Files: cfe/trunk/CMakeLists.txt cfe/trunk/i

[PATCH] D35527: [CMake] Move CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) into clang/Config/config.h.

chapuni created this revision. Herald added a subscriber: mgorny. LLVM_ENABLE_MODULES is sensitive of -D. Move them into config.h. FIXME: It'd be better that they are #cmakedefine01 rather than #cmakedefine. (#if FOO rather than #if defined(FOO)) Then we can find missing #include "clang/Config/co

[PATCH] D35427: [clang] Fix handling of "%zd" format specifier

chapuni added inline comments. Comment at: cfe/trunk/test/FixIt/format.m:240 + int x; + printf("%zn", &x); // expected-warning{{format specifies type 'ssize_t *' (aka 'long *') but the argument has type 'int *'}} + // PrintfSpecifier::fixType doesn't handle %n, so a fix-it is

[PATCH] D33681: [OpenCL] Allow function declaration with empty argument list.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Reverted in https://reviews.llvm.org/rL306660. See also; http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/4926 https://reviews.llvm.org/D33681 ___

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

chapuni added inline comments. Comment at: cfe/trunk/include/clang/Frontend/DiagnosticRenderer.h:131 /// \param FixItHints The FixIt hints active for this diagnostic. /// \param SM The SourceManager; will be null if the diagnostic came from the ///frontend, thus

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. @Serge_Preis @arphaman Thanks! https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Diffusion] rL306364: [CodeGen][ObjC] Fix GNU's encoding of bit-field ivars.

chapuni added subscribers: cfe-commits, chapuni. chapuni added a comment. Could you confirm if my change were reasonable? Or rewrite it. /cfe/trunk/test/CodeGenObjC/ivar-type-encoding.m:51 It was incompatible to -m32. @9 = private unnamed_addr constant [6 x i8] c"b96c1\00", align 1 Tweaked i

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. In https://reviews.llvm.org/D32439#790302, @Serge_Preis wrote: > Thank you for clarifications, would you explain how may I reproduce failure > locally or remotely. I'd like to see c-index-test output before clang-check > to understand what's going on. Just change LLVM

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. In https://reviews.llvm.org/D32439#790248, @Serge_Preis wrote: > Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't > knwo what this configuration mean) - I tested on Linux that I have at my > disposal and tesing passes. It's cross-compiling.

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

chapuni added a comment. I don't think this would be ready to land. https://reviews.llvm.org/D32595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

chapuni added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp:123 + TmpDirs.push_back(TmpDir1.str()); + if (TmpDir2 != TmpDir2) +TmpDirs.push_back(TmpDir2.str()); Did you mean, "TmpDir1 != TmpDir2" ? Fixed in r304067.

[PATCH] D33284: [CodeGen] Propagate LValueBaseInfo instead of AlignmentSource

chapuni added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenFunction.h:3756 /// /// \param Source - If non-null, this will be initialized with /// information about the source of the alignment. Note that this Could you update this? See als

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

chapuni added a comment. Let me know steps for testing that you suppose. I guess; - Use installed version of lit via virtualenv. - Use out-of-tree version of gtest. - Use another build tree to use FileCheck &c. I know the clause CLANG_BUILT_STANDALONE would be made simpler if we could abandon t

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

chapuni added a comment. Does it work for targeting msvc? See also; http://bb.pgr.jp/builders/test-clang-tools-msc-x64-on-i686-linux-RA/builds/1043 Appeased in r300545. Would it be happier if it worked with "-target x86_64-win32"? Repository: rL LLVM https://reviews.llvm.org/D31757

[PATCH] D29877: Warn about unused static file scope function template declarations.

chapuni added a comment. I think yes, you may do. Warnings fix may be trivial as far as they are NFC. It'd be fine that clang tree should be free from warnings with just-built clang. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-

[PATCH] D29877: Warn about unused static file scope function template declarations.

chapuni added a comment. This brought warnings in llvm tree. Could you take a look, please? http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/14936 (w/o asserts) llvm/include/llvm/ADT/PointerUnion.h:193:13: warning: unused function 'operator==' [-Wunused-function] llvm/include/llvm

[PATCH] D30777: Added `applyAtomicChanges` function.

chapuni added inline comments. Comment at: cfe/trunk/include/clang/Tooling/Refactoring/AtomicChange.h:19 #include "clang/Basic/SourceManager.h" +#include "clang/Format/Format.h" #include "clang/Tooling/Core/Replacement.h" It requires clangFormat in LINK_LIBS. F

[PATCH] D28320: [Driver] Driver changes to support CUDA compilation on Windows.

chapuni added a comment. It fails with LLVM_DEFAULT_TARGET_TRIPLE=i686-pc-win32, on linux. http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/33445 Seems it assumes Windows' layout even if the host is not Windows. 128838 stat64("/path/to/llvm-project/clang/test/Driver/Inputs/CUDA/Progra

[Diffusion] rL290025: [libclang] Remove the 'extern "C"' blocks from the implementation files.

chapuni added subscribers: cfe-commits, chapuni. chapuni added a comment. See r290113. I saw linker error on mingw dll build. Cannot export clang_findIncludesInFileWithBlock: symbol not defined Cannot export clang_findReferencesInFileWithBlock: symbol not defined Cannot export clang_visitC