This revision was automatically updated to reflect the committed changes.
Closed by commit rL312865: [Basic] Update CMakeLists.txt to handle repo
(authored by MinSeongKIM).
Changed prior to commit:
https://reviews.llvm.org/D35533?vs=114160&id=114488#toc
Repository:
rL LLVM
https://reviews.l
minseong.kim updated this revision to Diff 114160.
minseong.kim marked 3 inline comments as done.
minseong.kim added a comment.
Re-uploading the patch, removing debug messages accidentally included in the
patch.
https://reviews.llvm.org/D35533
Files:
lib/Basic/CMakeLists.txt
Index: lib/Bas
minseong.kim updated this revision to Diff 114115.
minseong.kim edited the summary of this revision.
minseong.kim added a reviewer: hintonda.
minseong.kim removed a subscriber: hintonda.
minseong.kim added a comment.
I have updated the diff.
https://reviews.llvm.org/D35533
Files:
lib/Basic/CM
minseong.kim added a comment.
@hintonda, Absolutely. Incorporating @modocache's module changes into the
version in AddLLVM.cmake would solve the current version display issue for repo
and do not affect the process of other version control systems (e.g. git,
git-svn, svn, and git submodule).
h
minseong.kim added a comment.
Hi~ @hintonda,
Using using find_first_existing_file in ADDLLVM.cmake solves the cases with
repo in conjunction with https://reviews.llvm.org/D35532. However, I am not
sure it can handle @modocache's git submodule cases
(https://reviews.llvm.org/D34955).
@modocach
minseong.kim added a comment.
I have updated the description with a hope for it to be more descriptive.
Kindly ping~
https://reviews.llvm.org/D35533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
minseong.kim added a comment.
I will test your patch with repo. Thanks for your time and efforts, @hintonda.
https://reviews.llvm.org/D35533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
minseong.kim added a comment.
kindly ping~
https://reviews.llvm.org/D35533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
minseong.kim added a comment.
Thanks @jordan_rose @modocache @hintonda for your time and efforts.
This patch does regenerate the version control info correctly (SVNVersion.inc)
every time I re-make clang. Probably I am missing something here.
Could you please be more specific and share your ide
minseong.kim added a comment.
Thanks for the reviewing this patch. Please correct if I am wrong.
The addition of "${path}/.git/HEAD" at line 37 is used only once when repo is
initially synced "for the first time". This is because ${git_path}/logs/HEAD
file at line 34 for Git or Git submodule do
minseong.kim created this revision.
Herald added a subscriber: mgorny.
When repo is used, '--version' option does not display correct version
information (i.e. Git hashes). This change makes the parsing of the
version info correctly recognise svn, git, git-svn and repo. This
in turn enables the op
11 matches
Mail list logo
