[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

Dor1s added a comment. If we still decide to proceed with this, would it make sense to expand it to `sanitizer_coverage` based on any sancov instrumentation being enabled? As you mentioned in the description, there might be users who manually enable certain sancov flags. I think it's good to be

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

Dor1s added a comment. What usecase(s) do you have for this in mind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

This revision was automatically updated to reflect the committed changes. Dor1s marked an inline comment as done. Closed by commit rC352890: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections. (authored by Dor1s, committed by ). Changed prior to commit: https://revie

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s marked 2 inline comments as done. Dor1s added inline comments. Comment at: docs/SanitizerCoverage.rst:149 +(``-Wl,-gc-sections``), thus resulting in a significant binary size overhead. +See `Bug 34636 `_ for more info. +

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s updated this revision to Diff 184766. Dor1s added a comment. Herald added a project: clang. Clarify that only linkers other than LLD are affected. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 Files: docs/Saniti

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s added a comment. I'm not sure if I wrote down the information correctly, PTAL :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57474/new/ https://reviews.llvm.org/D57474 ___ cfe-commits mailing list cfe-commits

[PATCH] D57474: Update SanitizerCoverage doc regarding the issue with pc-table and gc-sections.

Dor1s created this revision. Dor1s added a reviewer: morehouse. Herald added a subscriber: cfe-commits. There is a bug for this: https://bugs.llvm.org/show_bug.cgi?id=34636 But it would be also helpful to leave a note in the docs to prevent users from running into issues, e.g. https://crbug.com/92

[PATCH] D55066: [ASan] Minor documentation fix: clarify static linking limitation.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348863: [ASan] Minor documentation fix: clarify static linking limitation. (authored by Dor1s, committed by ). Changed prior to commit: https://reviews.llvm.org/D55066?vs=176712&id=177724#toc Repositor

[PATCH] D55066: [ASan] Minor documentation fix: clarify static linking limitation.

Dor1s added a comment. Thanks @eugenis for explaining the issue to me over chat. I've updated the CL and the description. I can abandon it though, if you find it useless. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

Dor1s updated this revision to Diff 176712. Dor1s added a comment. Restore the message with a couple clarifying words. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 Files: docs/AddressSanitizer.rst Index: docs/Addre

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

Dor1s added a comment. In D55066#1315365 , @eugenis wrote: > Sorry for the delay. > This is wrong, static linking is NOT supported. > You could be confusing it with static linking of asan runtime library to an > executable - that is and has always been

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

Dor1s added a comment. PTAL, it's a single line change, I just need someone to confirm that I'm not mistaken :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commi

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

Dor1s created this revision. Dor1s added reviewers: eugenis, kcc. Herald added a subscriber: cfe-commits. Looks like the documentation is out of date, given that static linking is not only supported these days, but is actually a default mode. Repository: rC Clang https://reviews.llvm.org/D550

[PATCH] D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960

This revision was automatically updated to reflect the committed changes. Closed by commit rC329223: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960 (authored by Dor1s, committed by ). Changed prior to commit: https://reviews.llvm.org/D45178?vs=141026&id=141027#toc Rep

[PATCH] D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960

Dor1s updated this revision to Diff 141026. Dor1s added a comment. Resolve merge conflicts and fix whitespaces. Repository: rC Clang https://reviews.llvm.org/D45178 Files: lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index: unittests/Basic/VirtualFileSystem

[PATCH] D45178: Fixes errors caused by https://reviews.llvm.org/D44960

Dor1s added a comment. Thanks a lot, Vedant! No worries, I'll commit it on behalf of Yuke @liaoyuke Repository: rC Clang https://reviews.llvm.org/D45178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D45178: Fixes errors caused by https://reviews.llvm.org/D44960

Dor1s added a comment. Friendly ping. We'll probably land it tomorrow anyway, as it blocks another fix needed for llvm-cov, but having another pair of eyes to look at this would be still helpful :) Repository: rC Clang https://reviews.llvm.org/D45178 _

[PATCH] D45178: Fixes errors caused by https://reviews.llvm.org/D44960

Dor1s accepted this revision. Dor1s added a comment. This revision is now accepted and ready to land. Looks good from my perspective, added Peter and Zachary who might know this code better :) Repository: rC Clang https://reviews.llvm.org/D45178 ___