[PATCH] D69498: IR: Invert convergent attribute handling

2019-10-29 Thread Marcello Maggioni via Phabricator via cfe-commits
kariddi added a comment. In D69498#1725528 , @rjmccall wrote: > It absolutely makes sense for Clang as a GPU-programming frontend to set > attributes appropriately when targeting the GPU. I'm objecting to making > "convergence" and related "code layout

[PATCH] D69498: IR: Invert convergent attribute handling

2019-10-28 Thread Marcello Maggioni via Phabricator via cfe-commits
kariddi added a comment. One thing to probably note is that its not only a "target specific" issue, but a language specific issue as well (IMHO). OpenCL, CUDA, SYCL are all languages (to name a few) that have a concept of "convergence" and its not related only to the fact that they mostly run o