[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito updated this revision to Diff 556416. ManuelJBrito removed a reviewer: libc++abi. ManuelJBrito added a comment. This revision is now accepted and ready to land. Remove changes to demangle test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito planned changes to this revision. ManuelJBrito added a comment. Hello @aqjune thanks for the comments !! Some users of SimplifyDemandedVectorElts might need some more tweaking to prevent regressions for the cases you noted. I'll work on this as soon as I can! Repository: rG LLVM

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added a comment. Herald added a subscriber: wangpc. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152658/new/ https://reviews.llvm.org/D152658 ___ cfe-commits mailing list cfe-commit

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152658/new/ https://reviews.llvm.org/D152658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

This revision was automatically updated to reflect the committed changes. Closed by commit rG36d50348a8b1: [clang][NFC] Drop alignment in builtin-nondeterministic-value test (authored by ManuelJBrito). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added inline comments. Comment at: llvm/lib/Target/X86/X86InstCombineIntrinsic.cpp:3102-3105 case Intrinsic::x86_sse4a_extrqi: case Intrinsic::x86_sse4a_insertq: case Intrinsic::x86_sse4a_insertqi: +PoisonElts.setHighBits(VWidth / 2); nl

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. In D142388#4425246 , @aaron.ballman wrote: > In D142388#4415349 , @rsmith wrote: > >> I think `__builtin_any_value` works pretty well, and emphasizes that this >> can really return

[PATCH] D149548: [IR] Update to use new shufflevector semantics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22f5dc7501b5: [IR] Update to use new shufflevector semantics (authored by ManuelJBrito). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added a comment. In D149548#4413762 , @uweigand wrote: > In D149548#4413639 , @nlopes wrote: > >> If a vector is fully initialized with `insertvector` (i.e., one operation >> per index), then the val

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

ManuelJBrito updated this revision to Diff 530321. ManuelJBrito added a comment. Completely drop alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152547/new/ https://reviews.llvm.org/D152547 Files: clang/test/CodeGen/builtins-nondetermin

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added a comment. In D149548#4405173 , @qiucf wrote: > Why this changes IR output of following case? > > // RUN: clang vecpromote.c -S -o - -O0 -target s390x-linux-gnu -fzvector > -emit-llvm > #include > > vector int si; > int g;

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

ManuelJBrito created this revision. ManuelJBrito added reviewers: zixuan-wu, erichkeane. Herald added a subscriber: mgrang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Drop alignment to allow te

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added inline comments. Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:26 +// CHECK-LABEL: entry +// CHECK: [[A:%.*]] = alloca double, align 8 +// CHECK: store double [[X:%.*]], ptr [[A]], align 8 zixuan-wu wrote: > hi, @ManuelJBrito

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added reviewers: qiucf, lkail, shchenz. ManuelJBrito added a comment. Adding some PowerPC folks to review the change in codegen for vec_promote. AFAICT its OK to have the undefined values be poison. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added a reviewer: nemanjai. ManuelJBrito added a comment. Hello Nemanja is the change codegen for vec_promote OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149548/new/ https://reviews.llvm.org/D149548

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito updated this revision to Diff 518434. ManuelJBrito added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is visible in clang in particular in codegen for the vec_promote builtin. It now produces poison instead of undef for the undefined e

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b56da5e9f3b: [IR] Change shufflevector undef mask to poison (authored by ManuelJBrito). Changed prior to commit: https://reviews.llvm.org/D149210

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito updated this revision to Diff 517150. ManuelJBrito added a comment. Split patch into print update and internal representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149210/new/ https://reviews.llvm.org/D149210 Files: clang/t

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito added a comment. In D149210#4298124 , @nikic wrote: > Could you please split the change to printing + the test updates from all the > other changes? The code changes get lost in the large diff. Yes, that makes sense. The internal representa

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito created this revision. ManuelJBrito added reviewers: aqjune, efriedma, RKSimon, nikic, nlopes, spatel. Herald added a reviewer: deadalnix. Herald added subscribers: luke, kosarev, StephenFan, frasercrmck, okura, kuter, lebedev.ri, kerbowa, luismarques, apazos, sameer.abuasal, pengfei,

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5184dc2d7cce: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value (authored by ManuelJBrito). Changed prior to commit:

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. Thanks for the review! I'll simplify the masks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 ___ cfe-commits mailing list cfe-c

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. Any further comments @RKSimon ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.org/D143287 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 511663. ManuelJBrito added a comment. Update to remove multiple uses of freeze poison. I am unsure about the code style used in the 128 to 512 casts. Any comments are appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito planned changes to this revision. ManuelJBrito added a comment. Implementing the 128 to 512 casts by filling the rest of the vector with the same definition of a nondeterministic_value is not correct because : a = freeze poison v = is not the same as v = freeze poison The only

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. Reverted. I'll reassess what can be done here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://reviews.llvm.org/D144903 ___ cfe-commits mailing list cfe-co

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 503819. ManuelJBrito added a comment. Rebase `avx-cast-builtins.c` was moved to D144903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.or

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2817933fdd4: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS (authored by ManuelJBrito). Changed prior to commit: https:/

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4179020 , @aqjune wrote: > H, is D104790 superseded by this patch? I don't think so we still need to fix the undefined intrinsics, right? Maybe I'm not understanding the questio

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. It seems the build failure was caused by a known crash https://github.com/llvm/llvm-project/issues/55263. I tried to find some workaround but unsuccessfully. So I'm thinking I can drop the end-to-end tests for now and commit them when the crash is fixed and for n

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. I originally reverted it because of the wrong tag, but there were also some buildbot failures (see https://lab.llvm.org/buildbot/#/builders/139/builds/36736). It appears to be failing an assert in DiagnosticsEngine::DiagStateMap::append, but i'm not very familiar w

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito updated this revision to Diff 501079. ManuelJBrito added a comment. Recover mistakenly drop flag in avx-cast-builtins. I was experimenting and forgot i had removed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://r

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito created this revision. ManuelJBrito added a reviewer: RKSimon. Herald added subscribers: pengfei, hiraditya. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Ignoring f

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 500149. ManuelJBrito added a comment. Update tests after D143593 . There are some performance regressions with casts from 128 to 512. The backend inserts vinsertf instructions. So that as to be fixed. In D130339

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 496129. ManuelJBrito retitled this revision from "[Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value" to "[Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value". ManuelJBrito added a comment. Match

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 495611. ManuelJBrito added a comment. Add end to end tests Currrently these expect a mov that will be removed when the instcombine bug is fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ h

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4108165 , @craig.topper wrote: > In D143287#4107439 , @ManuelJBrito > wrote: > >> In D143287#4103597 , @craig.topper >> wrote:

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4104056 , @RKSimon wrote: > What do we gain from using __builtin_nondeterministic_value instead of just > setzero? https://godbolt.org/z/zrb6858Mr __builtin_nondeterministic_value is lowered to freeze(poison) Th

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4103597 , @craig.topper wrote: > We have a couple bugs that show (freeze (poison)) doesn't work past > SelectionDAG. Is that a concern here? The most recent > https://github.com/llvm/llvm-project/issues/60429 I

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito created this revision. ManuelJBrito added reviewers: craig.topper, RKSimon. Herald added subscribers: pengfei, mgrang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following intr

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG450a4612c39c: [Clang] Add builtin_nondeterministic_value (authored by ManuelJBrito). Changed prior to commit: https://reviews.llvm.org/D142388?vs=

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 494338. ManuelJBrito added a comment. Fix vector tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/docs/LanguageExtensions.rst clang/docs/Re

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. So this is getting some build failures: - https://lab.llvm.org/buildbot#builders/38/builds/9446 - https://lab.llvm.org/buildbot#builders/245/builds/4189 - https://lab.llvm.org/buildbot#builders/65/builds/7949 - https://lab.llvm.org/buildbot#builders/188/builds/25538

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. Thank you all for the reviews and helping me see this patch through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 ___ cfe-commi

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1832a5c801: [Clang] Add builtin_nondeterministic_value (authored by ManuelJBrito). Changed prior to commit: https://reviews.llvm.org/D142388?vs=

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 494024. ManuelJBrito added a comment. - set Invalid in type checking - add builtin documentation - add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. Can the release note and documentation update be part of this patch or should i create a new one ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 __

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 493984. ManuelJBrito added a comment. - Restrict builtin to base types and vectors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/include/clang/B

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3070 + +if(Ty->isStructTy()){ + Address StructAddr = ReturnValue.getValue(); erichkeane wrote: > This gets REALLY complicated, you can't just create a store, this might end

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 493904. ManuelJBrito retitled this revision from "[clang] Add builtin_nondet" to "[clang] Add builtin_nondeterministic_value". ManuelJBrito edited the summary of this revision. ManuelJBrito added a comment. Herald added a subscriber: mgrang. - Change nam

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito updated this revision to Diff 491783. ManuelJBrito added a comment. fixed diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/include/clang/Basic/Builtins.def clang/include/

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito added a comment. Oops wrong diff, i'll update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito updated this revision to Diff 491767. ManuelJBrito added a comment. Add tests with bool and bool-vector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 Files: clang/test/CodeGen/builtins-no

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") erichkeane wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > shaf

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito created this revision. ManuelJBrito added reviewers: aaron.ballman, erichkeane, shafik. ManuelJBrito added a project: clang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a subscriber: cfe-commits. This patch adds a builtin that returns a no

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140538/new/ https://reviews.llvm.org/D140538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito updated this revision to Diff 485072. ManuelJBrito added a comment. Fix demangle test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140538/new/ https://reviews.llvm.org/D140538 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito added a comment. A 2022-12-22 10:51, Nuno Lopes via Phabricator escreveu: > nlopes accepted this revision. > nlopes added a comment. > > LGTM, thank you! > > Repository: > > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > > https://reviews.llvm.org/D140538/new/ > > https:

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. ManuelJBrito added a project: clang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a project: libc++abi. Herald added a revie

[PATCH] D140090: [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG84b4ff24e94b: [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC] (authored by ManuelJBrito). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D140090: [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC]

ManuelJBrito created this revision. ManuelJBrito added reviewers: peterwaller-arm, paulwalker-arm, david-arm. Herald added subscribers: ctetreau, arphaman, kristof.beyls. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999

[PATCH] D139745: [Clang]Use poison instead of undef where its used as placeholder[NFC]

ManuelJBrito updated this revision to Diff 481908. ManuelJBrito retitled this revision from "Use poison instead of undef where its used as placeholder[NFC]" to "[Clang]Use poison instead of undef where its used as placeholder[NFC]". ManuelJBrito added a comment. Splitting the diff Repository:

[PATCH] D139745: Use poison instead of undef where its used as placeholder[NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. Herald added subscribers: Enna1, ThomasRaoux, hiraditya. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a reviewer: zuban32. Herald added projects: clang, LLVM. Herald added subscri

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito added a comment. Thanks for the review arsenm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138755/new/ https://reviews.llvm.org/D138755 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito edited reviewers, added: arsenm; removed: yaxunl. ManuelJBrito added a comment. Herald added a subscriber: wdng. Is this change OK? It seems to me that here undef is just a placeholder. Was hoping that some AMDGPU folks could review it. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito added a reviewer: yaxunl. ManuelJBrito added a comment. Couldn't find documentation for this intrinsic, can you shed a light on whether or not this change is OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138755/new/ https://review

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito created this revision. ManuelJBrito added a project: AMDGPU. Herald added subscribers: kosarev, jvesely. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use poison instead of undef when

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. ManuelJBrito added a project: clang. Herald added subscribers: dmgreen, arphaman, kbarton, nemanjai. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a subscriber: cfe-commits. Repla