[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-16 Thread Louis Dionne via cfe-commits
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation { In C++, the order in which global variables are initialized across translation units is unspecified, unlike the ordering within a single translation unit. The ``init_priority`` attribute allows you to specify a relati

[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/123098 >From 05bb2f8554e7dab1e084738155348389284bcc36 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 15 Jan 2025 13:03:04 -0500 Subject: [PATCH 1/2] [clang] Improve the documentation for the init_priority attr

[clang] [clang] Improve the documentation for the init_priority attribute (PR #123098)

2025-01-15 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/123098 The documentation wasn't very clear about whether ordering is controlled within or across TUs, and same for dylibs. Clarify that, and also add mentions for the state of support on Mach-O platforms. >From 05bb2

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2025-01-13 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/105990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2025-01-13 Thread Louis Dionne via cfe-commits
ldionne wrote: Closing as stale, please feel free to reopen if you want to pursue this. https://github.com/llvm/llvm-project/pull/105990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] emit -Wignored-qualifiers diagnostic for cv-qualified base classes (PR #121419)

2025-01-13 Thread Louis Dionne via cfe-commits
ldionne wrote: > > @erichkeane @ldionne should the `libcxx` tests > > ([common_reference.compile.pass.cpp](https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_reference.compile.pass.cpp), > > > > [apply_extended_types.pass.cpp](https

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-08 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/8] [clang][Darwin] Remove legacy framework search path logic in

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/7] [clang][Darwin] Remove legacy framework search path logic in

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, "implicit extern \"C\" semantics; these are assumed to not be " "user-provided and are used to model system and standard headers' " "paths.">; +d

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/6] [clang][Darwin] Remove legacy framework search path logic in

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-01-07 Thread Louis Dionne via cfe-commits
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs llvm::sys::path::append(P, "usr", "include"); addExternCSystemInclude(DriverArgs, CC1Args, P.str()); } + + // Add default framework search paths + auto addFramew

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-19 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120149 >From e578bd75d82a5ff16168222e4f30c32f9aa5e6bd Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 16 Dec 2024 13:28:38 -0500 Subject: [PATCH 1/3] [clang][Darwin] Remove legacy framework search path logic in

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-19 Thread Louis Dionne via cfe-commits
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const llvm::opt::ArgList &DriverArgs llvm::sys::path::append(P, "usr", "include"); addExternCSystemInclude(DriverArgs, CC1Args, P.str()); } + + // Add default framework search paths + auto addFramew

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-19 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-19 Thread Louis Dionne via cfe-commits
@@ -1,13 +1,6 @@ -// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \ -// RUN: -triple nvptx-nvidia-cuda -aux-triple i386-apple-macosx \ -// RUN: -E -fcuda-is-device -v -o /dev/null -x cuda %s 2>&1 | FileCheck %s - -// RUN: %clang -cc1 -isysroot /var/empty \ -// RUN:

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-12-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/3] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/2] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Louis Dionne via cfe-commits
@@ -1,13 +1,6 @@ -// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \ -// RUN: -triple nvptx-nvidia-cuda -aux-triple i386-apple-macosx \ -// RUN: -E -fcuda-is-device -v -o /dev/null -x cuda %s 2>&1 | FileCheck %s - -// RUN: %clang -cc1 -isysroot /var/empty \ -// RUN:

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-12-16 Thread Louis Dionne via cfe-commits
ldionne wrote: Sorry for the spurious request for review here, this is the wrong PR. https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-16 Thread Louis Dionne via cfe-commits
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths( if (triple.isOSDarwin()) { ldionne wrote: I'm trying to revive this as https://github.com/llvm/llvm-project/pull/120149 https://github.com/llvm/llvm-project/pull/118543 _

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #75841)

2024-12-16 Thread Louis Dionne via cfe-commits
ldionne wrote: @brad0 Revived as https://github.com/llvm/llvm-project/pull/120149 https://github.com/llvm/llvm-project/pull/75841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/120149 This removes a long standing piece of technical debt. Most other platforms have moved all their header search path logic to the driver, but Darwin still had some logic for setting framework search paths present

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-16 Thread Louis Dionne via cfe-commits
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths( if (triple.isOSDarwin()) { ldionne wrote: FWIW I agree with your assessment @cyndyishida. I just did the exercise of picking up #75841 and we basically need to pass `-iframework` from the dr

[clang] [Clang][Darwin] Centralize framework search paths for headers & libraries. (PR #118543)

2024-12-16 Thread Louis Dionne via cfe-commits
@@ -150,3 +150,23 @@ clang::parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS, StringRef SDKRootPath) { return llvm::make_error("invalid SDKSettings.json", llvm::inconvertibleErrorCode()); } + +// For certain platforms/environments al

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/test/

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120013 >From 51c5f794e4c3253675f83821fd58bdefdfcf0c67 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/test/

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. LGTM if the CI is green. https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
ldionne wrote: Rebased onto `main` to re-trigger CI, which should solve the errors you were seeing. I don't remember why these `XFAIL`s were added, but if the CI passes with them removed, I'm happy. https://github.com/llvm/llvm-project/pull/120013 _

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/119370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119370 >From 259f1eecac3abf0ffdc5c41ef9edae35c604ee26 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Dec 2024 07:42:00 -0500 Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying to

[clang] [libcxx] [libcxx] Support for using timespec_get (PR #117362)

2024-12-10 Thread Louis Dionne via cfe-commits
ldionne wrote: Gentle ping https://github.com/llvm/llvm-project/pull/117362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libc++abi] Provide an explicit error when trying to build for MSVC (PR #119370)

2024-12-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/119370 >From c9f83596fbfa0423245eecbc9c4d9f65163648f1 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 10 Dec 2024 07:42:00 -0500 Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying to

[clang] [libcxx] [libc++] Rename `__` prefix to `__libcpp_` for locale related functions (PR #119241)

2024-12-09 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. Instead, can't you `#undef` these macros? We're trying to move away from defining names with `__libcpp`. https://github.com/llvm/llvm-project/pull/119241 ___ cfe-commits mailing list c

[clang] [libcxx] [C++20] [Modules] Convert '-fexperimental-modules-reduced-bmi' to '-fmodules-reduced-bmi' (PR #114382)

2024-12-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [C++20] [Modules] Convert '-fexperimental-modules-reduced-bmi' to '-fmodules-reduced-bmi' (PR #114382)

2024-12-06 Thread Louis Dionne via cfe-commits
@@ -172,6 +172,7 @@ def parseScript(test, preamble): f"{compileFlags} " "-Wno-reserved-module-identifier -Wno-reserved-user-defined-literal " "-fmodule-file=std=%T/std.pcm " # The std.compat module imports std. +

[clang] [libcxx] [C++20] [Modules] Convert '-fexperimental-modules-reduced-bmi' to '-fmodules-reduced-bmi' (PR #114382)

2024-12-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne commented: I didn't have time to gather much context around this patch, sorry, I just noticed your question on Discord. https://github.com/llvm/llvm-project/pull/114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libcxx] [C++20] [Modules] Convert '-fexperimental-modules-reduced-bmi' to '-fmodules-reduced-bmi' (PR #114382)

2024-12-06 Thread Louis Dionne via cfe-commits
@@ -188,6 +189,7 @@ def parseScript(test, preamble): "%dbg(MODULE std) %{cxx} %{flags} " f"{compileFlags} " "-Wno-reserved-module-identifier -Wno-reserved-user-defined-literal " +"-fexperimental-modules-reduced-bmi "

[libclc] [libcxx] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-12-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-12-05 Thread Louis Dionne via cfe-commits
ldionne wrote: Since we support only the latest released GCC in the runtimes, so I don't think it makes sense to merge this. Newer GCCs don't seem to have this issue. Closing, please reopen if you'd like to pursue this despite the above information and we can chat. https://github.com/llvm/llv

[libcxx] [libunwind] [llvm] [libc++][libunwind] Fix documentation CI job after #118159 (PR #118555)

2024-12-03 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/118555 None >From b3b1cb221aa7388a3d72f1774c70392042139b04 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 3 Dec 2024 17:06:22 -0500 Subject: [PATCH 1/2] [libc++][libunwind] Fix documentation CI job after #118

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-12-02 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From fbb6db25d2d52b19486c395d0855e7af4b8812a3 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/6] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-11-29 Thread Louis Dionne via cfe-commits
ldionne wrote: Ah, I didn't realize this was only required for much older compilers. In that case, indeed we don't support GCC 8 so we probably don't want to merge this. https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7c156ea8545fd9b5211c488ba5c4386c368d5f82 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/6] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [compiler-rt] [libcxx] [libcxxabi] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 7c156ea8545fd9b5211c488ba5c4386c368d5f82 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/5] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 3db70453e07f1378ed4d07023dc2a6cf2541b935 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-11-28 Thread Louis Dionne via cfe-commits
ldionne wrote: Closing as stale, please reopen if you still want to pursue. https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [libcxx] Support for using timespec_get (PR #117362)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. The libc++ part LGTM. I don't really understand the `Fuchsia-stage2.cmake` changes but I'm not sure I need to. However, please rebase this on top of `main` and make sure that the CI is green before you merge. https://github.com/llvm/llvm-

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __builtin_invoke and detect std::invoke as a builtin (PR #116709)

2024-11-26 Thread Louis Dionne via cfe-commits
ldionne wrote: > > AFAICT we have one test for `invoke` plus a constexpr test which should > really just be rolled into the generic `invoke` test. That test is ~400 LoC, > which is definitely not nothing, but also not unmanageable IMO. We could > probably also simplify that by not explicitly

[clang] [libcxx] [Clang] Add __builtin_invoke and detect std::invoke as a builtin (PR #116709)

2024-11-22 Thread Louis Dionne via cfe-commits
ldionne wrote: > > 1. I'm not convinced the library part is true. The reality is that we support > Clang and GCC, and if they both support the builtins (or provide different > ones for the same feature) we remove our fallback implementations and thus > reducing the complexity for libc++. GCC

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-19 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From e42db172b2397e6358dc60850e4c8b085c6bd4bf Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-07 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/101399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-06 Thread Louis Dionne via cfe-commits
ldionne wrote: > I do care. I sometimes like to compare benchmarks from different iterations. > Currently when I build a benchmark I get a message where the executable is > stored. The new approach makes harder to find the location of the executable. > I wonder whether we can show a message wh

[clang] clang/AMDGPU: Emit grid size builtins with range metadata (PR #113038)

2024-11-05 Thread Louis Dionne via cfe-commits
ldionne wrote: I'm not sure what's special about your usage of Graphite, but I've seen other people use it without triggering these notifications to everyone. This is disruptive: if everyone started doing this, our Github notification system with CODEOWNERS.txt would break down completely beca

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 2e50f00dfc6636abbaf0c8350c6e7c92b7b3dba0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From f19ffaabcf0fdf6fc2dbb02200973418fe32be13 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 504518235aa19ab517b59e41c003b86dc610bbb0 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-05 Thread Louis Dionne via cfe-commits
@@ -230,11 +230,22 @@ else() endif() set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) -set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Supported values are ${LIBCXX_SUP

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-05 Thread Louis Dionne via cfe-commits
@@ -230,11 +230,22 @@ else() endif() set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt libstdc++ libsupc++ vcruntime) -set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++ ABI library to use. Supported values are ${LIBCXX_SUP

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From b52b55d2c25c6b0800c934885d0c6a389145bbf6 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-11-05 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From dd2d2ee9ff54b5263d0f65bcac64407ffb0c9e12 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jul 2024 10:41:10 -0400 Subject: [PATCH] [libc++] Unify the benchmarks with the test suite Instead of bui

[compiler-rt] [libunwind] [llvm] [cmake] Remove obsolete files, docs and CMake variables related to the standalone build (PR #112741)

2024-11-05 Thread Louis Dionne via cfe-commits
ldionne wrote: Both CI failures seem to be unrelated. https://github.com/llvm/llvm-project/pull/112741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-04 Thread Louis Dionne via cfe-commits
ldionne wrote: @petrhosek I'm curious to know what you think of this design. https://github.com/llvm/llvm-project/pull/112978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-04 Thread Louis Dionne via cfe-commits
ldionne wrote: > Looking at our current cmake config, we're using: > > ``` > -DLIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY=ON \ > -DLIBCXX_ENABLE_ABI_LINKER_SCRIPT=ON \ > ``` > > Do I understand correctly that the new replacement for that would be? > > ``` > -DLIBCXX_ABILIB_FOR_SHARED="shared

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-31 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From cff8de9231ad461b82f9522d7a93b73ea0641e52 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/4] [libc++] Make benchmarks forward-compatible with the test su

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-30 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From a50fa3f81b486c949f20c614101a66e38e0f92e6 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/4] [libc++] Make benchmarks forward-compatible with the test su

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread Louis Dionne via cfe-commits
ldionne wrote: FWIW, I didn't mean to derail this effort or create significant additional complexity by saying what I said above. My intention was only to point out the tradeoff of adding new functionality for a temporary benefit, which wasn't clear to me had been thought about in those terms.

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-25 Thread Louis Dionne via cfe-commits
ldionne wrote: Just to clarify, I'm mostly neutral on this. A Clang reviewer should chime in and evaluate the change for what it is. It does simplify the setup of the libc++ test suite for GPU, but it's not required since we have other options to set things up. https://github.com/llvm/llvm-pr

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Louis Dionne via cfe-commits
ldionne wrote: Ack, thanks for the confirmation. > If we wanted to send the report as a comment on GitHub, we can certainly look > into that as mentioned here > https://discourse.llvm.org/t/using-plugins-in-buildkite-ci-that-require-docker/82701/6?u=davidspickett. > The Buildkite specific par

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-10-25 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/108357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Louis Dionne via cfe-commits
ldionne wrote: > The script is already written and works, and there still isn't a concrete > timeline for when we are going to move things over to Github actions. This > solves a valid complaint I hear somewhat often. For libc++ at least, there > are definitely platforms that will not be able

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-24 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From cb6359e96c6fd2c2af90f84c32487977a6e1b819 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/3] [libc++] Make benchmarks forward-compatible with the test su

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Louis Dionne via cfe-commits
ldionne wrote: Trying to understand what this patch does, basically it adds a summary when looking at the results of a BuildKite job? Previously: https://github.com/user-attachments/assets/62dcabf5-414d-4c6b-928d-55df39ca02e0";> After this patch: https://github.com/user-attachments/assets/489b

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 0faad749460f8858b87064f97de62e5029090ac9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/2] [libc++] Make benchmarks forward-compatible with the test su

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++] Unify the benchmarks with the test suite (PR #101399)

2024-10-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/101399 >From 0faad749460f8858b87064f97de62e5029090ac9 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 31 Jul 2024 13:00:25 -0400 Subject: [PATCH 1/2] [libc++] Make benchmarks forward-compatible with the test su

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-10-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 85bac5f281c3d6038eda67eb8c0faf356a51c621 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-10-21 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From a57278b0c6a34dda5b937bae2e37c5c57855ac9a Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/3] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Louis Dionne via cfe-commits
ldionne wrote: Can you explain again why the compiler isn't providing the C library and the start files implicitly by default, just like it does for non-GPU code? https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commi

[libcxx] [libcxxabi] [libunwind] [runtimes] Improve the documentation for LIBCXX_ADDITIONAL_COMPILE_FLAGS (PR #112733)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/112733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Avoid cluttering the top-level build directory with test artifacts (PR #112717)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/112717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libunwind] [llvm] [cmake] Remove obsolete files, docs and CMake variables related to the standalone build (PR #112741)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112741 The runtimes used to support a build mode called the "Standalone build", which isn't supported anymore (and hasn't been for a few years). However, various places in the code still contained stuff whose only pur

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread Louis Dionne via cfe-commits
ldionne wrote: https://github.com/llvm/llvm-project/pull/112733 https://github.com/llvm/llvm-project/pull/112703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Improve the documentation for LIBCXX_ADDITIONAL_COMPILE_FLAGS (PR #112733)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112733 This clarifies how that option is meant to be used to avoid confusion. As a drive-by, also fix an incorrect usage in the recently-added GPU caches. >From 32dbc3a85d37be3b7e7331671d7faa0c47d7ef70 Mon Sep 17 00:0

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread Louis Dionne via cfe-commits
ldionne wrote: This is really tricky, however I believe the current behavior is correct (and in fact it's the only correct way of handling this). The `{LIBCXX,LIBCXXABI,LIBUNWIND}_ADDITIONAL_COMPILE_FLAGS` options expect to be passed something that is already formatted as a CMake list with `;`

[libcxx] [libcxxabi] [libunwind] [runtimes] Avoid cluttering the top-level build directory with test artifacts (PR #112717)

2024-10-17 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/112717 Instead of placing artifacts for testing the runtimes at /test, place those artifacts at //test. This prevents cluttering the build directory with the runtimes' test artifacts for everyone else. As a drive-by,

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-11 Thread Louis Dionne via cfe-commits
ldionne wrote: If other folks get here because of an error like `multiple rules generate lib/SOMETHING.a`, this is the issue (from https://github.com/llvm/llvm-project/pull/80007#issuecomment-2402188675): > > The fix for this is: > > ``` > # On embedded platforms that don't support shared li

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [libcxx] [clang & libcxx] constexpr pointer tagging (DO NOT MERGE) (PR #111861)

2024-10-11 Thread Louis Dionne via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -0,0 +1,517 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

  1   2   3   4   5   6   7   8   9   10   >