lolleko updated this revision to Diff 252159.
lolleko added a comment.
Final Cleanup
Removed markdown linebreak parsing for now.
No I don't have commit rights yet. Feel fre to merge this for me.
Thanks for the thorough review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lolleko updated this revision to Diff 252153.
lolleko added a comment.
typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76094/new/
https://reviews.llvm.org/D76094
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/Hover.h
c
lolleko updated this revision to Diff 252151.
lolleko added a comment.
Final Cleanup
Removed markdown linebreak parsing for now.
No I don't have commit rights yet. Feel fre to merge this for me.
Thanks for the thorough review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lolleko updated this revision to Diff 252006.
lolleko added a comment.
Adressed 2nd Review
The problem with the changes you proposed is that it doesn't handle paragraphs
(\n\n).
I think the conditionals required to make that work wouldn't be much cleaner
than the current solution.
And I do thi
lolleko updated this revision to Diff 251334.
lolleko edited the summary of this revision.
lolleko added a comment.
Addressed review.
Paragraphs (lines separated by a double line break `\n\n`) are currently not
retained. Because the current implementation of markup::Paragraph only appends
a sin
lolleko created this revision.
lolleko added a reviewer: sammccall.
lolleko added a project: clang.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous,
MaskRay, ilya-biryukov.
`convertLineBreaks` retains hard line breaks and removes soft line breaks.
Wether a line break
