laxmansole added a comment.
Ping
https://reviews.llvm.org/D22834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
laxmansole updated this revision to Diff 67597.
laxmansole added a comment.
Added inline attribute to the forward/input iterator __init's.
Thanks @EricWF for suggestion.
https://reviews.llvm.org/D22782
Files:
libcxx/include/string
Index: libcxx/include/string
===
laxmansole added a comment.
Ping
https://reviews.llvm.org/D22782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
laxmansole added a comment.
In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote:
> Do we have a test for the problem that this is solving?
$ cat foo.cpp
int foo(const std::string name);
int main(){
return foo("bar");
}
$clang++ -S -O3 -fno-exceptions foo.cpp
Assembly ou
laxmansole created this revision.
laxmansole added reviewers: mclow.lists, howard.hinnant.
laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
flyingforyou.
Currently basic_string's destructor is not getting inlined. So adding 'inline'
attribute to ~basic_string().
Worked i
