[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-13 Thread Lambert Clara via Phabricator via cfe-commits
belkiss marked an inline comment as done. belkiss added a comment. And thanks @aganea, @hans & @rnk! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews.llvm.org/D116861 ___ cfe-com

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-13 Thread Lambert Clara via Phabricator via cfe-commits
belkiss updated this revision to Diff 399764. belkiss added a comment. Simplify test, remove the inline specific CHECK-NOT since we have the implicit-check-not in FileCheck args checking that no errors have occured in the whole file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-13 Thread Lambert Clara via Phabricator via cfe-commits
belkiss added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/TypeCheck/global-new-alignment.cpp:33 +int main() { + // CHECK-NOT: runtime error: constructor call on misaligned address [[PTR:0x[0-9a-f]*]] for type 'Param', which requires 16 byte alignment + Param

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-08 Thread Lambert Clara via Phabricator via cfe-commits
belkiss updated this revision to Diff 398369. belkiss added a comment. Use static_cast/reinterpret_cast instead of C-casts This will also retry the CI, apparently fuzzer-finalstats.test is flaky Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/n

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-08 Thread Lambert Clara via Phabricator via cfe-commits
belkiss updated this revision to Diff 398351. belkiss added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews.llvm.org/D116861 Files: clang/lib/CodeGen/CGExprCXX.cpp compiler-rt/test/ubsan/TestCa

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-08 Thread Lambert Clara via Phabricator via cfe-commits
belkiss updated this revision to Diff 398350. belkiss added a comment. Squash commits, for some reason update dropped the first commit (first time using arcanist...). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews.llvm.o

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-08 Thread Lambert Clara via Phabricator via cfe-commits
belkiss updated this revision to Diff 398346. belkiss added a comment. Disable the test in ubsan-msan and ubsan-tsan since they also override global new, causing link error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

2022-01-08 Thread Lambert Clara via Phabricator via cfe-commits
belkiss created this revision. belkiss requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116861 Files: clang/lib/CodeGen/CGExprCXX.cpp compiler-rt/tes