Re: [PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

kulpreet updated this revision to Diff 66006. kulpreet added a comment. Sorry, uploaded the wrong patch. This one should compile with the unique variable names. https://reviews.llvm.org/D22926 Files: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp Index: lib/StaticAnalyzer/Checkers/Loca

[PATCH] D22926: Static Analyzer - Localizability Checker: New Localizable APIs for macOS Sierra

kulpreet created this revision. kulpreet added reviewers: zaks.anna, dcoughlin. kulpreet added a subscriber: cfe-commits. - Added in new iOS and macOS APIs that require a localized string - Removed two APIs that incorrectly were marked as requiring a localized string https://reviews.llv

Re: [PATCH] D12417: Improvements to localizability checks for iOS / OS X

kulpreet added a subscriber: cfe-commits. kulpreet updated this revision to Diff 35404. kulpreet added a comment. Shortened description of PluralMisuseChecker in Checkers.td as per Anna's recommendation. http://reviews.llvm.org/D12417 Files: lib/StaticAnalyzer/Checkers/Checkers.td lib/Stat

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 32174. kulpreet added a comment. - Incorporated feedback from Devin's review - Moved LSM over to StringSet<> http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/C

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 32102. kulpreet added a comment. Fixed memory corruption bug with temporary std::string - found with address sanitizer. Now, all regression tests pass with MallocScribble on. http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 31894. kulpreet added a comment. Moved UIMethods over to StringMap so it should compile on Windows now. http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checke

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet added a comment. Updated diff to include Anna's suggestions. http://reviews.llvm.org/D11572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 31481. kulpreet marked an inline comment as done. kulpreet added a comment. - By default (non-aggressive mode) the UnlocalizedStringChecker will ignore strings that are less than two characters long to avoid false positives such as @"-" - Added UIAlertView