[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-20 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. In D152054#4648318 , @sandeepkosuri wrote: > @kaz7, it seems that the thread_limit is being set properly, but the > `omp_get_thread_limit()` is giving a wrong output when you enable anything > more than `-O1`. I will fix it as soo

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-11 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. I figure out the reason of strange behavior I mentioned last night. However, I'm still not sure what is the good way to solve this problem. Can someone check the behavior with `-O2` option please? Thanks! Comment at: openmp/runtime/test/target/target_

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-10 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. In D152054#4642793 , @tianshilei1992 wrote: > In D152054#4642725 , @kaz7 wrote: > >> I run check-openmp on our machine, this omp_get_thread_limit() returns >> default thread limit 214748364

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

2023-09-10 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. I cannot write inline comment, so I'm leaving message here. openmp/runtime/test/target/target_thread_limit.cpp: > // checking consecutive target regions with different thread_limits > #pragma omp target thread_limit(3) > > { > printf("\nsecond target: thread_limit = %

[PATCH] D157813: [Driver][VE] Change to enable VPU flag by default

2023-08-31 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ce86002401: [Driver][VE] Change to enable VPU flag by default (authored by kaz7). Changed prior to commit: https://reviews.llvm.org/D157813?vs=554742&id=555063#toc Repository: rG LLVM Github Monore

[PATCH] D157813: [Driver][VE] Change to enable VPU flag by default

2023-08-30 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked an inline comment as done. kaz7 added a comment. Thank you for correction. I clean code again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 ___

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-30 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked an inline comment as done. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true; MaskRay wrote: > kaz7 wrote: > > MaskRay wro

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-30 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 554742. kaz7 added a comment. By using hasFlag, change to enable VPU flag for VE by default again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 Files: clang/include

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-29 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked 2 inline comments as done. kaz7 added a comment. In D157813#4621978 , @MaskRay wrote: >> [VE][Clang] Change to enable VPU flag by default > > For components like llvm/, clang/, we usually use a more specific tag. I'd > pick `[Driver]` over `[

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-29 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked an inline comment as done. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true; MaskRay wrote: > Delete the comment. The cod

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-29 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 554528. kaz7 added a comment. Change to not control backend default bahavior but support VPU flag in the backend for VE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-28 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Hi @MaskRay , thank you for reviewing this patch last time. Is it possible to review updated this patch again? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-24 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked 3 inline comments as done. kaz7 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-15 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked 3 inline comments as done. kaz7 added inline comments. Comment at: clang/include/clang/Driver/Options.td:5166 +// VE feature flags +let Flags = [TargetSpecific, CC1Option] in { +def mvevpu : Flag<["-"], "mvevpu">, Group, MaskRay wrote: > Other feature

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-15 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 550588. kaz7 added a comment. Update to follow suggestions. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 Files: clang/include/clang/Driver/Options.td

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added reviewers: MaskRay, jdoerfert, awarzynski. kaz7 added a comment. I randamly added reviewrs who review code related to feature flags and features group in clang. I appreciate if some of you guys have a time to check this patch too. Thank you so much. Repository: rG LLVM Github Mo

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thanks @efocht . I appreciate if someone working on clang can review this patch too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 ___

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

2023-08-13 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added a reviewer: efocht. kaz7 added projects: clang, VE. Herald added a project: All. kaz7 requested review of this revision. Herald added subscribers: cfe-commits, wangpc, MaskRay. Change to enable VPU flag for VE by default in order to support vector intrinsics

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

2022-09-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. In D133092#3788749 , @azat wrote: > In D133092#3788734 , @kaz7 wrote: > >> For your information, after this patch `check-clang` fails with following >> errors if there is no lld (lld is not

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

2022-09-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. For your information, after this patch `check-clang` fails with following errors if there is no lld is installed (lld is not enable in CMake, and lld is not installed previously). I appreciate if you run debug-options.c test with `-fuse-ld=lld` if the lld is existing. Th

[PATCH] D128120: [Clang][VE] Add missing intrinsics

2022-06-20 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba0a9571b3e: [Clang][VE] Add missing intrinsics (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D128120: [Clang][VE] Add missing intrinsics

2022-06-18 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: efocht, simoll. kaz7 added projects: clang, VE. Herald added a project: All. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Add missing intrinsics and tests for them. An expanding macro from _vel_pack_f32p to __bu

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

2022-06-06 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you, @chapuni and @ahatanak, for quick fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125839/new/ https://reviews.llvm.org/D125839 ___ cfe-commits mailing list cfe-comm

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

2022-06-06 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Hi, after this patch, our buildbot for VE having errors like https://lab.llvm.org/buildbot/#/builders/91/builds/9984. When I run a test script by hand, it shows following errors. Please investigate them. Thank you. $ cd build $ /home/marukawa/llvm-upstream/build/bin

[PATCH] D121816: [Clang][VE] Add vector mask intrinsics to clang

2022-03-17 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what modification on this patch causes a such error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121816/new/ https://reviews.llvm.org/D121816 __

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

2022-03-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:35 +// TODO: Vector mask registers +// Depend on https://reviews.llvm.org/D88905 +// BUILTIN(__builtin_ve_vl_vst_vssml, "vV256dLUiv*V256bUi", "n") xbolva00 wrote: > Why leave d

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

2022-03-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242 +#if 0 +BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n") +BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n") simoll wrote: > Could you comment at the top o

[PATCH] D121049: [Clang][VE] Add vector load intrinsics

2022-03-11 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb1b4b6f36695: [Clang][VE] Add vector load intrinsics (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121049/new/ https://reviews.llvm.org/

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

2022-03-06 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Herald added a project: All. At the beginning, this implementation extends `vector_type` attribute which is GCC's attribute. So, this may cause future conflicts with GCC when they extend it. But, now this patch uses it's own `ext_vector_type` attribute. So, basically th

[PATCH] D121049: [Clang][VE] Add vector load intrinsics

2022-03-06 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 413295. kaz7 added a comment. Add intrinsics for not only VLD instructions but also VLD2D instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121049/new/ https://reviews.llvm.org/D121049 Files: clang/inc

[PATCH] D121049: [Clang][VE] Add vector load intrinsics

2022-03-05 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, efocht. kaz7 added a project: clang. Herald added a subscriber: mgorny. Herald added a project: All. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Add vector load intrinsic instructions for VE. Repository

[PATCH] D114527: [VE] Support multiple architectures installation

2021-12-06 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG83f572527e0f: [VE] Support multiple architectures installation (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews

[PATCH] D114527: [VE] Support multiple architectures installation

2021-12-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 391223. kaz7 added a comment. Rebase to the latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews.llvm.org/D114527 Files: clang/lib/Driver/ToolChains/VEToolchain.cpp clang/tes

[PATCH] D114527: [VE] Support multiple architectures installation

2021-11-24 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 389479. kaz7 added a comment. Update ve-toolchain.c and ve-toolchain.cpp using -ccc-install-dir option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114527/new/ https://reviews.llvm.org/D114527 Files: clang/li

[PATCH] D114527: [VE] Support multiple architectures installation

2021-11-24 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change C++ header files placement to support multiple LLVM_RUNTIME_TARGETS build. Als

[PATCH] D113087: [VE] Change to omitting the frame pointer on leaf functions

2021-11-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d32218d1af2: [VE] Change to omitting the frame pointer on leaf functions (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D113087: [VE] Change to omitting the frame pointer on leaf functions

2021-11-02 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Change to omitting the frame pointer on leaf functions by default for VE. Repository: rG LLVM Github Monorepo h

[PATCH] D108069: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-16 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7313a6d87c04: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108

[PATCH] D108069: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Need to update a clang regression test for VE after https://reviews.llvm.org/D93769.

[PATCH] D94076: [VE] Change clang to support SjLj Lowering

2021-01-05 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG489000d8516d: [VE] Change clang to support SjLj Lowering (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.o

[PATCH] D94076: [VE] Change clang to support SjLj Lowering

2021-01-05 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94076/new/ https://reviews.llvm.org/D94076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D94076: [VE] Change clang to support SjLj Loweirng

2021-01-05 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We supports SjLj exception handling in the backend, so changing clang to allow lowerin

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

2020-12-26 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. We are using this patch in llvm/clang for VE and the patch is really helpful to implement intrinsic instructions using vector mask registers. This works fine in backend since backend supports vXi1. I wish people working on clang think this patch is reasonable. ===

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-13 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you so much too. I could learn how to write better clang tests. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___ cfe-commits

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-13 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d1729232cd: [VE] Optimize toolchain regression test (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-12 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 311423. kaz7 added a comment. Rebase and update following suggestions. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 Files: clang/test/Driver/Inputs/basic_ve_

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-12 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you for suggestions. Comment at: clang/test/Driver/ve-toolchain.cpp:115 +// DEF-SAME: "-z" "max-page-size=0x400" +// DEF-SAME: "crtbegin.o" +// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl" MaskRay wrote: > You proba

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-10 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: MaskRay, simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: ormris. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Optimize toolchain regression test for VE by removing not a useful test

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

2020-12-10 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5855ac3ba7: [VE] Remove -faddrsig and -fnoaddrsig tests (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

2020-12-10 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thanks! Working on sysroot stuff now. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92996/new/ https://reviews.llvm.org/D92996 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

2020-12-10 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you for additional suggestions. I'll make next patch like "optimize ve-toolchain.c and .cpp." Thank you so much! Comment at: clang/test/Driver/ve-toolchain.cpp:72 // RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFINITARRAY

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

2020-12-09 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: MaskRay, simoll, k-ishizaka. kaz7 added projects: VE, clang. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Remove explicitly declared -faddrsig and -fnoaddrsig option tests since those are already tested in addrsig

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-09 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you for suggestions. I'll submit patches to improve it. Comment at: clang/test/Driver/ve-toolchain.cpp:13 + +// RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DYNLINKER %s +// DYNLINKER: nld{{.*}} "-dynamic-linker" "/opt/nec/ve/lib/

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d30df7b5997: [VE] Add standard include path and library path for C++ (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 309231. kaz7 added a comment. Add environment variable test as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92386/new/ https://reviews.llvm.org/D92386 Files: clang/lib/Driver/ToolChains/VEToolchain.

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 planned changes to this revision. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; simoll wrote: > Do we want a

[PATCH] D92386: [VE] Add standard include path and library path for C++

2020-12-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added subscribers: cfe-commits, ormris. kaz7 requested review of this revision. We have a plan to add libcxx and libcxxabi for VE. In order to do so, we need to compile cxx source code wit

[PATCH] D92256: [VE] Specify vector alignments

2020-11-30 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33eac0f2830e: [VE] Specify vector alignments (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D92256: [VE] Specify vector alignments

2020-11-27 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: clang. kaz7 requested review of this revision. Specify alignments for all vector types. Update a regression

[PATCH] D91350: [VE] Disable -fsigaddr option for VE

2020-11-12 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c504ec06da6: [VE] Disable -fsigaddr option for VE (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D91350: [VE] Disable -fsigaddr option for VE

2020-11-12 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. VE needs to support integrated assembler and "nas". This "nas" doesn't recognize ".sigaddr" pseudo mnemonics, so ne

[PATCH] D91251: [VE] Support vector register in inline asm

2020-11-11 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e0ae20f3b98: [VE] Support vector register in inline asm (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D91251: [VE] Support vector register in inline asm

2020-11-11 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. Support a vector register constraint in inline asm of clang. Add a regression test also. Repository: rG LLVM Git

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

2020-10-29 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5ac3721c8a4: [VE] Change to use integrated assembly by defualt (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90396: [VE] Change to use integrated assembly by defualt

2020-10-29 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added a project: clang. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. We've implemented integrated assembler. Now, we change to use integrated assembler by

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-19 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you preparing this i1 patch and doing it on clang side only. We were testing this patch and sending problem reports. Now, we can use this patch without modifying llvm code. We can define vector mask types like below. Then, we can define intrinsic functions using

[PATCH] D85507: [VE] Remove obsoleted getVEAsmModeForCPU function

2020-08-07 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ac1eb6358b1: [VE] Remove obsoleted getVEAsmModeForCPU function (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85507: [VE] Remove obsoleted getVEAsmModeForCPU function

2020-08-07 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85507 Files: clang/lib/Driver/ToolChains/Arch/VE

[PATCH] D85071: [VE] Extend integer arguments and return values smaller than 64 bits

2020-08-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG045e79e77c25: [VE] Extend integer arguments and return values smaller than 64 bits (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85071/ne

[PATCH] D85071: [VE] Extend integer arguments and return values smaller than 64 bits

2020-08-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: cfe-commits. kaz7 requested review of this revision. In order to follow NEC Aurora SX VE ABI correctly, change to sign/zero extend integer arguments and return values sm

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-07-31 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you for implementing `EmitFromMemory`. We are locally trying to use this patch to implement vector mask intrinsic instructions on Aurora VE. It is working well with regression tests. We will try test-suite next. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D83173: [VE] Correct stack alignment

2020-07-07 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3bda047d5a: [VE] Correct stack alignment (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83173: [VE] Correct stack alignment

2020-07-06 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3bda047d5a: [VE] Correct stack alignment (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83173/new/ https://reviews.llvm.org/D83173 Fil

[PATCH] D83173: [VE] Correct stack alignment

2020-07-05 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: clang. Change stack alignment from 64 bits to 128 bits to follow ABI correctly. And add a regression test for

[PATCH] D82968: [VE] Rename VE toolchain source files

2020-07-02 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG804d9687443e: [VE] Rename VE toolchain source files (authored by kaz7). Changed prior to commit: https://reviews.llvm.org/D82968?vs=274815&id=275036#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D82968: [VE] Rename VE toolchain source files

2020-07-01 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Rename VE.cpp and VE.h to VEToolchain.cpp and VEToolchain.h respectively in order to avoid link warning message. Linke

[PATCH] D82461: [VE] Add clang tests for VE

2020-06-24 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6036bf53090e: [VE] Add clang tests for VE (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82461/new/ https://reviews.llvm.org/D82461 Files

[PATCH] D82461: [VE] Add clang tests for VE

2020-06-24 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: cfe-commits, ormris, jfb, krytarowski. Herald added a project: clang. Add a preprocessor test to check VE predefinitions. Add a driver test to check VE toolchain behavior

[PATCH] D79411: [VE] Clang toolchain for VE

2020-06-23 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Please check an inline comment. Comment at: clang/lib/Basic/Targets/VE.h:166 + + int getEHDataRegisterNumber(unsigned RegNo) const override { +// S0 = ExceptionPointerRegister, S1 = ExceptionSelectorRegister Current VE backend doesn't

[PATCH] D79411: [VE] Clang toolchain for VE

2020-06-23 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 accepted this revision. kaz7 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___ cf

[PATCH] D79411: [VE] Clang toolchain for VE

2020-06-16 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added reviewers: hfinkel, b-sumner, jmolloy, kparzysz, majnemer, igorb. kaz7 added a comment. Add people who reviewed patches adding new target to clang. Sorry for bothering you guys, but I appreciate if you review our patch or give us suggestions how to get reviewed. Thanks in advance.

[PATCH] D79411: [VE] Clang toolchain for VE

2020-06-03 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. It looks fine to me but I'm not clang expert. Can anyone review this or introduce us reviewers? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___