kadircet wrote:
merging without review, as the change is rather trivial. if you have concerns
feel free to leave comments, I am happy to revert or address them post-merge.
https://github.com/llvm/llvm-project/pull/152142
___
cfe-commits mailing list
c
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/152142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/152142
None
From 3c36f12e451a38fc1c785abc81ac76b7b9808cf0 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Tue, 5 Aug 2025 15:52:53 +0200
Subject: [PATCH] [include-cleaner] Respect language when tracking IWYU pra
@@ -279,155 +17,6 @@ SYMBOL(abs, None, )
SYMBOL(abs, None, )
SYMBOL(abs, None, )
-// Only add headers for the generic atomic template.
-// Ignore variants (std::weak_ptr, std::shared_ptr).
-SYMBOL(atomic, std::, )
-// atomic_* family symbols. is for C compatibility.
-SYMBOL(a
@@ -7,268 +7,6 @@
// Symbols that can be provided by any of the headers, ordered by the header
// preference.
-// cppreference mentions the header is an alternative for these
symbols,
-// but they are not per the standard.
-SYMBOL(consume_header, std::, )
-SYMBOL(generate_he
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/137550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
> what you mean exactly by "landing"...
sorry, i meant merging the PR.
I'll merge it once tests passes, thanks again!
https://github.com/llvm/llvm-project/pull/137550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/kadircet requested changes to this pull request.
see https://github.com/llvm/llvm-project/pull/147720#discussion_r2250774590
https://github.com/llvm/llvm-project/pull/147720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -497,354 +78,3 @@ SYMBOL(_26, std::placeholders::, )
SYMBOL(_27, std::placeholders::, )
SYMBOL(_28, std::placeholders::, )
SYMBOL(_29, std::placeholders::, )
-
-// Macros
-SYMBOL(NULL, None, )
-SYMBOL(NULL, None, )
-SYMBOL(NULL, None, )
-SYMBOL(NULL, None, )
-SYMBOL(NULL, No
kadircet wrote:
> @kadircet should I modify the failing unit test or what is the best course of
> action?
yes i think for size_t, as long as we have `` as the first header this
should be fine.
https://github.com/llvm/llvm-project/pull/147720
___
cfe
https://github.com/kadircet requested changes to this pull request.
sorry for the late reply, i think direction makes sense. just some comments
about the details
https://github.com/llvm/llvm-project/pull/137550
___
cfe-commits mailing list
cfe-commits
https://github.com/kadircet commented:
sorry for the late reply, i think direction makes sense. just some comments
about the details
https://github.com/llvm/llvm-project/pull/137550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
@@ -859,17 +859,56 @@ std::vector getDocumentLinks(ParsedAST
&AST) {
for (auto &Inc : AST.getIncludeStructure().MainFileIncludes) {
if (Inc.Resolved.empty())
continue;
+
+// Get the location of the # symbole of the "#include ..." statement
auto HashLoc = S
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/137550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks a lot!
https://github.com/llvm/llvm-project/pull/147720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -279,154 +17,55 @@ SYMBOL(abs, None, )
SYMBOL(abs, None, )
SYMBOL(abs, None, )
-// Only add headers for the generic atomic template.
-// Ignore variants (std::weak_ptr, std::shared_ptr).
-SYMBOL(atomic, std::, )
-// atomic_* family symbols. is for C compatibility.
-SYMBOL(
https://github.com/kadircet commented:
thanks, looks a lot better. some small comments around adding a variant for
`std::abs` and deleting special entries for global atomic_*
https://github.com/llvm/llvm-project/pull/147720
___
cfe-commits mailing lis
@@ -1234,15 +1234,6 @@ SYMBOL(FILE, None, )
SYMBOL(_Exit, std::, )
SYMBOL(_Exit, None, )
SYMBOL(_Exit, None, )
-SYMBOL(abs, std::, )
kadircet wrote:
i think we can preserve these by adding a variant for `abs` on `int`.
https://github.com/llvm/llvm-project/pul
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/147720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -690,6 +1391,23 @@ SYMBOL(atol, None, )
SYMBOL(atoll, std::, )
SYMBOL(atoll, None, )
SYMBOL(atoll, None, )
+SYMBOL(atomic, std::, )
+SYMBOL(atomic, std::, )
+SYMBOL(atomic_bool, std::, )
+SYMBOL(atomic_bool, std::, )
+SYMBOL(atomic_bool, std::, )
kadircet wr
https://github.com/kadircet approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/150629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -391,6 +392,16 @@ class DocumentOutline {
D = TD;
}
+// Friend declarations should be traversed if and only if
+// they are also defined here.
kadircet wrote:
we aren't really visiting friend decl, we're visiting the underlying function
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/150629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/150788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
thanks!
https://github.com/llvm/llvm-project/pull/150788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
FYI @marcogmaia, can you reland #139348 after this PR lands?
https://github.com/llvm/llvm-project/pull/150308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
thanks a lot again!
https://github.com/llvm/llvm-project/pull/139348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/139348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -690,6 +1391,23 @@ SYMBOL(atol, None, )
SYMBOL(atoll, std::, )
SYMBOL(atoll, None, )
SYMBOL(atoll, None, )
+SYMBOL(atomic, std::, )
+SYMBOL(atomic, std::, )
+SYMBOL(atomic_bool, std::, )
+SYMBOL(atomic_bool, std::, )
+SYMBOL(atomic_bool, std::, )
kadircet wr
@@ -232,4 +247,4 @@ def GetSymbols(parse_pages):
finally:
pool.terminate()
pool.join()
-return sorted(symbols)
+return sorted(set(symbols))
kadircet wrote:
each symbol should already have a unique name, why do we need this conversio
@@ -2525,6 +3589,10 @@ SYMBOL(remainderf, None, )
SYMBOL(remainderl, std::, )
SYMBOL(remainderl, None, )
SYMBOL(remainderl, None, )
+SYMBOL(remove, std::, )
+SYMBOL(remove, std::, )
kadircet wrote:
so we mainly had two reasons for multiple headers per symbol:
https://github.com/kadircet requested changes to this pull request.
thanks a lot for working on this, i think this is a great improvement in
general!
https://github.com/llvm/llvm-project/pull/147720
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/147720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -70,6 +70,16 @@ Code completion
Code actions
+- New ``clangd`` code action: "Override pure virtual methods". When invoked on
a
kadircet wrote:
nit: i'd drop `clangd`, it's already under clangd section.
https://github.com/llvm/llvm-project/pu
@@ -70,6 +70,16 @@ Code completion
Code actions
+- New ``clangd`` code action: "Override pure virtual methods". When invoked on
a
+ class definition, this action automatically generates C++ ``override``
+ declarations for all pure virtual methods inherited from
https://github.com/kadircet approved this pull request.
thanks and sorry for not getting back to this for so long. i don't think i'll
get to follow up and looks like others are also busy.
i have some usability concerns like:
- Generating method bodies in class definitions instead of out-of-line
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/139348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/137163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/137163
From 3453a392b98e05c7d259ebf1741767f7e36a6be9 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 24 Apr 2025 11:12:00 +0200
Subject: [PATCH 1/7] [clang][CompundLiteralExpr] Don't defer evaluation for
CL
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/137163
From 3453a392b98e05c7d259ebf1741767f7e36a6be9 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 24 Apr 2025 11:12:00 +0200
Subject: [PATCH 1/6] [clang][CompundLiteralExpr] Don't defer evaluation for
CL
kadircet wrote:
@AaronBallman @ilya-biryukov ping here, I am planning to merge this soon.
please LMK if you still have any concerns.
https://github.com/llvm/llvm-project/pull/137163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/137163
From 3453a392b98e05c7d259ebf1741767f7e36a6be9 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 24 Apr 2025 11:12:00 +0200
Subject: [PATCH 1/5] [clang][CompundLiteralExpr] Don't defer evaluation for
CL
@@ -9125,9 +9126,25 @@ bool
LValueExprEvaluator::VisitCompoundLiteralExpr(const CompoundLiteralExpr *E) {
assert((!Info.getLangOpts().CPlusPlus || E->isFileScope()) &&
"lvalue compound literal in c++?");
- // Defer visiting the literal until the lvalue-to-rvalue con
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/137163
From 55976eaeac5bba9c36b92d7aa99f8f589d6c9ef5 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Thu, 24 Apr 2025 11:12:00 +0200
Subject: [PATCH 1/4] [clang][CompundLiteralExpr] Don't defer evaluation for
CL
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/143302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -296,12 +296,16 @@ static bool fillRanges(MemoryBuffer *Code,
}
if (!EmptyLengths)
Length = Lengths[I];
+if (Length == 0) {
+ errs() << "error: length should be at least 1\n";
+ return true;
+}
if (Offset + Length > CodeSize) {
err
@@ -9125,9 +9126,25 @@ bool
LValueExprEvaluator::VisitCompoundLiteralExpr(const CompoundLiteralExpr *E) {
assert((!Info.getLangOpts().CPlusPlus || E->isFileScope()) &&
"lvalue compound literal in c++?");
- // Defer visiting the literal until the lvalue-to-rvalue con
@@ -296,12 +296,16 @@ static bool fillRanges(MemoryBuffer *Code,
}
if (!EmptyLengths)
Length = Lengths[I];
+if (Length == 0) {
+ errs() << "error: length should be at least 1\n";
+ return true;
+}
if (Offset + Length > CodeSize) {
err
kadircet wrote:
sorry for silence here, i was mostly waiting for some replies to
https://github.com/llvm/llvm-project/pull/140594#issuecomment-2958066558. as it
stands, i feel like we'll likely limit users with a spelling based filter.
unless people have concerns/disagreement, i'd suggest we r
@@ -117,6 +117,7 @@ get_property(LINK_LIBS GLOBAL PROPERTY
CLANG_UNITTEST_LINK_LIBS)
get_property(LLVM_COMPONENTS GLOBAL PROPERTY CLANG_UNITTEST_LLVM_COMPONENTS)
add_distinct_clang_unittest(AllClangUnitTests
${SRCS}
+ AllClangUnitTests.cpp
kadircet wrote:
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/144428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/144428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/144428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -117,6 +117,7 @@ get_property(LINK_LIBS GLOBAL PROPERTY
CLANG_UNITTEST_LINK_LIBS)
get_property(LLVM_COMPONENTS GLOBAL PROPERTY CLANG_UNITTEST_LLVM_COMPONENTS)
add_distinct_clang_unittest(AllClangUnitTests
${SRCS}
+ AllClangUnitTests.cpp
kadircet wrote:
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/142903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/142903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -497,6 +497,12 @@ bool fromJSON(const llvm::json::Value &Params,
ClientCapabilities &R,
if (auto Cancel = StaleRequestSupport->getBoolean("cancel"))
R.CancelsStaleRequests = *Cancel;
}
+if (auto *OffsetEncoding = General->get("positionEncodings")) {
+
kadircet wrote:
Do you or @petrhosek have some free cycles to follow up on that soon?
Because as things stand, unit test execution is currently in a very fragile
state. Anyone that adds a unittest to clang currently runs the risk of braking
something completely unrelated (I do agree that it's
kadircet wrote:
hi folks, this change triggered some other failures in a distance, you can see
detailed analysis in
https://github.com/llvm/llvm-project/pull/143695#issuecomment-2970691063.
but tl;dr; LLVM shares some state throughout a process. This isn't something
new with this change, unit
kadircet wrote:
ok so I did a little more investigation here, and tl;dr is:
- LLVM's target registry mechanism relies on static initialization of variables
by the main driver program (usually clang driver takes care of this for real
world runs).
- There are some tests (especially the ones that
kadircet wrote:
hi @nathanchance, I can't seem to reproduce the failure, and I couldn't find
any buildbots with this failure (also the assertion you're seeing conceptually
shouldn't be triggered by state in diagnostics engine). I am not sure how to
proceed here but can you at least verify if t
@@ -974,7 +974,7 @@ class Foo final {})cpp";
HI.Name = "abc";
HI.Kind = index::SymbolKind::Variable;
HI.NamespaceScope = "";
- HI.Definition = "int abc = ()";
kadircet wrote:
despite typoexprs fragile and complicated nature,
https://github.com/kadircet approved this pull request.
sorry for the late response and thanks a lot!
https://github.com/llvm/llvm-project/pull/140356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
kadircet wrote:
I am afraid exposing this in server capabilities might be too convoluted.
IIUC, we're trying to figure out if clangd should be used for documents for
language `X`. We need to figure this out **before** clangd's proper
initialization, so that we can decide which `documentSelecto
@@ -497,6 +497,12 @@ bool fromJSON(const llvm::json::Value &Params,
ClientCapabilities &R,
if (auto Cancel = StaleRequestSupport->getBoolean("cancel"))
R.CancelsStaleRequests = *Cancel;
}
+if (auto *OffsetEncoding = General->get("positionEncodings")) {
+
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/142903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/143695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
I am rather worried that we'll lose ability to filter effectively when we match
against spelled headers. Maybe the actual use cases in the wild and what I have
mind are different, but I would expect users to have a situation like;
- they pass a `-Ithird_party/qt/include` in thei
@@ -151,6 +164,11 @@ std::vector generateMissingIncludeDiagnostics(
if (!Replacement.has_value())
continue;
+if (Angled && Spelling.front() == '\"') {
kadircet wrote:
yikes, we also need to do this transformation in the other way as well :/
Mig
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/140594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/140594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks, mostly LGTM, please wait on a final look from @HighCommander4 though,
he has more context about this feature overall, maybe the discrepancy on path
vs spelling based match has a story.
https://github.com/llvm/llvm-project/pull/140
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/141584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/139463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/141092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks a lot!
https://github.com/llvm/llvm-project/pull/141092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -141,16 +143,41 @@ std::vector generateMissingIncludeDiagnostics(
AST.getPreprocessor().getHeaderSearchInfo(), MainFile});
llvm::StringRef HeaderRef{Spelling};
-bool Angled = HeaderRef.starts_with("<");
+
+bool IsAngled = false;
kadirce
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/140594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
LGTM, but cc @llvm/clang-area-team, in case they have any concerns here
https://github.com/llvm/llvm-project/pull/140870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/139463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -43,10 +43,18 @@ internal::Matcher callToGet(const
internal::Matcher &OnClass) {
.bind("redundant_get");
}
-internal::Matcher knownSmartptr() {
+internal::Matcher knownSmartptrAny() {
return recordDecl(hasAnyName("::std::unique_ptr", "::std::shared_ptr"));
}
+i
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet requested changes to this pull request.
do we know why
https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L5894-L5901
doesn't declare _EQ version for cc1?
i think instead of working around this in various places, we should unify the
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/141410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,6 +32,9 @@
# RUN: echo 'printf "End of search list.\r\n" >&2' >> %t.dir/bin/my_driver.sh
# RUN: chmod +x %t.dir/bin/my_driver.sh
+# Create fake clang-tidy config to ensure sandbox
+# RUN: echo 'InheritParentConfig: false' >> %t.dir/.clang-tidy
kadircet
@@ -0,0 +1 @@
+InheritParentConfig: false
kadircet wrote:
are we running any tests in this directory? these inputs are usually copied to
temp test directories, since you're not copying this over in any of the tests,
is this really needed? (or do we have some te
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/141092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet requested changes to this pull request.
thanks a lot for taking a lookg here!
https://github.com/llvm/llvm-project/pull/141092
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -44,7 +44,10 @@ internal::Matcher callToGet(const
internal::Matcher &OnClass) {
}
internal::Matcher knownSmartptr() {
- return recordDecl(hasAnyName("::std::unique_ptr", "::std::shared_ptr"));
+ return recordDecl(
+ hasAnyName("::std::unique_ptr", "::std::shared_ptr
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/141216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -19,7 +19,7 @@ class UseNullptrCheck : public ClangTidyCheck {
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
// FIXME this should be CPlusPlus11 but that causes test cases to
// erroneously fail.
-return LangOpts.CPlusPlus || Lan
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet wrote:
just a high level question, I wasn't following the recent developments closely,
but we seem to have both an `AngledHeaders` and `QuotedHeaders` option. Why are
we only following one here?
I guess the signals for angled includes are much stricter (search paths need to
be marked
kadircet wrote:
unfortunately neither is used by include-cleaner. we only support mappings for
c++ STL, through
https://github.com/llvm/llvm-project/blob/main/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
and friends.
we didn't want to add any system specific libraries, especially base
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/140233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet commented:
LG for include-cleaner changes.
https://github.com/llvm/llvm-project/pull/140233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/140600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1003 matches
Mail list logo
