[clang] [llvm] [mlir] [NVPTX] Convert scalar function nvvm.annotations to attributes (PR #125908)

2025-02-10 Thread Justin Holewinski via cfe-commits
https://github.com/jholewinski approved this pull request. https://github.com/llvm/llvm-project/pull/125908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NVPTX] Convert scalar function nvvm.annotations to attributes (PR #125908)

2025-02-10 Thread Justin Holewinski via cfe-commits
@@ -375,11 +375,8 @@ void CodeGenModule::handleCUDALaunchBoundsAttr(llvm::Function *F, if (MinBlocks > 0) { if (MinBlocksVal) *MinBlocksVal = MinBlocks.getExtValue(); - if (F) { -// Create !{, metadata !"minctasm", i32 } node -NVPTXTarget

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-09-16 Thread Justin Holewinski via cfe-commits
jholewinski wrote: >> If you specify a flat address space, does that mean that all other address >> spaces are not flat, and thus cannot alias with other address spaces? > Yes, all other address spaces are not flat. A flat address space pointer can > still point to the same place as a non-flat

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-07-29 Thread Justin Holewinski via cfe-commits
jholewinski wrote: I'm wondering if this feature would be better named `sm_custom` or similar. The `sm_next` moniker implies that the target is for a _future_ architecture target, but this feature can be used to inject any custom SM/PTX combination. Especially if this is extended to support th

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-07-29 Thread Justin Holewinski via cfe-commits
@@ -26,24 +27,38 @@ static cl::opt NoF16Math("nvptx-no-f16-math", cl::Hidden, cl::desc("NVPTX Specific: Disable generation of f16 math ops."), cl::init(false)); +static cl::opt +NextSM("nvptx-next-sm", cl::Hidden, + cl::desc("NVPTX

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-17 Thread Justin Holewinski via cfe-commits
jholewinski accepted this revision. jholewinski added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rL LLVM http://reviews.llvm.org/D20389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

2016-06-09 Thread Justin Holewinski via cfe-commits
jholewinski added a comment. Looks reasonable to me. http://reviews.llvm.org/D21162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits