@@ -156,13 +156,15 @@ FEATURE(objc_class_property, LangOpts.ObjC)
FEATURE(objc_c_static_assert, LangOpts.C11)
FEATURE(objc_cxx_static_assert, LangOpts.CPlusPlus11)
EXTENSION(objc_c_static_assert, true)
-// C11 features
+// C11 features
justinfargnoli wrote:
D
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/117507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -121,6 +121,17 @@ int NegativeShortTest[NegativeShort == -1 ? 1 : -1];
enum Color { Red, Green, Blue }; // expected-note{{previous use is here}}
typedef struct Color NewColor; // expected-error {{use of 'Color' with tag
type that does not match previous declaration}}
+// E
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/117507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli commented:
Add a title.
And welcome to the LLVM community :)
https://github.com/llvm/llvm-project/pull/117507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/justinfargnoli closed
https://github.com/llvm/llvm-project/pull/113780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justinfargnoli wrote:
> Is it possible/easy to split
> https://github.com/llvm/llvm-project/commit/ef6a751a794c3e2d266cac0242629043ddd0d2aa
> into a new PR?
Certainly, @boomanaiden154! Please see #116108 :)
https://github.com/llvm/llvm-project/pull/113780
_
justinfargnoli wrote:
> @justinfargnoli in few words the problem is in the broken link order for
> those two Key references.
@vvereschaka thank you for your [detail
description](https://github.com/llvm/llvm-project/pull/113780#issuecomment-2448416385)
of the issue.
I've attempted to address
justinfargnoli wrote:
@vvereschaka I'm unable to reproduce the build failure locally or via the
`buildkite` jobs.
Are the jobs that you're running on the BuildBot clean builds?
https://github.com/llvm/llvm-project/pull/113780
___
cfe-commits mailin
justinfargnoli wrote:
@vvereschaka, I agree.
Note: The problem is that `IRNormalizer` produces a change that invalidates an
analysis. It's not that IRNormalizer should declare that it's not preserving an
analysis.
I likely won't be able to fix this for a few days. @vvereschaka, should I
re
https://github.com/justinfargnoli closed
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli approved this pull request.
https://github.com/llvm/llvm-project/pull/112834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justinfargnoli wrote:
Ping @plotfi @nikic for review.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justinfargnoli wrote:
Ping @plotfi @nikic for review.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justinfargnoli wrote:
> can you point me to an analogous change I could use as an example?
[[LLD] Add CLASS syntax to
SECTIONS](https://github.com/llvm/llvm-project/commit/7e8a9020b1ae3dea28c19f0cd68743482dca13d9#diff-96d3595c06280d8c10f2687758a9e7bb5a0f3552fd53e552a1490411870c3500)
[[LLVM] Add
justinfargnoli wrote:
Hi @plotfi, thanks for pinging me on this! Generally speaking, two things
deserve additional focus:
- UX testing to find:
- Improvements to existing features
- New features to add
- Additional testing to ensure that the pass preserves the semantics of the IR.
- e.
justinfargnoli wrote:
> How do I actually upstream it?
Here is the documentation on how to [obtain commit
access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).
It's a relatively quick process.
However, if you don't want to go through that process, you can just ask for
justinfargnoli wrote:
Hi @dtcxzyw, thanks for reaching out!
This MR is blocked because I cannot reproduce the failures @nikic found
[here](https://github.com/llvm/llvm-project/pull/68176#issuecomment-1836365664).
(See [this
comment](https://github.com/llvm/llvm-project/pull/68176#issuecommen
justinfargnoli wrote:
TODO: Sort function order
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/78368
>From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Thu, 11 Jan 2024 20:00:53 -0800
Subject: [PATCH 1/6] Declare Affine Interfaces
---
mlir/lib/Dialect/Affi
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/78368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/78368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justinfargnoli wrote:
Open question: where should I declare promised interfaces for the `builtin`
Dialect?
https://github.com/llvm/llvm-project/pull/78368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/78368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/78368
>From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Thu, 11 Jan 2024 20:00:53 -0800
Subject: [PATCH 1/5] Declare Affine Interfaces
---
mlir/lib/Dialect/Affi
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/67866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2110,6 +2214,29 @@ def : Pat<(seteq Int1Regs:$a, Int1Regs:$b),
def : Pat<(setueq Int1Regs:$a, Int1Regs:$b),
(NOT1 (XORb1rr Int1Regs:$a, Int1Regs:$b))>;
+// comparisons of i8 extracted with BFE as i32
+def: Pat<(setgt (sext_inreg (trunc Int32Regs:$a), i8), (sext_i
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/78368
>From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Thu, 11 Jan 2024 20:00:53 -0800
Subject: [PATCH 1/4] Declare Affine Interfaces
---
mlir/lib/Dialect/Affi
justinfargnoli wrote:
Unless other comments brought up, I'll plan on merging this on Monday the 4th.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
justinfargnoli wrote:
Pinging @nikic for another round of review.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
justinfargnoli wrote:
> I would recommend trying to run this pass (with all options enabled) over all
> existing tests to make sure that it doesn't cause any crashes/verifier
> failures. You're moving instructions around, and it's easy to get that wrong
> when invoke, callbr or catchswitch are
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,637 @@
+//===--- IRNormalizer.cpp - IR Normalizer ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/31] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/30] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/29] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/28] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/26] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/25] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
justinfargnoli wrote:
Ping for another round of review.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli closed
https://github.com/llvm/llvm-project/pull/68762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,8 @@
+// RUN: mlir-opt %s
-pass-pipeline='builtin.module(func.func(scf-parallel-loop-tiling{parallel-loop-tile-sizes=0,0}))'
-split-input-file -verify-diagnostics
+
+// XFAIL: *
justinfargnoli wrote:
It looks like it isn't possible to use `expected-e
https://github.com/justinfargnoli closed
https://github.com/llvm/llvm-project/pull/69043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/69043
>From 8f8b644792d5e26f76d98bd8ba45440443f9a260 Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Fri, 13 Oct 2023 18:16:45 -0700
Subject: [PATCH 1/4] Initial commit
---
.../mlir/Analysis/DataFlow/DeadC
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/20] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/20] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/20] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/19] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
justinfargnoli wrote:
Renamed to IRNormalizer. Requesting another round of review.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/18] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli edited
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/17] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
@@ -0,0 +1,638 @@
+//===--- IRCanonicalizer.cpp - IR Canonicalizer
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,638 @@
+//===--- IRCanonicalizer.cpp - IR Canonicalizer
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/16] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/16] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/15] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli updated
https://github.com/llvm/llvm-project/pull/68176
>From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001
From: justinfargnoli
Date: Sat, 12 Aug 2023 10:58:45 -0700
Subject: [PATCH 01/15] Add IRCanonicalizer.cpp
---
llvm/lib/Transforms/U
https://github.com/justinfargnoli created
https://github.com/llvm/llvm-project/pull/68176
Add the llvm-canon tool. Description from the [original
PR](https://reviews.llvm.org/D66029#change-wZv3yOpDdxIu):
> Added a new llvm-canon tool which aims to transform LLVM Modules into a
> canonical for
63 matches
Mail list logo
