Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere approved this pull request.
LGTM but please give @Michael137 a chance to take a look as this is his area of
expertise.
https://github.com/llvm/llvm-project/pull/122289
___
JDevlieghere wrote:
The change itself seems fine but I'm not super convinced that the motivation is
worth the churn. All these files live under the "Option" library and therefore
it's (IMHO) clear that Opt is short for Option.
Is this addressing code review feedback or a real issue where the
JDevlieghere wrote:
> Thanks @JDevlieghere! Could you add this special case?
I'm happy to help but I wouldn't feel comfortable making such a change without
being able to reproduce and test it.
> The authoritatively established and supported way to link with `ncurses` on
> most Linux platfor
JDevlieghere wrote:
What I said was that, to the best of my knowledge, we don't have places in LLDB
that rely on `terminfo` but not on `ncruses`. I think that statement still
holds true. The assumption behind it was that `ncurses` provides a superset of
the functionality provided by `terminfo`
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/101243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere wrote:
Nice. An added benefit of doing it this way is that you can always set the
property for a particular target if you really need the scheme and you can do
it in the same cmake file that creates the target (i.e. in a subproject).
https://github.com/llvm/llvm-project/pull/1012
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/99871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/99871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/96532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/96385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
*sema.LateParsedTemplateMap.find(FD)->second;
sema.LateTemplateParser(sema.OpaqueParser, LPT);
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() <<
"\"\n";
-}
+
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere wrote:
> 1. Windows support
Windows support is definitely lacking which probably means a bunch of tests
don't run there. We do have [one
buildbot](https://lab.llvm.org/buildbot/#/builders/219) that runs on Windows so
I have a hard time believing it's totally broken. The last runs
JDevlieghere wrote:
> But lldb sets itself apart in how hard it is to get a project setup going,
> and how impactful it is.
Can you elaborate on what specifically you find hard? Building should be fairly
straightforward, besides Python and SWIG, which are required to run the test,
most of our
JDevlieghere wrote:
+1 to what Adrian said. Taht certainly does **not** match my expectations. I'm
not sure why there would be a different policy for LLDB than for any of the
other monorepo projects.
https://github.com/llvm/llvm-project/pull/94208
__
JDevlieghere wrote:
This is awesome, thank you for working on this!
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere wrote:
`LLDB_CURSES_LIBS` is scoped to lldbCore, which the EditLine unit test isn't
linking. If its also necessary in Host, then we should hoist it up and link
both libraries against it.
Anyway, that also means my initial assessment was wrong. I looked for the
header include but
JDevlieghere wrote:
The LLDB bots are still failing:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/4342/
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/2244/
https://github.com/llvm/llvm-project/pull/92885
___
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere wrote:
No objections in the context of LLDB. We don't use terminfo directly (although
I think editline does, but that isn't affected by this) and if we want the TUI
we depend on curses anyway.
https://github.com/llvm/llvm-project/pull/92865
__
JDevlieghere wrote:
> It's a `sed s/== None/is None/g` - what is there to review? 10 separate
> commits/PRs for the same exact `sed` costs more in commit noise (and effort
> on the part of @e-kwsm) than one solid, patient, review here.
In addition to what @ftynse said above, the `sed` might no
https://github.com/JDevlieghere commented:
This should really be broken up into separate PRs per subproject. One large PR
like this makes reviewing harder and causes unnecessary churn in the case that
this gets reverted.
https://github.com/llvm/llvm-project/pull/91857
_
JDevlieghere wrote:
I don't think Alex is arguing in favor of keeping the old (wrong) behavior, but
the first file looks like this:
```
foundSpec = False
if [...]
foundSpec = True
[...]
if foundSpec is False:
```
It's pretty obvious this is a boolean and should use `if not foundSpec`.
http
https://github.com/JDevlieghere requested changes to this pull request.
As per Aiden's suggestion, please split this up into smaller PRs, grouped by
subproject.
https://github.com/llvm/llvm-project/pull/91856
___
cfe-commits mailing list
cfe-commits@
JDevlieghere wrote:
> If this is split out from the other larger PR, should there be `clang/`
> changes in here?
+1, please unstage the `clang` and `openmp` changes.
https://github.com/llvm/llvm-project/pull/91858
___
cfe-commits mailing list
cfe-co
JDevlieghere wrote:
Right, my point is that (I think) that doesn't make sense. AFAIK
`addMinVersionArgs` is called exclusively from the code snippet I pasted, which
should check the linker version. The version of `ld` in which this changed is
much newer than the 520 referenced there.
I'd sta
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/88810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere requested changes to this pull request.
We should be using `-platform-version` for newer versions of the linker. How
are we ending up in this code path?
https://github.com/llvm/llvm-project/pull/88810
___
cfe-commits m
JDevlieghere wrote:
This looks like a nice improvement for folks using those generators. Even
though most of these changes look straightforward, it would be a lot easier to
review if this was broken up per subproject. Is there any reason that's not
possible?
https://github.com/llvm/llvm-proj
https://github.com/JDevlieghere requested changes to this pull request.
+1 on what Cyndy said. The lldb change itself looks fine.
https://github.com/llvm/llvm-project/pull/89480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/89140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
LLDB & VFS change LGTM.
https://github.com/llvm/llvm-project/pull/89140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere wrote:
Hey @etcwilde, this breaks the Xcode standalone build for lldb:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/121/
The failing command in the generated script phase is:
```
cmake -E copy_directory
/Users/jonas/llvm/xcode-build/Debug/bin/LLD
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
@delcypher I was referring to the tools in `
https://github.com/JDevlieghere approved this pull request.
Thanks, this LGTM!
https://github.com/llvm/llvm-project/pull/87585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
"tools" has a pretty specific meaning for LL
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere commented:
I'm wondering if shell test are really the best way to test this. For more
complex scenarios like are being tested here, we generally prefer [1] API tests
because they're more expressive and allow you to build more complicated test
binaries with our M
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/79181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,65 @@
+# Tests for basic Debuginfod functionality
+
+Because the Debuginfod protocol is a simple HTTP path-based system, one can
+mimic a Debuginfod server by setting up a directory structure to reflect the
+protocol properly. That's how all these tests operate. We over
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/78392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -30,6 +30,20 @@ using namespace llvm;
using namespace dwarf_linker;
using namespace dwarf_linker::classic;
+Expected> DwarfStreamer::createStreamer(
+const Triple &TheTriple, DWARFLinkerBase::OutputFileType FileType,
+raw_pwrite_stream &OutFile, DWARFLinkerBase::Tra
https://github.com/JDevlieghere approved this pull request.
Before this patch, the DWARFLinker was the one responsible for creating the
streamer, which meant that both the classic and parallel implementation needed
to conform to the same interface. After this patch, the concrete
implementation
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From 52ff81ffbce596fd89b296e7f4199be13f9402ff Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 16 Jan 2024 20:36:47 -0800
Subject: [PATCH 1/2] [clang] Upstream XROS support in Clang
Upstream XRO
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From d7c431e0fbc0ad006b9d37a4e3a43c61ce1f50b7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 16 Jan 2024 20:36:47 -0800
Subject: [PATCH] [clang] Upstream XROS support in Clang
Upstream XROS su
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From 6f6d93b6cc413d54dbdec05f30ede00ffdb4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 10 Jan 2024 17:35:47 -0800
Subject: [PATCH 1/2] [lldb] Upstream xros support in lldb
Upstream suppo
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/78392
Upstream XROS support in the clang frontend and driver.
>From 1e65420f87eed1f7f4380496f96eef2560a15cb0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 16 Jan 2024 20:36:47 -0800
Subject: [PATCH]
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/73067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,13 +108,9 @@ else()
linux/HostInfoLinux.cpp
linux/LibcGlue.cpp
linux/Support.cpp
+ android/HostInfoAndroid.cpp
+ android/LibcGlue.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Android")
JDevlieghere wrote:
While Android m
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/70512
>From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Thu, 5 Oct 2023 12:39:02 -0700
Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in
.d
https://github.com/JDevlieghere approved this pull request.
I like how this centralizes everything in a single place and the def file
format seems like a natural fit for the platforms.
https://github.com/llvm/llvm-project/pull/69262
___
cfe-commits m
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/65664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jonas Devlieghere
Date: 2023-06-14T15:28:33-07:00
New Revision: fc60bf2de11149d2c027d63e7ad5a98afa6fab80
URL:
https://github.com/llvm/llvm-project/commit/fc60bf2de11149d2c027d63e7ad5a98afa6fab80
DIFF:
https://github.com/llvm/llvm-project/commit/fc60bf2de11149d2c027d63e7ad5a98afa6fab80.d
Author: Jonas Devlieghere
Date: 2023-06-14T14:16:16-07:00
New Revision: 04c0161c027676119fdc617f5b883dbda97c8549
URL:
https://github.com/llvm/llvm-project/commit/04c0161c027676119fdc617f5b883dbda97c8549
DIFF:
https://github.com/llvm/llvm-project/commit/04c0161c027676119fdc617f5b883dbda97c8549.d
Author: Jonas Devlieghere
Date: 2023-06-14T13:03:31-07:00
New Revision: e0d57295bf6a3c04f2901d9c70f529d570f48b65
URL:
https://github.com/llvm/llvm-project/commit/e0d57295bf6a3c04f2901d9c70f529d570f48b65
DIFF:
https://github.com/llvm/llvm-project/commit/e0d57295bf6a3c04f2901d9c70f529d570f48b65.d
Author: Jonas Devlieghere
Date: 2022-10-19T15:08:56-07:00
New Revision: 97b91307b00e958bc1d511c93a8a6bef510485ac
URL:
https://github.com/llvm/llvm-project/commit/97b91307b00e958bc1d511c93a8a6bef510485ac
DIFF:
https://github.com/llvm/llvm-project/commit/97b91307b00e958bc1d511c93a8a6bef510485ac.d
Author: Jonas Devlieghere
Date: 2022-07-12T15:22:29-07:00
New Revision: a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437
URL:
https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437
DIFF:
https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437.d
Author: Jonas Devlieghere
Date: 2022-07-11T13:59:41-07:00
New Revision: c7fd7512a5c5b133665bfecbe2e9748c0607286e
URL:
https://github.com/llvm/llvm-project/commit/c7fd7512a5c5b133665bfecbe2e9748c0607286e
DIFF:
https://github.com/llvm/llvm-project/commit/c7fd7512a5c5b133665bfecbe2e9748c0607286e.d
Author: Jonas Devlieghere
Date: 2022-03-14T09:43:13-07:00
New Revision: df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9
URL:
https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9
DIFF:
https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9.d
Author: Jonas Devlieghere
Date: 2022-03-14T09:24:17-07:00
New Revision: f51d7e4bae9e861e711ad9711599456fc2f1bbca
URL:
https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca
DIFF:
https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca.d
Author: Jonas Devlieghere
Date: 2021-12-06T09:34:53-08:00
New Revision: 4cb79294e8df8c91ae15264d1014361815d34a53
URL:
https://github.com/llvm/llvm-project/commit/4cb79294e8df8c91ae15264d1014361815d34a53
DIFF:
https://github.com/llvm/llvm-project/commit/4cb79294e8df8c91ae15264d1014361815d34a53.d
Author: Jonas Devlieghere
Date: 2021-04-21T14:22:13-07:00
New Revision: 6331680ad2ad000fdaf7e72f3c1880c7908ffa25
URL:
https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25
DIFF:
https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25.d
Author: Jonas Devlieghere
Date: 2021-04-20T20:42:50-07:00
New Revision: 05eeed9691aeb3e0316712195b998e9078cdceb0
URL:
https://github.com/llvm/llvm-project/commit/05eeed9691aeb3e0316712195b998e9078cdceb0
DIFF:
https://github.com/llvm/llvm-project/commit/05eeed9691aeb3e0316712195b998e9078cdceb0.d
Author: Jonas Devlieghere
Date: 2020-10-20T13:46:44-07:00
New Revision: 27a909a24f99d4de40c4ce6553b9cd420b11c056
URL:
https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056
DIFF:
https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056.d
I've reverted this in ba2dff0159fcd1d2349bc610331914618ca9bc30 because it
also caused a build failure when building a stage 2 clang:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24177/console
FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o
/Users/buildslave/je
Author: Jonas Devlieghere
Date: 2020-10-11T20:16:46-07:00
New Revision: ba2dff0159fcd1d2349bc610331914618ca9bc30
URL:
https://github.com/llvm/llvm-project/commit/ba2dff0159fcd1d2349bc610331914618ca9bc30
DIFF:
https://github.com/llvm/llvm-project/commit/ba2dff0159fcd1d2349bc610331914618ca9bc30.d
Author: Jonas Devlieghere
Date: 2020-08-19T09:40:46-07:00
New Revision: 6b742cc48d91f35bfa98844d5add3655f33f8326
URL:
https://github.com/llvm/llvm-project/commit/6b742cc48d91f35bfa98844d5add3655f33f8326
DIFF:
https://github.com/llvm/llvm-project/commit/6b742cc48d91f35bfa98844d5add3655f33f8326.d
Author: Jonas Devlieghere
Date: 2020-08-19T09:35:08-07:00
New Revision: fc53bd610ff95d2824617095bcf4976035b4cb9a
URL:
https://github.com/llvm/llvm-project/commit/fc53bd610ff95d2824617095bcf4976035b4cb9a
DIFF:
https://github.com/llvm/llvm-project/commit/fc53bd610ff95d2824617095bcf4976035b4cb9a.d
Author: Philippe Blain
Date: 2020-06-30T09:33:20-07:00
New Revision: a1f4e48c4aca8c7339be2018926baf860a562f13
URL:
https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13
DIFF:
https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13.diff
Author: Jonas Devlieghere
Date: 2020-06-04T23:45:36-07:00
New Revision: df53f09056b0f6a91029cae5f1cdc941c21b
URL:
https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b
DIFF:
https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b.d
Hey Richard,
It appears this broke the lldb bots:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/
It's hitting an assertion in
llvm-project/clang/include/clang/AST/DeclCXX.h:887:
Assertion `(data().DefaultedCopyAssignmentIsDel
Author: Jonas Devlieghere
Date: 2020-06-04T23:45:36-07:00
New Revision: 70ad03d93818532ef19f149f8ff89bcd8af80163
URL:
https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163
DIFF:
https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163.d
Author: Jonas Devlieghere
Date: 2020-05-26T11:32:02-07:00
New Revision: a94e08d2e840a0e7ce032f59e9344bc49b5a54a1
URL:
https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1
DIFF:
https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1.d
Author: Jonas Devlieghere
Date: 2020-03-23T12:09:24-07:00
New Revision: 56abcfad70ee679ad95ab41d934491ebcaebdf7d
URL:
https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d
DIFF:
https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d.d
Author: Jonas Devlieghere
Date: 2020-03-05T21:45:20-08:00
New Revision: 45e2c6d956141618683d31a683d762aaf0e7168d
URL:
https://github.com/llvm/llvm-project/commit/45e2c6d956141618683d31a683d762aaf0e7168d
DIFF:
https://github.com/llvm/llvm-project/commit/45e2c6d956141618683d31a683d762aaf0e7168d.d
Author: Jonas Devlieghere
Date: 2020-01-29T21:27:46-08:00
New Revision: 509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e
URL:
https://github.com/llvm/llvm-project/commit/509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e
DIFF:
https://github.com/llvm/llvm-project/commit/509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e.d
Author: Jonas Devlieghere
Date: 2020-01-28T15:28:22-08:00
New Revision: 43a1c80508d17fa42c78b690d426105eaa84c539
URL:
https://github.com/llvm/llvm-project/commit/43a1c80508d17fa42c78b690d426105eaa84c539
DIFF:
https://github.com/llvm/llvm-project/commit/43a1c80508d17fa42c78b690d426105eaa84c539.d
Author: Jonas Devlieghere
Date: 2020-01-28T15:19:27-08:00
New Revision: 00d834e08719c994f12b216c7eb17bbc0c976714
URL:
https://github.com/llvm/llvm-project/commit/00d834e08719c994f12b216c7eb17bbc0c976714
DIFF:
https://github.com/llvm/llvm-project/commit/00d834e08719c994f12b216c7eb17bbc0c976714.d
Author: jdevlieghere
Date: Mon Sep 23 16:49:36 2019
New Revision: 372672
URL: http://llvm.org/viewvc/llvm-project?rev=372672&view=rev
Log:
Revert "Support for DWARF-5 C++ language tags."
This reverts commit bf9c8ffb54943c6d77398adbedddf05ef9724007.
Modified:
cfe/trunk/include/clang/AST/DeclC
Author: jdevlieghere
Date: Thu Sep 12 22:16:59 2019
New Revision: 371813
URL: http://llvm.org/viewvc/llvm-project?rev=371813&view=rev
Log:
Revert "For PR17164: split -fno-lax-vector-conversion into three different"
This breaks the LLDB build. I tried reaching out to Richard, but haven't
gotten a
Author: jdevlieghere
Date: Wed Aug 14 20:59:30 2019
New Revision: 368954
URL: http://llvm.org/viewvc/llvm-project?rev=368954&view=rev
Log:
[NFC] Update doc comment to fix warning.
This fixes the warning: parameter 'EnableNullFPSuppression' not found in
the function declaration [-Wdocumentation]
The bot is a little special in that it has modules enabled. Maybe that
explains it? Let me know if that doesn't work and I can try
reproducing locally.
On Fri, Aug 9, 2019 at 12:02 PM Gábor Horváth wrote:
>
> I reverted but I cannot reproduce this locally on a linux box. Is there any
> way to ge
I think this is causing a stage2 failure:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/124/consoleFull#-95886206949ba4694-19c4-4d7e-bec5-911270d8a58c
On Fri, Aug 9, 2019 at 10:41 AM Gabor Horvath via cfe-commits
wrote:
>
> Author: xazax
> Date: Fri Aug 9 10:42:41 2019
> New Revision:
Author: jdevlieghere
Date: Mon Jul 29 16:02:11 2019
New Revision: 367271
URL: http://llvm.org/viewvc/llvm-project?rev=367271&view=rev
Log:
[DependencyCollector] Make maybeAddDependency virtual (NFC)
Make DependencyCollector::maybeAddDependency, just like its other
methods, which I made virtual a
Author: jdevlieghere
Date: Thu Jul 18 08:17:42 2019
New Revision: 366447
URL: http://llvm.org/viewvc/llvm-project?rev=366447&view=rev
Log:
[CMake] Don't set Python_ADDITIONAL_VERSIONS
Until recently, Python_ADDITIONAL_VERSIONS was used to limit LLVM's
Python support to 2.7. Now that both LLVM and
Hi Leonard,
My personal rule of thumb is that if I can fix it in something like 30
minutes or less, I'll leave the bot red and commit a fix. Otherwise I'll
revert my change. The problem with leaving the bot red is that if something
else breaks, that person doesn't get a signal, and issue start to
Author: jdevlieghere
Date: Tue May 7 14:08:15 2019
New Revision: 360192
URL: http://llvm.org/viewvc/llvm-project?rev=360192&view=rev
Log:
Revert "[OpenMP][Clang] Support for target math functions"
This commit appears to be breaking stage-2 builds on GreenDragon. The
OpenMP wrappers for cmath and
Hi Leonard,
The test that is asserting is part of the debuginfo test. (
https://github.com/llvm-project/debuginfo-tests)
The reason that it's only failing on the non-incremental bot is because the
incremental one isn't running those, I believe.
RA stands for Release/Asserts.
Hope that helps!
Ch
Hi Leonard,
It appears that your patch is still triggering an assertion on GreenDragon:
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/56255/consoleFull#312501878d489585b-5106-414a-ac11-3ff90657619c
Can you please have a look?
Thanks,
Jonas
On Mon, May 6, 2019 at 8:17 PM Leonard
Author: jdevlieghere
Date: Tue Feb 12 13:45:14 2019
New Revision: 353882
URL: http://llvm.org/viewvc/llvm-project?rev=353882&view=rev
Log:
Make ModuleDependencyCollector's method virtual (NFC)
For reproducers in LLDB we want to hook up into the existing clang
infrastructure. To make that happen w
Author: jdevlieghere
Date: Tue Jan 29 22:26:26 2019
New Revision: 352605
URL: http://llvm.org/viewvc/llvm-project?rev=352605&view=rev
Log:
[ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC)
Use the real_path implementation from llvm::sys::fs::real_path instead
of having a custom imple
Author: jdevlieghere
Date: Mon Nov 12 08:59:50 2018
New Revision: 346675
URL: http://llvm.org/viewvc/llvm-project?rev=346675&view=rev
Log:
Revert "Make clang-based tools find libc++ on MacOS"
This breaks the LLDB bots.
Removed:
cfe/trunk/test/Tooling/Inputs/mock-libcxx/include/c++/v1/mock_ve
Author: jdevlieghere
Date: Sat Nov 10 16:56:15 2018
New Revision: 346601
URL: http://llvm.org/viewvc/llvm-project?rev=346601&view=rev
Log:
Pass the function type instead of the return type to FunctionDecl::Create
Fix places where the return type of a FunctionDecl was being used in
place of the fu
1 - 100 of 138 matches
Mail list logo
