jingyue added a comment.
Is this patch obsolete? Are you still trying to push it in?
http://reviews.llvm.org/D14000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jingyue added a comment.
I'll defer to Justin's approval.
http://reviews.llvm.org/D16870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jingyue added inline comments.
Comment at: test/SemaCUDA/function-overload.cu:138
@@ -149,3 +137,3 @@
fp_t cdhp = cdh;
- gp_t gp = g; // expected-error {{reference to __global__ function 'g' in
__global__ function}}
- // expected-note@67 {{'g' declared here}}
+
jingyue added inline comments.
Comment at: lib/Sema/SemaCUDA.cpp:132-141
@@ -131,12 +131,12 @@
// (d) HostDevice behavior depends on compilation mode.
if (CallerTarget == CFT_HostDevice) {
// Calling a function that matches compilation mode is OK.
// Calling a func
jingyue added inline comments.
Comment at: include/clang/Sema/Sema.h:8801
@@ -8798,3 +8800,3 @@
// LangOpts.CUDADisableTargetCallChecks is true.
-CFP_Fallback, // Low priority caller/callee combination
-CFP_Best, // Preferred caller/callee comb
Author: jingyue
Date: Wed Sep 30 16:49:32 2015
New Revision: 248951
URL: http://llvm.org/viewvc/llvm-project?rev=248951&view=rev
Log:
[CUDA] fix codegen for __nvvm_atom_cas_*
Summary: __nvvm_atom_cas_* returns the old value instead of whether the swap
succeeds.
Reviewers: eliben, tra
Subscribe
jingyue accepted this revision.
jingyue added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this.
http://reviews.llvm.org/D12739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: jingyue
Date: Mon Aug 31 12:25:51 2015
New Revision: 246455
URL: http://llvm.org/viewvc/llvm-project?rev=246455&view=rev
Log:
[CUDA] fix codegen for __nvvm_atom_min/max_gen_u*
Summary: Clang should emit "atomicrmw umin/umax" instead of "atomicrmw min/max".
Reviewers: eliben, tra
Subscri
Author: jingyue
Date: Sat Aug 22 00:49:28 2015
New Revision: 245786
URL: http://llvm.org/viewvc/llvm-project?rev=245786&view=rev
Log:
[CUDA] Change initializer for CUDA device code based on CUDA documentation.
Summary:
According to CUDA documentation, global variables declared with __device__,
__
