[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

2022-11-28 Thread Jeff Sandoval via Phabricator via cfe-commits
sandoval added a comment. Overall this approach looks good to me, though I'd suggest some (hopefully minor) changes that would help avoid breaking the ABI. It looks like `__tgt_bin_desc` is only used by `__tgt_[un]register_lib` -- rather than changing those entry points, can you please add new

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

2022-01-21 Thread Jeff Sandoval via Phabricator via cfe-commits
sandoval added a comment. I don't see a clear explain the motivation for this change - can you confirm my understanding or provide clarification? It looks like the issue is that D110337 caused a regression for cases when user code directly calls a device libr