Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-09-16 Thread Jason Turner via cfe-commits
lefticus updated this revision to Diff 71668. lefticus added a comment. Add C++1z check around constexpr tests, based on mclow's feedback https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/containers/sequences/a

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-08-24 Thread Jason Turner via cfe-commits
lefticus updated this revision to Diff 69195. lefticus added a comment. Address formatting concerns and out-of-date-ness of patch relative to trunk/master https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/cont

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-25 Thread Jason Turner via cfe-commits
lefticus added a comment. I believe all or most of the "untested" comments are correctly tested in the updated test files via static_asserts with contexpr. I've commented on just the first one to make sure I understand correctly. Comment at: include/array:156 @@ -155,3 +155,3

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-25 Thread Jason Turner via cfe-commits
lefticus updated this revision to Diff 65398. lefticus added a comment. Correct context from last patch https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/containers/sequences/array/begin.pass.cpp test/std/con

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-25 Thread Jason Turner via cfe-commits
lefticus added a comment. I believe I messed up the context for the files, will attempt to resubmit the patch. https://reviews.llvm.org/D22584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-25 Thread Jason Turner via cfe-commits
lefticus marked 3 inline comments as done. lefticus added a comment. https://reviews.llvm.org/D22584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-25 Thread Jason Turner via cfe-commits
lefticus updated this revision to Diff 65390. lefticus added a comment. Fixed syntax errors in test files. https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/containers/sequences/array/begin.pass.cpp test/std/

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

2016-07-22 Thread Jason Turner via cfe-commits
lefticus retitled this revision from "C++1z constexpr support for array and iterator" to "constexpr array support C++1z (P0031)". lefticus updated the summary for this revision. lefticus updated this revision to Diff 65143. lefticus added a comment. - Updated title and summary to be more accurate