[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

2019-01-15 Thread James Dennett via Phabricator via cfe-commits
jdennett added a comment. In D56731#1358907 , @Quuxplusone wrote: > For my own use-cases, I will continue to want a 100% comprehensive `-Wctad`. > All these "heuristics" you're proposing seem very ad-hoc, and make a lot of > work for the compiler vendor,

r337431 - Documentation: fix a typo in the AST Matcher Reference docs.

2018-07-18 Thread James Dennett via cfe-commits
Author: jdennett Date: Wed Jul 18 16:21:31 2018 New Revision: 337431 URL: http://llvm.org/viewvc/llvm-project?rev=337431&view=rev Log: Documentation: fix a typo in the AST Matcher Reference docs. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/AS

r324142 - More documentation cleanup for Decl.h.

2018-02-02 Thread James Dennett via cfe-commits
Author: jdennett Date: Fri Feb 2 13:38:22 2018 New Revision: 324142 URL: http://llvm.org/viewvc/llvm-project?rev=324142&view=rev Log: More documentation cleanup for Decl.h. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/viewvc

r324133 - Documentation cleanup, no functional change.

2018-02-02 Thread James Dennett via cfe-commits
Author: jdennett Date: Fri Feb 2 12:22:29 2018 New Revision: 324133 URL: http://llvm.org/viewvc/llvm-project?rev=324133&view=rev Log: Documentation cleanup, no functional change. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h URL: http://llvm.org/

[clang-tools-extra] r290838 - Extend documentation of how to test clang-tidy checks.

2017-01-02 Thread James Dennett via cfe-commits
Author: jdennett Date: Mon Jan 2 15:45:34 2017 New Revision: 290838 URL: http://llvm.org/viewvc/llvm-project?rev=290838&view=rev Log: Extend documentation of how to test clang-tidy checks. Summary: The documentation assumed expertise with FileCheck; many clang-tidy check authors may not have sig

[PATCH] D28189: Extend documentation of how to test clang-tidy checks.

2017-01-02 Thread James Dennett via Phabricator via cfe-commits
jdennett updated this revision to Diff 82818. jdennett added a comment. Addressed review comments: double-backtick quoting, underscores for references to FileCheck, and change "matcher tests" to "clang-tidy tests". https://reviews.llvm.org/D28189 Files: docs/clang-tidy/index.rst Index: docs

[PATCH] D28189: Extend documentation of how to test clang-tidy checks.

2017-01-02 Thread James Dennett via Phabricator via cfe-commits
jdennett marked 2 inline comments as done. jdennett added a comment. Thanks for the review. I've address your comments, and will check over the (presumed-final) diff before submitting. Comment at: docs/clang-tidy/index.rst:558 +typically the basic `CHECK` forms (`CHECK-MESSAG

r290777 - Typo fix in AST matcher documentation: s/aribtrary/arbitrary/

2016-12-30 Thread James Dennett via cfe-commits
Author: jdennett Date: Fri Dec 30 19:04:02 2016 New Revision: 290777 URL: http://llvm.org/viewvc/llvm-project?rev=290777&view=rev Log: Typo fix in AST matcher documentation: s/aribtrary/arbitrary/ Modified: cfe/trunk/docs/LibASTMatchers.rst Modified: cfe/trunk/docs/LibASTMatchers.rst URL: h

Re: r251738 - [MSVC Compat] Permit conversions from pointer-to-function to pointer-to-object iff -fms-compatibility

2015-11-01 Thread James Dennett via cfe-commits
On Sat, Oct 31, 2015 at 5:50 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I think we more commonly say "function pointer": > > $ grep 'pointer-to-function' include/clang/Basic/Diagnostic*td | wc -l >3 > $ grep 'function pointer' include/clang/Basic/Diagnostic*td |

r244124 - Documentation: fix another typo, "arrays types" -> "array types".

2015-08-05 Thread James Dennett
Author: jdennett Date: Wed Aug 5 15:58:23 2015 New Revision: 244124 URL: http://llvm.org/viewvc/llvm-project?rev=244124&view=rev Log: Documentation: fix another typo, "arrays types" -> "array types". Thanks to Kim Gräsman for pointing this out. Modified: cfe/trunk/include/clang/AST/PrettyP

r244104 - Documentation: fix a typo, "This flag is determines" -> "This flag determines".

2015-08-05 Thread James Dennett
Author: jdennett Date: Wed Aug 5 14:44:47 2015 New Revision: 244104 URL: http://llvm.org/viewvc/llvm-project?rev=244104&view=rev Log: Documentation: fix a typo, "This flag is determines" -> "This flag determines". No functional change. Modified: cfe/trunk/include/clang/AST/PrettyPrinter.h