lamb-j wrote:
Could we possibly do a phase-out approach?
For COV5 and earlier we keep the current strategy, allowing both 3 and 4 field
triples
For COV6 (including generics), we enforce the 4 field triples
This could help us not break things internally, and then as tools and APIs
update to V
lamb-j wrote:
https://github.com/search?q=org%3AROCm%20clang-offload-bundler&type=code
So at least a few direct users this may break things for. There are also users
that call the OffloadBundler API instead of directly calling
clang-offload-bundler that this may impact.
Could we assume "gfx *
lamb-j wrote:
Is there a way for us to still support 3-field triples and generic targets?
In the past we worked to allow 3-field triples as bundler inputs. I would be
surprised if adding a 4-field restriction didn't break something internally.
https://github.com/llvm/llvm-project/pull/122629
_
lamb-j wrote:
Should be fixed with
https://github.com/llvm/llvm-project/commit/982c54719289c1d85d03be3ad9e95bbfd2862aee
https://github.com/llvm/llvm-project/pull/96951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/97115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/97115
Follow up to
https://github.com/llvm/llvm-project/commit/2264544e2d13957f36fd19864d9633a3278a9d74
>From 6131f15194e0f97fea381d896f5f9847ad4ba786 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Fri, 28 Jun 202
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/96951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/96951
We have reworked the bitcode linking option to no longer link twice if
post-optimization linking is requested. As such, we no longer need to
conditionally link bitcodes supplied via -mlink-bitcode-file, as there
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/92294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/92294
None
>From cbeb6bcbd4442af709823af75ca82a2d33be9482 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 15 May 2024 10:12:45 -0700
Subject: [PATCH] [NFC][amdgpuarch] Correct file names in file header comments
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/92027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lamb-j wrote:
https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fapinotes
https://github.com/llvm/llvm-project/pull/92027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/92027
None
>From b68e9e234c1ccd62be507fcb1a0ab77241216f75 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 13 May 2024 13:24:48 -0700
Subject: [PATCH] [NFC] Add missing spaces in BoolOption for apinotes
---
cl
lamb-j wrote:
https://github.com/llvm/llvm-project/pull/91495
Follow up PR to fix warning with now-unused private variable in BackendConsumer
class (FileMgr)
https://github.com/llvm/llvm-project/pull/85672
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/91495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/91495
>From 4c687db250dabbc13557df46433a3c1cb3dff01e Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 8 May 2024 08:52:14 -0700
Subject: [PATCH 1/2] [clang][CodeGen] Remove now-unused FileManager variable
Fixes
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/91495
Fixes "error: private field 'FileMgr' is not used"
>From 4c687db250dabbc13557df46433a3c1cb3dff01e Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 8 May 2024 08:52:14 -0700
Subject: [PATCH] [clang][CodeGen
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/85672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/7] [clang][CodeGen] Omit pre-opt link when post-opt link
request
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/85672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lamb-j wrote:
Switched the option from a cl::opt to a Clang/CodeGen option.
Also added a LIT test which tests both -mlink-builtin-bitcode-postopt and
-mno-link-builtin-bitcode-postopt
https://github.com/llvm/llvm-project/pull/85672
___
cfe-commits ma
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/6] [clang][CodeGen] Omit pre-opt link when post-opt link
request
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/5] [clang][CodeGen] Omit pre-opt link when post-opt link
request
lamb-j wrote:
> @lamb-j I appreciate your carrying out these performance tests!
>
> Would you be open to providing an option to enable post-link optimization
> that could be off by default for now?
Currently if a user doesn't supply the new "-link-builtin-bitcodes-postopt"
option, linking bui
lamb-j wrote:
I've been working on testing this patch with an array of OpenCL benchmarks over
the past month. We did some high-level regression testing with the following
benchmarks:
BlackMagic
Linpack_Dgemm
babelstream-Double
babelstream-Float
chimex
clfft
clmem
clpeak-Double-precision comput
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/5] [clang][CodeGen] Omit pre-opt link when post-opt link
request
@@ -28,12 +28,8 @@ PreservedAnalyses LinkInModulesPass::run(Module &M,
ModuleAnalysisManager &AM) {
if (!BC)
return PreservedAnalyses::all();
- // Re-load bitcode modules from files
- if (BC->ReloadModules(&M))
-report_fatal_error("Bitcode module re-loading failed
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/4] [clang][CodeGen] Omit pre-opt link when post-opt link
request
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/3] [clang][CodeGen] Omit pre-opt link when post-opt link
request
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/85672
>From aff1a762a73ce30cde38a6fcbbed8a3e4f0b5366 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Mon, 18 Mar 2024 10:19:38 -0700
Subject: [PATCH 1/2] [clang][CodeGen] Omit pre-opt link when post-opt link
request
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/85672
Currently, when the -relink-builtin-bitcodes-postop option is used we link
builtin bitcodes twice: once before optimization, and again after optimization.
With this change, we omit the pre-opt linking when the op
@@ -257,37 +281,19 @@ bool BackendConsumer::LinkInModules(llvm::Module *M, bool
ShouldLinkFiles) {
CurLinkModule = LM.Module.get();
bool Err;
lamb-j wrote:
Oversight on my part. Should be fixed by
https://github.com/llvm/llvm-project/pull/81777
https
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/81777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/81777
Add missing error check. This resolves "error: variable 'Err' set but not used"
warnings
>From b802c3456e44d5cc39ce6d5bf93fc549e38a7a12 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 14 Feb 2024 11:04:0
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/81693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/81693
>From aff288af78b94dbd7ef317ce368f25a305798adc Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 13 Feb 2024 17:30:21 -0800
Subject: [PATCH 1/3] [clang][CodeGen] Shift relink option implementation away
from
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/81693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/81693
>From aff288af78b94dbd7ef317ce368f25a305798adc Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 13 Feb 2024 17:30:21 -0800
Subject: [PATCH 1/2] [clang][CodeGen] Shift relink option implementation away
from
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/81693
We recently implemented a new option allowing relinking of bitcode modules via
the "-mllvm -relink-builtin-bitcode-postop" option.
This implementation relied on llvm::CloneModule() in order to pass copies to
mod
@@ -5392,7 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group,
MarshallingInfoFlag>;
def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>,
Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
- HelpText<"Save intermediate compilatio
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/80921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/80921
>From 9f021f6d2b99ae73c47313ddc6043ab2af926f23 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 6 Feb 2024 17:57:12 -0800
Subject: [PATCH 1/2] [NFC][clang][Driver] Specify options for with
-save-temps=
-
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/80921
None
>From 9f021f6d2b99ae73c47313ddc6043ab2af926f23 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 6 Feb 2024 17:57:12 -0800
Subject: [PATCH] [NFC][clang][Driver] Specify options for with
-save-temps=
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/73968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/73968
None
>From 5582993e9c9aadf30ca2780cd37a280fe32fb439 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Thu, 30 Nov 2023 10:25:55 -0800
Subject: [PATCH] [clang-offload-bundler][NFC] Remove blank line in doc
---
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/73709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/73709
>From 995706601f9f4aed021a9003ad79ca3e7e1d18af Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 28 Nov 2023 14:42:11 -0800
Subject: [PATCH 1/7] [clang-offload-bundler] Add support for
-check-input-archive
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/73709
>From 995706601f9f4aed021a9003ad79ca3e7e1d18af Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 28 Nov 2023 14:42:11 -0800
Subject: [PATCH 1/5] [clang-offload-bundler] Add support for
-check-input-archive
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/72478
>From 5bfc0608073cd699e42a23b07d68b4572a14fcbd Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 15 Nov 2023 22:06:46 -0800
Subject: [PATCH 1/5] [CodeGen] Add conditional to module cloning in bitcode
linkin
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/72478
>From 7d2ee902f1fb1dc0cd355b4b51fda32309f45ccb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 15 Nov 2023 22:06:46 -0800
Subject: [PATCH 1/5] [CodeGen] Add conditional to module cloning in bitcode
linkin
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/73709
>From e69976a8923b134e051dd2756233c0285d3c9880 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 28 Nov 2023 14:42:11 -0800
Subject: [PATCH 1/4] [clang-offload-bundler] Add support for
-check-input-archive
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/73709
>From e69976a8923b134e051dd2756233c0285d3c9880 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 28 Nov 2023 14:42:11 -0800
Subject: [PATCH 1/3] [clang-offload-bundler] Add support for
-check-input-archive
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/73709
>From e69976a8923b134e051dd2756233c0285d3c9880 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 28 Nov 2023 14:42:11 -0800
Subject: [PATCH 1/2] [clang-offload-bundler] Add support for
-check-input-archive
lamb-j wrote:
For context, these changes reconcile differences between the upstream
clang-offload-bundler and the AMD Fork offload bundler
(https://github.com/RadeonOpenCompute/llvm-project/tree/amd-stg-open)
https://github.com/llvm/llvm-project/pull/73709
_
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/73709
In this patch, we add support for checking a heterogeneous archive. We also
significantly improve the clang-offload-bundler documentation.
>From e69976a8923b134e051dd2756233c0285d3c9880 Mon Sep 17 00:00:00 2001
F
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/72478
>From 3a2a066eeadce6b8f3cd5645965ffe564e68fba3 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 15 Nov 2023 22:06:46 -0800
Subject: [PATCH 1/3] [CodeGen] Add conditional to module cloning in bitcode
linkin
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/72478
>From 3a2a066eeadce6b8f3cd5645965ffe564e68fba3 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 15 Nov 2023 22:06:46 -0800
Subject: [PATCH 1/2] [CodeGen] Add conditional to module cloning in bitcode
linkin
@@ -251,32 +255,50 @@ bool BackendConsumer::LinkInModules(llvm::Module *M, bool
ShouldLinkFiles) {
}
CurLinkModule = LM.Module.get();
-
-// TODO: If CloneModule() is updated to support cloning of unmaterialized
-// modules, we can remove this
bool Err;
@@ -48,428 +49,365 @@
#include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/YAMLTraits.h"
#include "llvm/Transforms/IPO/Internalize.h"
+#include "llvm/Transforms/Utils/Cloning.h"
-#include
#include
using namespace clang;
using namespace llvm;
#define DEBUG_T
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/72478
Now that we have a commandline option dictating a second link step,
(-relink-builtin-bitcode-postop), we can condition the module creation when
linking in bitcode modules. This aims to improve performance by avoi
@@ -48,428 +49,365 @@
#include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/YAMLTraits.h"
#include "llvm/Transforms/IPO/Internalize.h"
+#include "llvm/Transforms/Utils/Cloning.h"
-#include
#include
using namespace clang;
using namespace llvm;
#define DEBUG_T
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -113,7 +120,7 @@ class EmitAssemblyHelper {
const CodeGenOptions &CodeGenOpts;
const clang::TargetOptions &TargetOpts;
const LangOptions &LangOpts;
- Module *TheModule;
+ llvm::Module *TheModule;
lamb-j wrote:
Without the qualification, we get the f
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -113,7 +120,7 @@ class EmitAssemblyHelper {
const CodeGenOptions &CodeGenOpts;
const clang::TargetOptions &TargetOpts;
const LangOptions &LangOpts;
- Module *TheModule;
+ llvm::Module *TheModule;
lamb-j wrote:
When including the new BackendConsumer.
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 0de3e4a4b460ba407da1acbcf4ef21916ded69e2 Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 86535608c7e79d31260e2a358b7a00f7b747e8bd Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
lamb-j wrote:
> this doesn't really apply since you changed the function signature so it
> needs to be reformatted.
I don't follow the logic there. The function signature can have a style as
well. And I think this is actually a good example to demonstrate a reason not
to reformat if we look a
lamb-j wrote:
>
> Just do what the formatter says, not every file is 100% clang-formatted so
> there's bits of old code that haven't been properly cleaned yet. This was the
> same line that I thought looked wrong so it should probably be fixed. Using
> `git clang-format HEAD~1` only formats w
lamb-j wrote:
I am getting this from the formatter:
- void RunOptimizationPipeline(BackendAction Action,
- std::unique_ptr &OS,
- std::unique_ptr &ThinLinkOS,
- BackendConsumer *BC);
+ void RunOptimizationPipeline(
+
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
@@ -0,0 +1,29 @@
+//===-- LinkInModulesPass.cpp - Module Linking pass --- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j edited https://github.com/llvm/llvm-project/pull/69371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -48,428 +49,369 @@
#include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/YAMLTraits.h"
#include "llvm/Transforms/IPO/Internalize.h"
+#include "llvm/Transforms/Utils/Cloning.h"
-#include
#include
using namespace clang;
using namespace llvm;
#define DEBUG_T
@@ -155,10 +162,10 @@ class EmitAssemblyHelper {
return F;
}
- void
- RunOptimizationPipeline(BackendAction Action,
+ void RunOptimizationPipeline(BackendAction Action,
std::unique_ptr &OS,
- std::unique_ptr &ThinLin
@@ -1035,6 +1043,13 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
}
}
+ // Re-link against any bitcodes supplied via the -mlink-builtin-bitcode
option
+ // Some optimizations may generate new function calls that would not have
+ // been linked pre-optimization
@@ -1035,6 +1043,13 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
}
}
+ // Re-link against any bitcodes supplied via the -mlink-builtin-bitcode
option
+ // Some optimizations may generate new function calls that would not have
+ // been linked pre-optimization
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/69371
>From 25302c315360c166f34ab9acde2561dc7865b3bb Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Tue, 17 Oct 2023 12:01:15 -0700
Subject: [PATCH 1/3] [NFC] Refactor BackendConsumer class definition into new
head
lamb-j wrote:
> This approach assumes that whatever the function call was transformed into
> also exists in the same library, which isn't necessarily true.
True, good point. But I don't think it's necessarily due to this approach, but
more of how AMDGPULibCalls is implemented. It seems like th
lamb-j wrote:
sincos() is just one example. There are several other cases that can trigger
this issue. fold_rootn() generates new function calls for square and cubic
roots, fold_pow() does a similar thing for specific powers (ex 2)
We did try disabling -llvm-prelink, and it did lead to a signi
https://github.com/lamb-j created
https://github.com/llvm/llvm-project/pull/69371
This set of patches updates device library linking and optimization to do the
following:
Link
Optimize
Link (New)
This handles the edge case where optimization introduces new device library
functions, such as a
Author: Jacob Lambert
Date: 2023-08-23T12:25:01-07:00
New Revision: 0661533e4168202476d660d3b18bbe13db16cc43
URL:
https://github.com/llvm/llvm-project/commit/0661533e4168202476d660d3b18bbe13db16cc43
DIFF:
https://github.com/llvm/llvm-project/commit/0661533e4168202476d660d3b18bbe13db16cc43.diff
Author: Jacob Lambert
Date: 2023-03-14T19:51:26-07:00
New Revision: f3b9912026894ecca8925c974dd7ca16b0f1e265
URL:
https://github.com/llvm/llvm-project/commit/f3b9912026894ecca8925c974dd7ca16b0f1e265
DIFF:
https://github.com/llvm/llvm-project/commit/f3b9912026894ecca8925c974dd7ca16b0f1e265.diff
Author: Jacob Lambert
Date: 2023-03-14T19:14:42-07:00
New Revision: 65fb636bd462687980935979f2f36ec992e15c84
URL:
https://github.com/llvm/llvm-project/commit/65fb636bd462687980935979f2f36ec992e15c84
DIFF:
https://github.com/llvm/llvm-project/commit/65fb636bd462687980935979f2f36ec992e15c84.diff
Author: Jacob Lambert
Date: 2023-03-14T14:12:31-07:00
New Revision: e48ae0dbd80d58ce8eded9e55f0b1262d52517af
URL:
https://github.com/llvm/llvm-project/commit/e48ae0dbd80d58ce8eded9e55f0b1262d52517af
DIFF:
https://github.com/llvm/llvm-project/commit/e48ae0dbd80d58ce8eded9e55f0b1262d52517af.diff
Author: Jacob Lambert
Date: 2023-03-13T16:19:31-07:00
New Revision: b47d4df25c696739dbbb9e373ffd8a501eabcfef
URL:
https://github.com/llvm/llvm-project/commit/b47d4df25c696739dbbb9e373ffd8a501eabcfef
DIFF:
https://github.com/llvm/llvm-project/commit/b47d4df25c696739dbbb9e373ffd8a501eabcfef.diff
Author: Jacob Lambert
Date: 2022-12-07T11:50:11-08:00
New Revision: f9de860ca4c4b5827498dc096a26d9ebdf236181
URL:
https://github.com/llvm/llvm-project/commit/f9de860ca4c4b5827498dc096a26d9ebdf236181
DIFF:
https://github.com/llvm/llvm-project/commit/f9de860ca4c4b5827498dc096a26d9ebdf236181.diff
Author: Jacob Lambert
Date: 2022-12-05T15:39:09-08:00
New Revision: 6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521
URL:
https://github.com/llvm/llvm-project/commit/6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521
DIFF:
https://github.com/llvm/llvm-project/commit/6b992bcce0c5a86f57c83dd8d0ac9e63bcfc5521.diff
Author: Jacob Lambert
Date: 2022-07-27T11:54:38-07:00
New Revision: 0f3f357e26cfdb887866215b234138e66fd0c4c9
URL:
https://github.com/llvm/llvm-project/commit/0f3f357e26cfdb887866215b234138e66fd0c4c9
DIFF:
https://github.com/llvm/llvm-project/commit/0f3f357e26cfdb887866215b234138e66fd0c4c9.diff
Author: Jacob Lambert
Date: 2022-07-26T10:05:22-07:00
New Revision: 8348c4095600ec2c0beee293267832799d2ebee3
URL:
https://github.com/llvm/llvm-project/commit/8348c4095600ec2c0beee293267832799d2ebee3
DIFF:
https://github.com/llvm/llvm-project/commit/8348c4095600ec2c0beee293267832799d2ebee3.diff
Author: Jacob Lambert
Date: 2022-04-21T09:24:33-07:00
New Revision: afcc6baac52fcc91d1636f6803f5c230e7018016
URL:
https://github.com/llvm/llvm-project/commit/afcc6baac52fcc91d1636f6803f5c230e7018016
DIFF:
https://github.com/llvm/llvm-project/commit/afcc6baac52fcc91d1636f6803f5c230e7018016.diff
1 - 100 of 101 matches
Mail list logo
