[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

2019-08-12 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google added a comment. Overall direction looks good to me as well. Ditto that tests would be useful just to make it clearer how this is represented in IR. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h:47 + MVT getPointerTy(const DataLayout &DL,

[PATCH] D48443: [WIP] Add no-prototype attribute to prototype-less C functions

2018-06-21 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google added a comment. Looks very reasonable and straightforward. LGTM in spirit, but I'll wait for someone who knows Clang better. Repository: rC Clang https://reviews.llvm.org/D48443 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

2017-08-22 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google updated this revision to Diff 112193. jgravelle-google added a comment. - Undo refactor, just change name https://reviews.llvm.org/D36989 Files: test/Tooling/clang-diff-topdown.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp ==

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

2017-08-22 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google added a comment. If you have more stop-after options it'd probably be simpler to leave it as one field. I'll just rename it to "stop-diff-after" to avoid the name collision. https://reviews.llvm.org/D36989 ___ cfe-commits mailing l

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

2017-08-21 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google created this revision. Herald added subscribers: aheejin, klimek. Rename stop-after to stop-after-topdown. When building LLVM with -DLLVM_BUILD_LLVM_DYLIB=ON, stop-after collides with the stop-after already present in LLVM. This also refactors the flag to a boolean, to reflect th

[PATCH] D29778: Declare lgamma library builtins as never being const

2017-02-15 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google marked an inline comment as done. jgravelle-google added a comment. Thanks, added a comment https://reviews.llvm.org/D29778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29778: Declare lgamma library builtins as never being const

2017-02-15 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google updated this revision to Diff 88629. jgravelle-google added a comment. - Add comment to lgamma builtins https://reviews.llvm.org/D29778 Files: include/clang/Basic/Builtins.def test/CodeGen/libcall-declarations.c Index: test/CodeGen/libcall-declarations.c =

[PATCH] D29778: Declare lgamma library builtins as never being const

2017-02-09 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google created this revision. POSIX requires lgamma writes to an external global variable, signgam. This prevents annotating lgamma with readnone, which is incorrect on targets that write to signgam. https://reviews.llvm.org/D29778 Files: include/clang/Basic/Builtins.def test/Code

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-09 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google added a comment. https://clang.llvm.org/compatibility.html doesn't mention anything about POSIX, only C11 compliance, so I didn't think Clang in general cared about POSIX. That being said I can definitely agree that Clang shouldn't preclude POSIX. I'll open a more-general diff.

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-08 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google created this revision. Herald added a subscriber: jfb. Current WebAssembly implementations use musl libc, which writes to signgam in its lgamma functions. We want the rest of the builtins to be const under -fno-math-errno, so overwrite lgamma's builtin definitions to be never-cons

[PATCH] D28381: [WebAssembly] Always inline atomics

2017-01-13 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google abandoned this revision. jgravelle-google added a comment. Abandoning this in favor of https://github.com/kripken/emscripten/pull/4846 https://reviews.llvm.org/D28381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D28381: [WebAssembly] Always inline atomics

2017-01-06 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google added a comment. In https://reviews.llvm.org/D28381#637915, @sunfish wrote: > Would it be difficult to enable atomic.c in Emscripten's compiler-rt build, > to define these libcalls (assuming that the problem is just that they're not > currently defined)? Tried it and it seems

[PATCH] D28381: [WebAssembly] Always inline atomics

2017-01-05 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google created this revision. jgravelle-google added reviewers: dschuff, sunfish. jgravelle-google added a subscriber: cfe-commits. Herald added a subscriber: jfb. Wasm MVP doesn't have any mechanism to respect atomicity. Skip emitting libcalls for the time being. https://reviews.llvm.