https://github.com/ichaer edited
https://github.com/llvm/llvm-project/pull/111513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ichaer edited
https://github.com/llvm/llvm-project/pull/111513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/111513
>From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 8 Oct 2024 10:52:13 +0100
Subject: [PATCH 1/7] [clang-format] Add CI check confirming
ClangFormatStyleOptions.r
ichaer wrote:
> @ichaer I suggest that you split the workflow part to another patch so that
> we can get the cmake part approved.
It's a bit sad, but I get your point, let's make it more focused.
https://github.com/llvm/llvm-project/pull/111513
___
@@ -53,3 +53,10 @@ foreach (file IN LISTS files)
endforeach ()
add_custom_target(clang-format-check-format DEPENDS ${check_format_depends})
+
+add_custom_target(clang-format-style-options
+COMMAND "${Python3_EXECUTABLE}" dump_format_style.py
+WORKING_DIRECTORY "${CMAKE
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/111513
>From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 8 Oct 2024 10:52:13 +0100
Subject: [PATCH 1/6] [clang-format] Add CI check confirming
ClangFormatStyleOptions.r
ichaer wrote:
> It would be nice if I didn't have to run step 4 manually.
Got it! So ideally we'd move `clang-format-style-options` lower down the stack,
to a target shared between `clang-format` and `FormatTests`.
I've made it a dependency of the `clangFormat` library, let me know what you
t
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/111513
>From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 8 Oct 2024 10:52:13 +0100
Subject: [PATCH 1/5] [clang-format] Add CI check confirming
ClangFormatStyleOptions.r
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/9] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/9] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
ichaer wrote:
> IMO it would be more helpful to add the build target to
> lib/Format/CMakeLists.txt instead. For example,
```
$ ninja FormatTests
```
Moving the target from `clang/docs/CMakeLists.txt` to
`lib/Format/CMakeLists.txt` sounds great to me, but the testing part of the
thing relies
ichaer wrote:
> So I'd prefer to see a patch doing that rather than just asserting that it is
> the same.
@boomanaiden154, I'm willing to do that, but could we confirm with a
clang-format maintainer first? In the course of that code review I referenced
[I did introduce an error in the documen
ichaer wrote:
> The documentation build workflow is not really the correct place to put this.
Yeah, I agree, but I couldn't find a place which looked correct :sweat_smile:.
This thing of adding built artifacts to the repo always introduces sadness...
the documentation build workflow looked lik
https://github.com/ichaer ready_for_review
https://github.com/llvm/llvm-project/pull/111513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichaer wrote:
@owenca, see what you think.
https://github.com/llvm/llvm-project/pull/111513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/111513
>From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 8 Oct 2024 10:52:13 +0100
Subject: [PATCH 1/4] [clang-format] Add CI check confirming
ClangFormatStyleOptions.r
ichaer wrote:
Sample failure:
https://github.com/llvm/llvm-project/actions/runs/11233429933/job/31227131778?pr=111513#step:10:127
https://github.com/llvm/llvm-project/pull/111513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/111513
>From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 8 Oct 2024 10:52:13 +0100
Subject: [PATCH 1/4] [clang-format] Add CI check confirming
ClangFormatStyleOptions.r
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/111513
>From 7db80ba448fe4f434362de505330f504b9362844 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 8 Oct 2024 10:52:13 +0100
Subject: [PATCH 1/3] [clang-format] Add CI check confirming
ClangFormatStyleOptions.r
https://github.com/ichaer created
https://github.com/llvm/llvm-project/pull/111513
* Create a new `clang-format-style-options` build target which re-generates
ClangFormatStyleOptions.rst from its source header files.
* Add CI check confirming that the repository's ClangFormatStyleOptions.rst is
ichaer wrote:
@mydeveloperday?
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5272,22 +5272,46 @@ the configuration (without a prefix: ``Auto``).
.. _ReflowComments:
-**ReflowComments** (``Boolean``) :versionbadge:`clang-format 3.8` :ref:`¶
`
- If ``true``, clang-format will attempt to re-flow comments. That is it
- will touch a comment and *ref
ichaer wrote:
@mydeveloperday, what do you think, is this good to merge?
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -493,9 +493,36 @@ TEST_F(FormatTestComments, AlignsBlockComments) {
TEST_F(FormatTestComments, CommentReflowingCanBeTurnedOff) {
FormatStyle Style = getLLVMStyleWithColumns(20);
- Style.ReflowComments = false;
- verifyFormat("// a aa aa", Style);
@@ -5272,22 +5272,46 @@ the configuration (without a prefix: ``Auto``).
.. _ReflowComments:
-**ReflowComments** (``Boolean``) :versionbadge:`clang-format 3.8` :ref:`¶
`
- If ``true``, clang-format will attempt to re-flow comments. That is it
- will touch a comment and *ref
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/8] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
@@ -493,9 +493,36 @@ TEST_F(FormatTestComments, AlignsBlockComments) {
TEST_F(FormatTestComments, CommentReflowingCanBeTurnedOff) {
FormatStyle Style = getLLVMStyleWithColumns(20);
- Style.ReflowComments = false;
- verifyFormat("// a aa aa", Style);
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/7] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
https://github.com/ichaer edited https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ichaer edited https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ichaer edited https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5204,22 +5204,46 @@ the configuration (without a prefix: ``Auto``).
.. _ReflowComments:
-**ReflowComments** (``Boolean``) :versionbadge:`clang-format 3.8` :ref:`¶
`
- If ``true``, clang-format will attempt to re-flow comments. That is it
- will touch a comment and *ref
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/6] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
@@ -5204,22 +5204,46 @@ the configuration (without a prefix: ``Auto``).
.. _ReflowComments:
-**ReflowComments** (``Boolean``) :versionbadge:`clang-format 3.8` :ref:`¶
`
- If ``true``, clang-format will attempt to re-flow comments. That is it
- will touch a comment and *ref
ichaer wrote:
Hi @mydeveloperday, any more feedback?
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichaer wrote:
@mydeveloperday, @HazardyKnusperkeks, do you have any more feedback?
I just noticed I didn't share this information before, but this is
functionality Splunk is using internally to ensure `clang-format` fixes the
indentation of our legacy doxygen comments without breaking their in
https://github.com/ichaer edited https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5204,22 +5204,46 @@ the configuration (without a prefix: ``Auto``).
.. _ReflowComments:
-**ReflowComments** (``Boolean``) :versionbadge:`clang-format 3.8` :ref:`¶
`
- If ``true``, clang-format will attempt to re-flow comments. That is it
- will touch a comment and *ref
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/5] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/4] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
@@ -493,9 +493,25 @@ TEST_F(FormatTestComments, AlignsBlockComments) {
TEST_F(FormatTestComments, CommentReflowingCanBeTurnedOff) {
FormatStyle Style = getLLVMStyleWithColumns(20);
- Style.ReflowComments = false;
- verifyFormat("// a aa aa", Style);
@@ -3749,24 +3749,47 @@ struct FormatStyle {
/// \version 13
ReferenceAlignmentStyle ReferenceAlignment;
- // clang-format off
- /// If ``true``, clang-format will attempt to re-flow comments. That is it
- /// will touch a comment and *reflow* long comments into new lin
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/3] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
ichaer wrote:
Thanks, @mydeveloperday :). That made me realise I had to fix the comments as
well, I think they are OK now. Let me know what you think.
https://github.com/llvm/llvm-project/pull/96804
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/96804
>From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Wed, 13 Dec 2023 21:33:05 +
Subject: [PATCH 1/2] [clang-format] Introduce "ReflowComments: IndentOnly" to
re-inde
https://github.com/ichaer created
https://github.com/llvm/llvm-project/pull/96804
* Convert `ReflowComments` from boolean into a new `enum` which can take on the
value `RCS_Never`, `RCS_IndentOnly`, or `RCS_Always`. The first one is
equivalent to the old `false`, the third one is `true`, and t
ichaer wrote:
Sorry for all the noise, I'll work through the CI failures in a private PR... I
thought I had a good handle on the tests being executed, but clearly I was
mistaken :sweat_smile:
https://github.com/llvm/llvm-project/pull/75230
___
cfe-c
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/75230
>From b65415f5b70591eae965cae1316054145d399158 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 17 Oct 2023 13:52:13 +0100
Subject: [PATCH 01/16] [libc++][test] Add lower_bound complexity validation
tests pri
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/75230
>From b65415f5b70591eae965cae1316054145d399158 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 17 Oct 2023 13:52:13 +0100
Subject: [PATCH 01/14] [libc++][test] Add lower_bound complexity validation
tests pri
https://github.com/ichaer updated
https://github.com/llvm/llvm-project/pull/75230
>From b65415f5b70591eae965cae1316054145d399158 Mon Sep 17 00:00:00 2001
From: Iuri Chaer
Date: Tue, 17 Oct 2023 13:52:13 +0100
Subject: [PATCH 01/14] [libc++][test] Add lower_bound complexity validation
tests pri
50 matches
Mail list logo
