[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart added a comment. Thank you for the comment, it's very helpful. I didn't know exactly how to get all operator token locations and `getCXXOperatorNameRange()`. This is going to be extremely helpful and will clean up the code to make it more readable. Thank you for the detailed list

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart requested review of this revision. iannisdezwart added a comment. Would be nice if this can further be reviewed and commited to the repo! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 ___

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart updated this revision to Diff 406452. iannisdezwart added a comment. Fixed formatting & reverted a deleted FIXME comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart accepted this revision. iannisdezwart added a comment. This revision is now accepted and ready to land. In D119077#3300271 , @nridge wrote: > I haven't looked at the patch in detail, but one high level question: have > you considered the po

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart updated this revision to Diff 406422. iannisdezwart added a comment. Two changes: 1. Added tests for overloaded operators into SemanticHighlightingTests. 2. Fixed the way tokens are expanded. Previously `operator<<` would be split into two highlighting tokens: `operator` and `<<`.

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart updated this revision to Diff 406244. iannisdezwart added a comment. Fixed a bug I introduced by removing a null-check. I added the null-check back in again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 Files: clang-tools-e

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

iannisdezwart created this revision. iannisdezwart added a reviewer: nridge. iannisdezwart added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. iannisdezwart requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Re