[clang] HIPSPV: Unbundle SDL (PR #136412)

https://github.com/linehill commented: LGTM! Unfortunately, I don't have access rights to approve PRs nor land them. Maybe @yxsamliu can help you with that? https://github.com/llvm/llvm-project/pull/136412 ___ cfe-commits mailing list cfe-commits@lis

[clang] HIPSPV: Unbundle SDL (PR #136412)

@@ -0,0 +1,38 @@ +// Test HIPSPV static device library linking +// REQUIRES: system-linux +// UNSUPPORTED: system-windows + +// Create a dummy archive to test SDL linking +// RUN: rm -rf %t && mkdir %t +// RUN: touch %t/dummy.bc +// RUN: llvm-ar cr %t/libSDL.a %t/dummy.bc + +//

[clang] HIPSPV: Unbundle SDL (PR #136412)

@@ -0,0 +1,38 @@ +// Test HIPSPV static device library linking +// REQUIRES: system-linux +// UNSUPPORTED: system-windows + +// Create a dummy archive to test SDL linking +// RUN: rm -rf %t && mkdir %t +// RUN: touch %t/dummy.bc +// RUN: llvm-ar cr %t/libSDL.a %t/dummy.bc + +//

[clang] HIPSPV: Unbundle SDL (PR #136412)

@@ -2625,6 +2625,11 @@ void tools::AddStaticDeviceLibs(Compilation *C, const Tool *T, llvm::opt::ArgStringList &CC1Args, StringRef Arch, StringRef Target, bool isBitCodeSDL) { + +

[clang] [clang] [test] Skip a test that sets PATH= on Windows (PR #95096)

linehill wrote: Could the single test with the PATH manipulation be moved to a separate test file which is disabled on Windows? That way we could keep running the other tests on Windows. https://github.com/llvm/llvm-project/pull/95096 ___ cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

linehill wrote: Thanks, @svenvh. https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

linehill wrote: Ping, @svenvh. The patch has been rebased, good for landing? https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

https://github.com/linehill updated https://github.com/llvm/llvm-project/pull/77897 From 13609260c7ef2b57751975a6c7847439958978d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henry=20Linjam=C3=A4ki?= Date: Thu, 21 Dec 2023 08:43:16 +0200 Subject: [PATCH 1/2] [SPIR-V] Prefer llvm-spirv- tool Prefer

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

linehill wrote: Thanks for the review. Could you merge this PR on my behalf (I don't have write access)? https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

linehill wrote: @AnastasiaStulova, @MaskRay, gentle ping. https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

https://github.com/linehill updated https://github.com/llvm/llvm-project/pull/77897 From 6165987ab890156a503d7afa38ad5c88510368b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henry=20Linjam=C3=A4ki?= Date: Thu, 21 Dec 2023 08:43:16 +0200 Subject: [PATCH 1/2] [SPIR-V] Prefer llvm-spirv- tool Prefer

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

https://github.com/linehill created https://github.com/llvm/llvm-project/pull/77897 Prefer using `llvm-spirv-` tool (i.e. `llvm-spirv-18`) over plain `llvm-spirv`. If the versioned tool is not found in PATH, fall back to use the plain `llvm-spirv`. An issue with the using `llvm-spirv` is that

[clang] Add SPIRV support to HIPAMD toolchain (PR #75357)

linehill wrote: > > Perhaps we should consider prefixing it in some way (e.g. `hip-spirv` or > > `amd-spirv`) that leaves the door open for some special handling (enable a > > particular set of extensions only for amdgpu targeting SPIRV, try to deal > > with missing builtins etc.) / flexibilit