HaohaiWen wrote:
@MaskRay, may need to merge
https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/fprofile-sample-use.c
to clang/test/Driver/unknown-arg-drivermodes.test
https://github.com/llvm/llvm-project/pull/118640
___
cfe-commits mai
https://github.com/HaohaiWen approved this pull request.
LGTM for -Xlinker.
https://github.com/llvm/llvm-project/pull/118640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HaohaiWen wrote:
> > Better to double check with author who specified those CLOption.
>
> Do you mean the person that added `CLOption` to these flags? That was
> @tarunprabhu, but IIUC that was by mistake; his intention was to extend these
> flags only to Flang.
>
> Otherwise `-Xlinker` has b
https://github.com/HaohaiWen edited
https://github.com/llvm/llvm-project/pull/118640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HaohaiWen wrote:
Better to double check with author who specified those CL flags.
https://github.com/llvm/llvm-project/pull/118640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1055,11 +1055,11 @@ def z : Separate<["-"], "z">, Flags<[LinkerInput]>,
def offload_link : Flag<["--"], "offload-link">, Group,
HelpText<"Use the new offloading linker to perform the link job.">;
def Xlinker : Separate<["-"], "Xlinker">, Flags<[LinkerInput, RenderAsInput]
https://github.com/HaohaiWen closed
https://github.com/llvm/llvm-project/pull/117954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HaohaiWen created
https://github.com/llvm/llvm-project/pull/117973
We only support -fprofile-sample-use= for clang-cl.
>From 8a922dd6dc115878c5e488345885432b4ec9f16f Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Thu, 28 Nov 2024 15:38:44 +0800
Subject: [PATCH] [clang] Fix
https://github.com/HaohaiWen updated
https://github.com/llvm/llvm-project/pull/117954
>From 2307a8441a97fe5d436945c5826302d3e4c10147 Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Fri, 22 Nov 2024 13:21:24 +0800
Subject: [PATCH 1/2] [Driver] Do not add gno-column-info when using sampling
PGO
https://github.com/HaohaiWen closed
https://github.com/llvm/llvm-project/pull/117973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HaohaiWen wrote:
/fprofile-sample-use was introduced in #117282 and waived in #117970 .
https://github.com/llvm/llvm-project/pull/117973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HaohaiWen closed
https://github.com/llvm/llvm-project/pull/117970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HaohaiWen created
https://github.com/llvm/llvm-project/pull/117970
Those flags are introduced in #117282. They are not supported by MSVC.
>From 9809cd44885c43e879056db32fb2dcd8da580019 Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Thu, 28 Nov 2024 15:08:44 +0800
Subject: [
HaohaiWen wrote:
> Adding CLOption to -fprofile-sample-use= suffices. We don't need these
> CLJoined aliases. They are for MSVC options that are ported to clang. For
> clang-specific options, we don't want to add unneeded aliases.
Got it. I checked CL flags with MSVC. You're right.
Let me reve
https://github.com/HaohaiWen created
https://github.com/llvm/llvm-project/pull/117954
Column info is important for sampling PGO to generate/load profile file.
On windows, it will be automatically added when using -gdwarf to generate
profile file. It should also be generated when fprofile-sample-
https://github.com/HaohaiWen closed
https://github.com/llvm/llvm-project/pull/117282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8484,6 +8484,9 @@ def _SLASH_fp_strict : CLFlag<"fp:strict">, HelpText<"">,
Alias, A
def _SLASH_fsanitize_EQ_address : CLFlag<"fsanitize=address">,
HelpText<"Enable AddressSanitizer">,
Alias, AliasArgs<["address"]>;
+def : CLJoined<"fno-profile-sample-use">, Alias;
---
@@ -2660,7 +2660,7 @@ usual build cycle when using sample profilers for
optimization:
> clang-cl /O2 -gdwarf -gline-tables-only ^
/clang:-fdebug-info-for-profiling
/clang:-funique-internal-linkage-names ^
- /fprofile-sample-use=code.prof code.cc /Fe:code /f
https://github.com/HaohaiWen created
https://github.com/llvm/llvm-project/pull/117282
Sampling PGO has already been supported on Windows. This patch adds
/fprofile-sample-use= /fprofile-sample-use: /fno-profile-sample-use and
supports -fprofile-sample-use= for CL.
>From 8fbe3ed35afd38e2d7b36a89
https://github.com/HaohaiWen approved this pull request.
https://github.com/llvm/llvm-project/pull/113528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1729,8 +1729,6 @@ defm gnu_inline_asm : BoolFOption<"gnu-inline-asm",
"Disable GNU style inline asm">,
PosFlag>;
-def fprofile_sample_use : Flag<["-"], "fprofile-sample-use">, Group,
-Visibility<[ClangOption, CLOption]>;
def fno_profile_sample_use : Flag<[
https://github.com/HaohaiWen approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2454,7 +2481,14 @@ usual build cycle when using sample profilers for
optimization:
.. code-block:: console
- $ llvm-profgen --binary=./code --output=code.prof--perfdata=perf.data
+ $ llvm-profgen --binary=./code --output=code.prof --perfdata=perf.data
+
+ Wh
@@ -2434,6 +2449,15 @@ usual build cycle when using sample profilers for
optimization:
it provides better call information, which improves the accuracy of
the profile data.
+ When using SEP:
+
+ .. code-block:: console
+
+ $ sep -start -ec BR_INST_RETIRED.NEAR_T
@@ -2434,6 +2449,15 @@ usual build cycle when using sample profilers for
optimization:
it provides better call information, which improves the accuracy of
the profile data.
+ When using SEP:
+
+ .. code-block:: console
+
+ $ sep -start -ec BR_INST_RETIRED.NEAR_T
@@ -2434,6 +2449,15 @@ usual build cycle when using sample profilers for
optimization:
it provides better call information, which improves the accuracy of
the profile data.
+ When using SEP:
+
+ .. code-block:: console
+
+ $ sep -start -ec BR_INST_RETIRED.NEAR_T
Author: Haohai Wen
Date: 2023-07-06T22:18:58+08:00
New Revision: f97b61ed27aa6b0cef21e86e71d683feab32ce34
URL:
https://github.com/llvm/llvm-project/commit/f97b61ed27aa6b0cef21e86e71d683feab32ce34
DIFF:
https://github.com/llvm/llvm-project/commit/f97b61ed27aa6b0cef21e86e71d683feab32ce34.diff
LO
Author: Haohai Wen
Date: 2023-06-26T15:48:38+08:00
New Revision: 82dff24bde112984314568e7d581379fd0ea48e6
URL:
https://github.com/llvm/llvm-project/commit/82dff24bde112984314568e7d581379fd0ea48e6
DIFF:
https://github.com/llvm/llvm-project/commit/82dff24bde112984314568e7d581379fd0ea48e6.diff
LO
28 matches
Mail list logo
