[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

gmit added a comment. In D58178#1405397 , @MyDeveloperDay wrote: > Could I ask if you don't want to pursue this review that you Abandon it. Sure, I already wanted that, but I don't see any options that would result in closing the issue. Could you, plea

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

gmit added a comment. In D58178#1396523 , @MyDeveloperDay wrote: > I tried to repoduce this and I can't see how I could make a string literal > without a double quote, if it still failed with the current code it might > suggest the matcher matched somet

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

gmit added a comment. ? I'm sorry, but I disagree. Assert draws attention in the debug build only. In the release build asserts are not evaluated at all and the condition needs to be checked in the code that executes (if it makes sense and in this case it does as it causes reading out of strin

[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

gmit added a comment. Sorry, this is my first LLVM commit, so I don't really know the procedure. There is no test as it cannot be reproduced. The crash caused by this was spotted in one of our customer's crash dumps. The added condition should be obvious as it is tested in the assert just above

[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

gmit updated this revision to Diff 186675. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58178/new/ https://reviews.llvm.org/D58178 Files: RawStringLiteralCheck.cpp clang-tools-extra/tags/RELEASE_800/rc2/clang-tidy/modernize/RawStringLiteralChec

[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

gmit created this revision. gmit added a reviewer: alexfh. gmit added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. isRawStringLiteral will read from memory randomly if double quote is not found. Repository: rCTE Clang Tools Extra https:/