espositofulvio added a comment.
In http://reviews.llvm.org/D11781#423520, @rmaprath wrote:
> @espositofulvio: Thanks for the patch! :)
>
> Committed as r268734.
Glad to see you land the patch! Great work :)
Repository:
rL LLVM
http://reviews.llvm.org/D11781
_
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#400968, @rmaprath wrote:
> Hi, could I know the status of this? I'd like to push this forward.
>
> @espositofulvio: Are you working on this? (just checking since this has gone
> stale for a while). @EricWF: I can create a separate
espositofulvio updated the summary for this revision.
espositofulvio updated this revision to Diff 34104.
espositofulvio added a comment.
- Addressed possible ABI breaks
- Reverted to not using a __config_file as @jroelofs has two separate patch for
that
Repository:
rL LLVM
http://reviews.ll
espositofulvio added inline comments.
Comment at: include/__mutex_base:36
@@ -35,3 +37,3 @@
#else
- mutex() _NOEXCEPT {__m_ = (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER;}
#endif
EricWF wrote:
> Why was the cast insignificant?
The cast was significant, but it
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#227446, @EricWF wrote:
> This patch has a long way to go but it has also come a long way. Here are a
> couple of problems I see with it.
>
> 2. This patch adds a lot of headers. libc++ has historically tried to keep
> the number
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#222572, @joerg wrote:
> This feels a bit like a regression. Before, libc++ works fine by just
> pointing into the include directory.
With my change it still is fine pointing at the include directory. But as I
said, Jonathan fee
espositofulvio added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
mclow.lists wrote:
> I'm reluctant to do this; because every include file slows down compilation -
> for every program that we com
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#222452, @mclow.lists wrote:
> How does this change interact with http://reviews.llvm.org/D11963 ?
The difference between this and @jroelofs's one is that this copy the
__config_site in the source directory which makes everythin
espositofulvio removed rL LLVM as the repository for this revision.
espositofulvio updated this revision to Diff 31874.
espositofulvio added a comment.
Thread library selection is done at configure time by CMake now.
http://reviews.llvm.org/D11781
Files:
.gitignore
CMakeLists.txt
include/
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
jroelofs wrote:
> jroelofs wrote:
> > espositofulvio wrote:
> > > theraven wrote:
> >
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
theraven wrote:
> espositofulvio wrote:
> > jroelofs wrote:
> > > espositofulvio wrote
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
jroelofs wrote:
> espositofulvio wrote:
> > jroelofs wrote:
> > > jroelofs wrote:
> >
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
jroelofs wrote:
> jroelofs wrote:
> > @espositofulvio: @ed meant this:
> >
> > ```
>
espositofulvio marked 5 inline comments as done.
espositofulvio added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
espositofulvio updated this revision to Diff 31716.
espositofulvio added a comment.
Added __CloudABI__ to the list of platform using pthread
Repository:
rL LLVM
http://reviews.llvm.org/D11781
Files:
include/__config
include/__mutex_base
include/mutex
include/support/condition_variabl
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__linux__) ||
defined(__APPLE__)
+# define _LIBCPP_THREAD_API _LIBCPP_PTHREAD
ed wrot
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__linux__) ||
defined(__APPLE__)
+# define _LIBCPP_THREAD_API _LIBCPP_PTHREAD
therave
espositofulvio added inline comments.
Comment at: include/__mutex_base:246
@@ -266,3 +245,3 @@
-class _LIBCPP_TYPE_VIS condition_variable
+class _LIBCPP_TYPE_VIS condition_variable : private
__libcxx_support::condition_variable
{
theraven wrote:
> espositofulv
espositofulvio added inline comments.
Comment at: include/__mutex_base:246
@@ -266,3 +245,3 @@
-class _LIBCPP_TYPE_VIS condition_variable
+class _LIBCPP_TYPE_VIS condition_variable : private
__libcxx_support::condition_variable
{
theraven wrote:
> espositofulv
espositofulvio added inline comments.
Comment at: include/__mutex_base:19
@@ +18,3 @@
+#ifndef _WIN32
+#include
+#endif
jroelofs wrote:
> I think it might make sense to create a file: `` where the
> contents are just:
>
> ```
> #ifndef _WIN32
> #include
> #end
20 matches
Mail list logo
