[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

FPar wrote: @efriedma-quic Thank you for being patient. I do not have write permissions, can you please merge this for me? https://github.com/llvm/llvm-project/pull/100785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785 >From 13f60e1835c2a5876fa873fc5b4087f942a90316 Mon Sep 17 00:00:00 2001 From: Fabian Parzefall Date: Fri, 26 Jul 2024 10:46:22 -0700 Subject: [PATCH 1/2] [clang] Check inline defs when emitting speculative vtable

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785 >From 13f60e1835c2a5876fa873fc5b4087f942a90316 Mon Sep 17 00:00:00 2001 From: Fabian Parzefall Date: Fri, 26 Jul 2024 10:46:22 -0700 Subject: [PATCH] [clang] Check inline defs when emitting speculative vtable Clang

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785 >From 0f43c9933022ec825bfe3ede5c1622900eb86691 Mon Sep 17 00:00:00 2001 From: Fabian Parzefall Date: Fri, 26 Jul 2024 10:46:22 -0700 Subject: [PATCH] [clang] Check inline defs when emitting speculative vtable Clang

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

FPar wrote: Yes, that sums it up well. I will see to adding a patch clarifying this in the source. Thank you! https://github.com/llvm/llvm-project/pull/100785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

https://github.com/FPar updated https://github.com/llvm/llvm-project/pull/100785 >From 0f43c9933022ec825bfe3ede5c1622900eb86691 Mon Sep 17 00:00:00 2001 From: Fabian Parzefall Date: Fri, 26 Jul 2024 10:46:22 -0700 Subject: [PATCH] [clang] Check inline defs when emitting speculative vtable Clang

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

FPar wrote: @efriedma-quic Have you been able to take another look? https://github.com/llvm/llvm-project/pull/100785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

FPar wrote: Yes, certainly! The example below demonstrates a case where the `available_externally` vtable mismatches the actual definition, and holds a reference to a symbol that does not exist in the final program. You can see the mismatch by compiling with `-O1 -flto=thin`. The generated LL

[clang] [clang] Check inline defs when emitting speculative vtable (PR #100785)

https://github.com/FPar created https://github.com/llvm/llvm-project/pull/100785 Clang should only emit an available_externally vtable when there are no unused virtual inline functions. Currently, if such such a function is declared without inline inside the class, but is defined inline outside