ezhulenev accepted this revision.
ezhulenev added a comment.
This revision is now accepted and ready to land.
Yes, that's the correct MLIR way of passing attributes to LLVM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127471/new/
https://reviews.
ezhulenev accepted this revision.
ezhulenev added inline comments.
Comment at: mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp:201
+ StringAttr::get(ctx, "0")})}));
+
CoroMachinery machinery;
nit: builder has an AP
ezhulenev added a subscriber: mehdi_amini.
ezhulenev added a comment.
There are two places where in MLIR you can put an attribute to coroutine
functions:
1.
https://github.com/llvm/llvm-project/blob/main/mlir/lib/Dialect/Async/Transforms/AsyncToAsyncRuntime.cpp#L126
This is the point when coro
