[PATCH] D47864: [python] Fix most Python binding unittests on Windows

ethanhs added a comment. In https://reviews.llvm.org/D47864#1139750, @jbcoe wrote: > Would you like me to commit this for you? Sure, that would be great! I don't have commit rights so I was waiting for someone to do it. Thanks! Repository: rC Clang https://reviews.llvm.org/D47864 _

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs accepted this revision. ethanhs added a comment. Works great! https://reviews.llvm.org/D47672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs added a comment. In https://reviews.llvm.org/D47672#1128863, @rnk wrote: > In https://reviews.llvm.org/D47672#1128308, @hans wrote: > > > It sounds like adding proper support for HLE prefixes is a largeish project. > > > > ctopper, rnk: Do you think it would be worth adding inline asm ver

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

ethanhs added a comment. In https://reviews.llvm.org/D47864#1124948, @bkramer wrote: > I don't know much about the python bindings, but this is probably fine. Yeah I wasn't really sure who to add so I looked at the commit history. Thank you for adding the right people. Repository: rC Clang

[PATCH] D47864: [python] Fix most Python binding unittests on Windows

ethanhs created this revision. ethanhs added a reviewer: bkramer. Herald added a subscriber: cfe-commits. This fixes all but one of the test cases for Windows. TestCDB will take more work to debug, as CompilationDatabase seems not to work correctly. Repository: rC Clang https://reviews.llvm.o

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs added inline comments. Comment at: lib/Headers/immintrin.h:387 +#if defined(__i386__) || defined(__x86_64__) +static __inline__ long __DEFAULT_FN_ATTRS +_InterlockedExchange_HLEAcquire(long volatile *_Target, long _Value) { craig.topper wrote: > what is _

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs updated this revision to Diff 150189. ethanhs added a comment. Guard to be used only under MSVC, define default FN attrs Repository: rC Clang https://reviews.llvm.org/D47672 Files: lib/Headers/immintrin.h lib/Headers/intrin.h Index: lib/Headers/intrin.h =

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs marked an inline comment as done. ethanhs added a comment. In https://reviews.llvm.org/D47672#1123953, @craig.topper wrote: > We (Intel) have discussed this a little internally. I'll be responding more > shortly. Great! FWIW, re intrin.h vs immintrin.h, the documentation for these put

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs added a comment. In https://reviews.llvm.org/D47672#1121181, @rnk wrote: > > They are a hint to the processor that this is a short critical section, and > it is likely that the entire critical section can be entered, run, and > committed to memory before another thread needs to use

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

ethanhs created this revision. Herald added a subscriber: cfe-commits. Adds MSVC intrinsics for atomic exchange and compare & exchange. Repository: rC Clang https://reviews.llvm.org/D47672 Files: lib/Headers/immintrin.h lib/Headers/intrin.h Index: lib/Headers/intrin.h =