[PATCH] D143704: [Flang] Part one of Feature List action

schweitz added a comment. I should've mentioned in my comment that the TODO macros are meant to be deleted. Some day, there will be no more TODOs and there should be a huge celebration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ ht

[PATCH] D143704: [Flang] Part one of Feature List action

schweitz added a comment. In D143704#4130124 , @jdoerfert wrote: > In D143704#4130062 , @clementval > wrote: > >> Where is this coming from? Did I miss where this was discussed. > > It's discussed here, for now.

[PATCH] D124669: [flang][driver] Add support for -save-temps

schweitz added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option,FlangOpti

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

schweitz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

schweitz added inline comments. Herald added a project: All. Comment at: flang/lib/Frontend/FrontendActions.cpp:561 + std::make_unique(triple); + CodeGenPasses.add(new llvm::TargetLibraryInfoWrapperPass(*TLII)); + Got jumbled around somehow. TLII is allocat

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

schweitz added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:43 using namespace Fortran::frontend; +using namespace llvm; You'll want to keep in mind that some class names are overloaded between llvm and Fortran::xyz namespaces and even

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

schweitz added inline comments. Comment at: clang/include/clang/Driver/Options.td:4815 -} +} // let Flags = [CC1Option, CC1AsOption, NoDriverOption] + Is this comment something left over from edits? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

schweitz added a comment. > In D120246#3339289 , @tschuett > wrote: > >> https://reviews.llvm.org/D117809 >> >> There was a discussion that `-emit-llvm` is considered a mistake. > > Which comment are you referring to specifically? Also, `-emit-llvm` is >

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

schweitz accepted this revision. schweitz added a comment. This revision is now accepted and ready to land. LGTM Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1581540876f: [clang-tidy] Allows the prevailing include header guard in Flang to be… (authored by schweitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

schweitz updated this revision to Diff 274278. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82807/new/ https://reviews.llvm.org/D82807 Files: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp Index: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

schweitz created this revision. schweitz added reviewers: bkramer, hokein. schweitz added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. to be recognized rather