[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

2021-06-23 Thread Eliza Velasquez via Phabricator via cfe-commits
exv requested changes to this revision. exv added a comment. This revision now requires changes to proceed. Oops, didn't mean to accept, see my other comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104388/new/ https://reviews.llvm.org/D104388

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

2021-06-23 Thread Eliza Velasquez via Phabricator via cfe-commits
exv accepted this revision. exv added a comment. This revision is now accepted and ready to land. I have a few concerns about this implementation: - If the incorrect formatting is due to `lock` and `using` not being recognized correctly, shouldn't we instead fix how those keywords are parsed? -

[PATCH] D101862: [clang-format] Rename common types between C#/JS

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv updated this revision to Diff 343182. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv updated this revision to Diff 343180. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv updated this revision to Diff 343177. exv added a comment. Rebase again in an attempt to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Format/FormatToken.h clang/lib/Form

[PATCH] D101862: [clang-format] Rename common types between C#/JS

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv updated this revision to Diff 343144. exv added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101862/new/ https://reviews.llvm.org/D101862 Files: clang/lib/Format/FormatToken.h clang/lib/Format/FormatTokenLexer.cpp clan

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv updated this revision to Diff 343143. exv marked an inline comment as done. exv added a comment. - Incorporate curdeius's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101860/new/ https://reviews.llvm.org/D101860 Files: clang/lib/Fo

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv added a comment. Rebased and comments addressed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

2021-05-05 Thread Eliza Velasquez via Phabricator via cfe-commits
exv updated this revision to Diff 343142. exv marked 3 inline comments as done. exv added a comment. - Incorporate krasimir's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://reviews.llvm.org/D101702 Files: clang/lib/Fo

[PATCH] D101862: [clang-format] Rename common types between C#/JS

2021-05-04 Thread Eliza Velasquez via Phabricator via cfe-commits
exv created this revision. exv added a reviewer: curdeius. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is based on https://reviews.llvm.org/D101860 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D10186

[PATCH] D101860: [clang-format] Fix C# nullable-related errors

2021-05-04 Thread Eliza Velasquez via Phabricator via cfe-commits
exv created this revision. exv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff is based on https://reviews.llvm.org/D101702. This fixes two errors: Previously, clang-format was splitting up type identifiers from the nullable ?.

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

2021-05-04 Thread Eliza Velasquez via Phabricator via cfe-commits
exv added a comment. I have completed two other formatting fixes related to C# 8 nullables since my last commit. Should I create a new review request for those or update this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101702/new/ https://r